[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/213#discussion_r92344993 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -53,18 +53,37 @@ var handlers = { }, 'resource-file':{

[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/213#discussion_r92344997 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -53,18 +53,37 @@ var handlers = { }, 'resource-file':{

[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/213#discussion_r92344562 --- Diff: template/cordova/lib/JsprojManager.js --- @@ -121,7 +121,12 @@ jsprojManager.prototype = { copyToOutputDirectory.text

[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/213#discussion_r92345318 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -188,7 +207,7 @@ module.exports.getUninstaller = function(type) { }; f

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92348958 --- Diff: lib/appium/AppiumRunner.js --- @@ -102,6 +102,24 @@ function getConfigPath(appPath) { return path.join(appPath, 'config.xml');

[GitHub] cordova-ios pull request #281: Hard link instead of soft linking

GitHub user Mitko-Kerezov opened a pull request: https://github.com/apache/cordova-ios/pull/281 Hard link instead of soft linking Softlinking resource files (.wav files [for example](https://github.com/apache/cordova-plugin-dialogs/tree/master/src/ios/CDVNotification.bundle)) leads

[GitHub] cordova-ios issue #281: Hard link instead of soft linking

Github user Mitko-Kerezov commented on the issue: https://github.com/apache/cordova-ios/pull/281 Note: I've tested this with `cordova-android` and it doesn't seem to reproduce - for one reason or another `gradle` seems to follow symlinks when zipping up the `.apk` file, so this fix ma

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/217#discussion_r92389331 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType, buildarch,

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/217#discussion_r92399214 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType, bu

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/217#discussion_r92399420 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType, bu

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/217#discussion_r92402062 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType, buildarch,

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92402784 --- Diff: appium-tests/common/common.spec.js --- @@ -242,7 +248,6 @@ describe('Contacts Android', function () { describe('Picki

[GitHub] cordova-plugin-contacts issue #143: Jasmine use of `afterAll` and label twea...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/143 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-contacts/pull/143/commits/c6dcdda9663a322a38cc7a1cf3fe3901356

[GitHub] cordova-ios issue #281: Hard link instead of soft linking

Github user kerrishotts commented on the issue: https://github.com/apache/cordova-ios/pull/281 Can you update the title so that it includes the issue number with the following form: issue#: description That way the issue tracker will get all the updates here automatic

[GitHub] cordova-ios issue #281: CB-12247: Hard link instead of soft linking

Github user Mitko-Kerezov commented on the issue: https://github.com/apache/cordova-ios/pull/281 Sure thing @kerrishotts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

Github user ktop commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/213#discussion_r92438038 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -53,18 +53,37 @@ var handlers = { }, 'resource-file':{ install:func

[GitHub] cordova-docs pull request #669: Update spec.md

GitHub user p-w opened a pull request: https://github.com/apache/cordova-docs/pull/669 Update spec.md ### Platforms affected None ### What does this PR do? Better understanding of German translation of plugin.xml spec. ### What testing has been done on this

Re: [DRAFT] [REPORT] Cordova - December 2016

Thanks for the edit suggestions everyone, sending the report now. On Tue, Dec 13, 2016 at 7:02 PM, Filip Maj wrote: > LGTM > > On Tue, Dec 13, 2016 at 5:11 PM, Shazron wrote: > > I will send this out later tonight/early tomorrow if there are no > comments: > > > > https://github.com/cordova/apa

[GitHub] cordova-docs pull request #668: CB-12239 (windows) Add documentation about b...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/668#discussion_r92459442 --- Diff: www/docs/en/dev/guide/platforms/win8/index.md --- @@ -287,6 +287,37 @@ powershell -Command " & {dir -path cert:\LocalMachine\My | whe

[GitHub] cordova-windows issue #213: CB-12163 Make resource-file copy files again

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/213 Looks good 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[DISCUSS] Plugins Release Dec 12th, 2016

Two plugins that were omitted from the last released are planned for this one: 1) Updates in cordova-plugin-battery-status that we discussed (--browserify fixes for Windows) 2) The package.json update in cordova-plugin-inappbrowser (same version, 1.6.0) cordova-plugin-screen-orientation release ha

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92469947 --- Diff: lib/appium/AppiumRunner.js --- @@ -102,6 +102,24 @@ function getConfigPath(appPath) { return path.join(appPath, 'config.xml'

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/510 Fixjasmine : CB:12018 - updating tests in cordova-lib to use jasmine instead of jasmine-node ### Platforms affected ### What does this PR do? ### What tes

[GitHub] cordova-lib issue #510: Fixjasmine : CB:12018 - updating tests in cordova-li...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/510 Can you also update package.json for cordova-lib and cordova-common, removing jasmine-node and adding jasmine, + updating the package.json scripts (like test) to use jasmine instead of jasmin

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92480348 --- Diff: cordova-common/spec/CordovaCheck.spec.js --- @@ -30,11 +30,12 @@ describe('findProjectRoot method', function() { process.env.PWD =

Re: [DISCUSS] Plugins Release Dec 12th, 2016

+1 2016-12-14 20:01 GMT+01:00 Shazron : > Two plugins that were omitted from the last released are planned for this > one: > 1) Updates in cordova-plugin-battery-status that we discussed (--browserify > fixes for Windows) > 2) The package.json update in cordova-plugin-inappbrowser (same version,

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92480797 --- Diff: cordova-lib/spec-cordova/lazy_load.spec.js --- @@ -34,8 +34,8 @@ var lazy_load = require('../src/cordova/lazy_load'), describe('lazy_load

[VOTE] Plugins Release (Dec 12th 2016)

Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-12237 The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-12237/

[GitHub] cordova-docs pull request #670: CB-12237 - Blog post for Dec 12 Plugins Rele...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/670 CB-12237 - Blog post for Dec 12 Plugins Release ### Platforms affected None ### What does this PR do? Blog post for Dec 12 Plugins Release ### What testing h

[DRAFT] [BLOG POST] Plugins Release Dec 12th 2016

https://github.com/apache/cordova-docs/pull/670

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

Github user filmaj closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92491112 --- Diff: lib/appium/AppiumRunner.js --- @@ -102,6 +102,24 @@ function getConfigPath(appPath) { return path.join(appPath, 'config.xml');

Re: [DISCUSS] Plugins Release Dec 12th, 2016

+1 On Wed, Dec 14, 2016 at 12:19 PM, julio cesar sanchez wrote: > +1 > > 2016-12-14 20:01 GMT+01:00 Shazron : > >> Two plugins that were omitted from the last released are planned for this >> one: >> 1) Updates in cordova-plugin-battery-status that we discussed (--browserify >> fixes for Windows)

[GitHub] cordova-docs issue #670: CB-12237 - Blog post for Dec 12 Plugins Release

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-docs/pull/670 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

(CB-12241) Cordova Device plugin: device.serial value does not match the phone's serial number

Please see https://issues.apache.org/jira/browse/CB-12241 . Based on a quick Google search, I turned this up: http://stackoverflow.com/questions/14161282/serial-number-from-samsung-device-running-android

Re: (CB-12241) Cordova Device plugin: device.serial value does not match the phone's serial number

I am replying on the issue in JIRA, because there is no way to know if the issue creator is on the dev list, and these replies don't seem to make it back. @purplecabbage risingj.com On Wed, Dec 14, 2016 at 8:13 PM, Kerri Shotts wrote: > Please see https://issues.apache.org/jira/browse/CB-1224