Hey Karen, sorry for last minute response.
I’m _personally_ +1 for getting back the original behavior (i.e. copy instead
of referencing the original files), I only think that we’d to make sure that
the case, described in https://github.com/apache/cordova-windows/pull/139 still
works with that n
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/18#discussion_r92122133
--- Diff: lib/paramedic.js ---
@@ -271,9 +271,13 @@ ParamedicRunner.prototype.runLocalTests = function () {
})
.then(function(com
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/217
CB-12239 Add buildFlag option similar to iOS
### What does this PR do?
This PR adds `buildFlag` CLI argument and corresponding option for
`build.json` file (simi
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/217
## [Current
coverage](https://codecov.io/gh/apache/cordova-windows/pull/217?src=pr) is
76.22% (diff: 63.63%)
> Merging
[#217](https://codecov.io/gh/apache/cordova-windows/pull/217?sr
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/217
@TimBarham, @alsorokin, @daserge, could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-docs/pull/668
CB-12239 (windows) Add documentation about build flags for Windows
### Platforms affected
Windows
### What does this PR do?
Documents use of `build
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/217
Pls also see corresponding documentation update here:
https://github.com/apache/cordova-docs/pull/668
---
If your project is set up for it, you can reply to this email and have you
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-windows/pull/218
CB-12238 [Windows] Colorize titlebar to match splash bg color
### Platforms affected
Windows
### What does this PR do?
Colorize titlebar to match splash background
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/218
## [Current
coverage](https://codecov.io/gh/apache/cordova-windows/pull/218?src=pr) is
76.13% (diff: 100%)
> Merging
[#218](https://codecov.io/gh/apache/cordova-windows/pull/218?src=
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/18#discussion_r92180262
--- Diff: package.json ---
@@ -51,7 +51,7 @@
"wd": "^0.4.0"
},
"devDependencies": {
-"jasmine-node": "~1",
-"js
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92186809
--- Diff: appium-tests/common/common.spec.js ---
@@ -228,11 +228,18 @@ describe('Contacts Android', function () {
function checkSessi
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92190238
--- Diff: appium-tests/common/common.spec.js ---
@@ -228,11 +228,18 @@ describe('Contacts Android', function () {
function checkSessi
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/18#discussion_r92190252
--- Diff: package.json ---
@@ -51,7 +51,7 @@
"wd": "^0.4.0"
},
"devDependencies": {
-"jasmine-node": "~1",
-
Github user helloworld20160101 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/115
Would there be any chance for ios as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
No problem. I'll work on getting the copy functionality and reference flag
in and then I can take a look at your suggestion. Sounds like a useful
feature to me.
On Tue, Dec 13, 2016 at 3:36 AM, Котиков Владимир <
kotikov.vladi...@gmail.com> wrote:
> Hey Karen, sorry for last minute response.
>
>
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/508
CB-11908 Add tests for edit-config in config.xml and fix typo
### Platforms affected
cordova-common
### What does this PR do?
I had this commit ready to go, but forgot to
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/509
CB-12163 Add reference attrib to resource-file for Windows
### Platforms affected
cordova-common for Windows
### What does this PR do?
Adds a new attribute to the resourc
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92285052
--- Diff: appium-tests/common/common.spec.js ---
@@ -242,7 +248,6 @@ describe('Contacts Android', function () {
describe('Picki
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/143
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-contacts/pull/143/commits/8c96fa7896fb39078d818122825e4ef59f8
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/4
This pull request is missing about 10 tests.
There is also some weird history happening, ex.
`www/screenorientation.android.js â tests/tests.js`
---
If your proj
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
I will send this out later tonight/early tomorrow if there are no comments:
https://github.com/cordova/apache-board-reports/blob/master/2016/2016-12.md
LGTM
On Tue, Dec 13, 2016 at 5:11 PM, Shazron wrote:
> I will send this out later tonight/early tomorrow if there are no comments:
>
> https://github.com/cordova/apache-board-reports/blob/master/2016/2016-12.md
-
To unsubscribe,
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92337971
--- Diff: appium-tests/common/common.spec.js ---
@@ -242,7 +248,6 @@ describe('Contacts Android', function () {
describe('Pi
28 matches
Mail list logo
