Hi again Filip, you are most welcome!
>> - cordova-paramedic configs are pulled from cordova-medic repo.
>> (?) requires an extra pull in CI.
Yeah. This is kind of rudimentary thing, I think we can safely transfer them to
cordova-paramedic repo. This will require some Jenkins jobs changes, I can
GitHub user kelvinhokk opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24
CB-10228:(iOS) AppendUserAgent not working with WKWebView
### Platforms affected
iOS: Currently the wkWebview users the default user agent, ignoring
Cordova'
Github user daserge commented on the issue:
https://github.com/apache/cordova-windows/pull/212
@vladimir-kotikov could you please take a look again?
I've also added a fix for [CB-12192 - No SplashScreen on Windows when
content.src is subpage](https://issues.apache.org/jira/browse/C
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89991524
--- Diff: template/cordova/lib/prepare.js ---
@@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest) {
manifest.g
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89996388
--- Diff: template/cordova/lib/prepare.js ---
@@ -439,6 +490,109 @@ function getUAPVersions(config) {
};
}
+/** Check
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89991151
--- Diff: template/cordova/lib/AppxManifest.js ---
@@ -416,6 +417,18 @@ AppxManifest.prototype.getVisualElements = function ()
{
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89993606
--- Diff: template/cordova/lib/prepare.js ---
@@ -353,6 +391,13 @@ function mapImageResources(images, imagesDir) {
event
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89990562
--- Diff: cordova-js-src/splashscreen.js ---
@@ -58,8 +58,45 @@ function readBoolFromCfg(preferenceName, defaultValue,
cfg) {
}
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89991437
--- Diff: template/cordova/lib/prepare.js ---
@@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest) {
manifest.g
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89994632
--- Diff: template/cordova/lib/prepare.js ---
@@ -439,6 +492,107 @@ function getUAPVersions(config) {
};
}
+/** Check
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89992916
--- Diff: template/cordova/lib/prepare.js ---
@@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest) {
manifest.g
Github user erikramalho commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/170
+1 for to merge it ASAP! cheers @daserge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r90007607
--- Diff: template/cordova/lib/prepare.js ---
@@ -439,6 +490,109 @@ function getUAPVersions(config) {
};
}
+/** Checks if a ta
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r90007897
--- Diff: template/cordova/lib/AppxManifest.js ---
@@ -416,6 +417,18 @@ AppxManifest.prototype.getVisualElements = function ()
{
}
Github user daserge commented on the issue:
https://github.com/apache/cordova-windows/pull/212
@vladimir-kotikov addressed, thanks! It is good to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user ktop commented on the issue:
https://github.com/apache/cordova-lib/pull/468
SGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-lib/pull/468
I think top level might make sense here if it's a file that the IDE needs
but not the app (configuration file like google-services.json/plist)
Can the launch images and icons be out
I want to get some discussion on what the plugin.xml tag
should be doing in Windows because I didn't know that it had been changed
for a while now.
jira issue: https://issues.apache.org/jira/browse/CB-12163
Current behavior: Doesn't copy resource file from src to target. Instead,
it will use a r
Github user dpogue commented on the issue:
https://github.com/apache/cordova-lib/pull/468
For clarity, "top-level support" means allowing `resource-file` tags that
aren't scoped to a particular platform.
i.e.,
```xml
```
This would copy `./foo.xm
Welcome back Fil!
On Tue, Nov 29, 2016 at 12:28 AM wrote:
> Hi again Filip, you are most welcome!
>
> >> - cordova-paramedic configs are pulled from cordova-medic repo.
> >> (?) requires an extra pull in CI.
> Yeah. This is kind of rudimentary thing, I think we can safely transfer
> them to cord
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-lib/pull/468
Then looks good to me, I can't think any example right now where the same
file should be needed for all platforms
---
If your project is set up for it, you can reply to this email and have
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/73
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/73/commits/eb0977102e4de10836e2d9c8a5af5
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/73
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/73/commits/0e8195c185a9498e4996c78e02da9
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24
Note: this passes tests when run locally (the CI has a known issue that it
fails).
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23#discussion_r90092299
--- Diff: src/ios/CDVWKWebViewEngine.m ---
@@ -123,6 +123,32 @@ - (void)pluginInitialize
name:UIApplicationWillEnt
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23#discussion_r90091089
--- Diff: src/ios/CDVWKWebViewEngine.m ---
@@ -123,6 +123,32 @@ - (void)pluginInitialize
name:UIApplicationWillEnt
Nightly build #242 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g
cordova@nightly'
For details check build console at
https://builds.apache.org/job/cordova-nightly/242/consoleFull
-
Jenkins for Apache Cordova
-
GitHub user yamane-dsys opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/58
CB-12199: (android) Add SDK version property for Android
### Platforms affected
Android
### What does this PR do?
Add device.sdkversion property
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/58
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-device/pull/58/commits/ef9d50ef50ba7e26a40c93a5fe0a78287b6bae11)
29 matches
Mail list logo
