Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/42#discussion_r86942697
--- Diff: src/windows/BatteryProxy.js ---
@@ -19,7 +19,38 @@
*
*/
-/* global WinJS, BatteryStatus */
+/* globa
Github user daserge commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/42
Tested and it works good on all targets (Win 10 desktop, Win 10 Mobile,
Windows Phone 8.1).
LGTM apart the comments.
---
If your project is set up for it, you can reply to
Github user lucatorella commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/167
https://github.com/apache/cordova-plugin-file-transfer/pull/164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-windows/pull/209
CB-12124: Make available device capabilities in
package.windows10.appxmanifest
### What does this PR do?
This PR makes available to use device capabilities in
package
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/209
## [Current
coverage](https://codecov.io/gh/apache/cordova-windows/pull/209?src=pr) is
74.64% (diff: 100%)
> Merging
[#209](https://codecov.io/gh/apache/cordova-windows/pull/209?src=
Github user daserge commented on the issue:
https://github.com/apache/cordova-windows/pull/209
LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user wanjochan commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/125
failed at simulator (iphone6s+, 9.2) , the last alert() in the callback is
not working
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/42
@daserge, addressed your notes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user daserge commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/42
@vladimir-kotikov LGTM, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-battery-status/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user jonathanli2 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
Would it be better to add an if condition check, and only apply the change
if WKWebView is used? so that the change will not affect UIWebView's old
behavior by any chance.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/42
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-battery-status/pull/42/commits/9f236357b0488e8aecad852539
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Nightly build #221 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g
cordova@nightly'
For details check build console at
https://builds.apache.org/job/cordova-nightly/221/consoleFull
-
Jenkins for Apache Cordova
-
GitHub user APMann opened a pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/43
Update README.md
The documentation is wrong, the functions return two objects instead of one.
### Platforms affected
### What does this PR d
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/43
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-battery-status/pull/43/commits/faef22b293e0b0af2bf95d70af
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/209
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user daserge commented on the issue:
https://github.com/apache/cordova-windows/pull/209
Merged, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
18 matches
Mail list logo
