I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran npm test
On Thu, Oct 6, 2016 at 10:04 PM, Steven Gill wrote:
> Please review and vote on this cordova-common Release
>
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/265#discussion_r82344533
--- Diff: tests/spec/unit/build.spec.js ---
@@ -0,0 +1,255 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more cont
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/265#discussion_r82344457
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -199,33 +220,54 @@ module.exports.findXCodeProjectIn =
findXCodeProjectIn;
* @param {B
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/265#discussion_r82344341
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -199,33 +220,54 @@ module.exports.findXCodeProjectIn =
findXCodeProjectIn;
* @param {B
I vote +1:
* Ran coho audit-license-headers
* Ran coho check-license
* Ran npm test
-
Best regards, Vladimir
-Original Message-
From: Shazron [mailto:shaz...@gmail.com]
Sent: Friday, October 7, 2016 10:38 AM
To: dev@cordova.apache.org
Subject: Re: [Vote] Cordova-common@1.5.0 Release
I v
Github user TanaseButcaru commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/170
Hi @davidbarre,
At the moment, I don't have the time to continue upgrading my unofficial
plugin with version 2.3.
The last time I have made changes to my unofficial p
Github user beatgrabe commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/191
@vladimir-kotikov Thank you a lot, your PR fixed exactly an issue I was
facing today!
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user boboldehampsink commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/20
The new config.xml settings fixed this for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/339#discussion_r82400488
--- Diff: bin/templates/cordova/Api.js ---
@@ -212,6 +212,11 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
installOpt
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/339#discussion_r82400883
--- Diff: bin/templates/cordova/Api.js ---
@@ -349,13 +354,24 @@ Api.prototype.run = function(runOptions) {
*/
Api.prototype.clean = func
Github user adzellman commented on the issue:
https://github.com/apache/cordova-ios/pull/265
@shazron Review comments addressed. Please re-review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/339
Moving the example into core, tested it locally, everything appears to
check out on MacOS. Hopefully there's no weird Windows issues.
---
If your project is set up for it, you can reply t
I vote +1:
* Ran coho audit-license-headers
* Ran coho check-license
* Ran npm test
@purplecabbage
risingj.com
On Fri, Oct 7, 2016 at 12:38 AM, Shazron wrote:
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> sub
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/339
OK, there's something wrong with how we're cleaning in the chain. I think
we need to do it later in the promise chain.
---
If your project is set up for it, you can reply to this email an
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/339
I'm not getting the same errors locally when I run the same tests, could
this be a weird travis timeout issue?
---
If your project is set up for it, you can reply to this email and have yo
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-lib/pull/497
CB-11976 - Add deprecated node version warning for 0.x
### Platforms affected
All
### What does this PR do?
Prints out a warning on `prepare` that you are using a depr
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/339
@alsorokin I'm going to keep the commits exploded and as is on this PR. If
this looks good to you, I'll merge this in tonight.
---
If your project is set up for it, you can reply to this
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/497
## [Current
coverage](https://codecov.io/gh/apache/cordova-lib/pull/497?src=pr) is 80.41%
(diff: 100%)
> Merging [#497](https://codecov.io/gh/apache/cordova-lib/pull/497?src=pr)
into [ma
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/266
CB-11729 - template file MainViewController.m has deprecated override
shouldAutorotateToInterfaceOrientation
### Platforms affected
iOS
### What does this PR do?
Remove un
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/266
## [Current
coverage](https://codecov.io/gh/apache/cordova-ios/pull/266?src=pr) is 56.50%
(diff: 100%)
> Merging [#266](https://codecov.io/gh/apache/cordova-ios/pull/266?src=pr)
into [ma
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/267
CB-11970 - Support CocoaPod pod specification other than version
### Platforms affected
iOS
### What does this PR do?
Add support for CocoaPod specs that are not just versions,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/497
Making a change so it is shown on every command, not just `prepare`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/267
## [Current
coverage](https://codecov.io/gh/apache/cordova-ios/pull/267?src=pr) is 56.60%
(diff: 87.50%)
> Merging [#267](https://codecov.io/gh/apache/cordova-ios/pull/267?src=pr)
into [
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/267
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-android/pull/339
Tested it on Windows, it works! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/265#discussion_r82490970
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -199,33 +219,52 @@ module.exports.findXCodeProjectIn =
findXCodeProjectIn;
* @param {B
Github user adzellman commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/265#discussion_r82491459
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -199,33 +219,52 @@ module.exports.findXCodeProjectIn =
findXCodeProjectIn;
* @param
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/265#discussion_r82491705
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -199,33 +219,52 @@ module.exports.findXCodeProjectIn =
findXCodeProjectIn;
* @param {B
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/339
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Nightly build #171 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g
cordova@nightly'
For details check build console at
https://builds.apache.org/job/cordova-nightly/171/consoleFull
-
Jenkins for Apache Cordova
-
Github user adzellman commented on the issue:
https://github.com/apache/cordova-ios/pull/265
I'm not sure why Travis would fail to run `n stable`. I just tried it
locally and it installed v6.6.0 just fine. Can we re-trigger Travis?
---
If your project is set up for it, you can reply
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/498
CB-11985 Check if cached platform/plugin exists before 'npm cache'
### What does this PR do?
Before calling `npm cache add` when installing a platform or plugin, look
for an existing `pac
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/498
## [Current
coverage](https://codecov.io/gh/apache/cordova-lib/pull/498?src=pr) is 80.57%
(diff: 100%)
> Merging [#498](https://codecov.io/gh/apache/cordova-lib/pull/498?src=pr)
into [ma
34 matches
Mail list logo
