[GitHub] cordova-plugin-file pull request #195: CB-11848 windows: Remove duplicate sl...

2016-09-21 Thread matrosovN
GitHub user matrosovN opened a pull request: https://github.com/apache/cordova-plugin-file/pull/195 CB-11848 windows: Remove duplicate slash after file system path ### Platforms affected Windows ### What does this PR do? As we have always trailing slash aft

[GitHub] cordova-plugin-inappbrowser pull request #188: CB-11694 Android: Set hadware...

2016-09-21 Thread matrosovN
GitHub user matrosovN opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/188 CB-11694 Android: Set hadwareBackButton value according option in cor… ### Platforms affected Android ### What does this PR do? HadwareBackButton v

[GitHub] cordova-android pull request #334: CB-11880 android: Fail-safe for cordova.e...

2016-09-21 Thread Fluf22
GitHub user Fluf22 opened a pull request: https://github.com/apache/cordova-android/pull/334 CB-11880 android: Fail-safe for cordova.exec() - added preliminary sanity check on args variable - replication of iosExec() behaviour - allows to call cordova.exec() without args vari

[GitHub] cordova-plugin-geolocation issue #43: Allow Android devices without GPS to s...

2016-09-21 Thread mahmoudkhalafallah
Github user mahmoudkhalafallah commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/43 @stevengill i got this email from google, Hello Google Play Developer, We're writing to let you know that the apps listed at the end of thi

[GitHub] cordova-android issue #334: CB-11880 android: Fail-safe for cordova.exec()

2016-09-21 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/334 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/334?src=pr) is 35.15% (diff: 100%) > Merging [#334](https://codecov.io/gh/apache/cordova-android/pull/334?src=

[GitHub] cordova-plugin-inappbrowser issue #77: Android enhancements

2016-09-21 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/77 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/77/commits/d847b8ea50e707dd69cabf4d581cf0

[GitHub] cordova-windows issue #195: CB-11836 Allow setting of 'ForegroundText' prope...

2016-09-21 Thread tsschaffert
Github user tsschaffert commented on the issue: https://github.com/apache/cordova-windows/pull/195 1) The issue with Windows 10 should be fixed now, I handled it similarly to the 'ToastCapable' property. 2) The color argument is now passed to the manifest file unchecked, so invali

[GitHub] cordova-plugin-inappbrowser issue #77: Android enhancements

2016-09-21 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/77 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/77/commits/36f9a47477ac9589a5ca6a753ffdbd

[GitHub] cordova-windows pull request #195: CB-11836 Allow setting of 'ForegroundText...

2016-09-21 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/195#discussion_r79803408 --- Diff: template/cordova/lib/AppxManifest.js --- @@ -390,11 +390,6 @@ AppxManifest.prototype.getVisualElements = function () { },

[GitHub] cordova-windows pull request #195: CB-11836 Allow setting of 'ForegroundText...

2016-09-21 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/195#discussion_r79804658 --- Diff: spec/unit/AppxManifest.spec.js --- @@ -187,6 +187,27 @@ describe('AppxManifest', function () { it('refineColor should leave CSS

[GitHub] cordova-windows issue #195: CB-11836 Allow setting of 'ForegroundText' prope...

2016-09-21 Thread tsschaffert
Github user tsschaffert commented on the issue: https://github.com/apache/cordova-windows/pull/195 Good points, I updated the changes accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cordova-plugin-inappbrowser issue #77: Android enhancements

2016-09-21 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/77 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/77/commits/2dd982b63d900e64ccbd2b70d583c5

[GitHub] cordova-plugin-file issue #195: CB-11848 windows: Remove duplicate slash aft...

2016-09-21 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/195 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/195/commits/35b7a25f9f1b469daca7386a85f9eb68b82110b9)

[GitHub] cordova-plugin-inappbrowser issue #188: CB-11694 Android: Set hadwareBackBut...

2016-09-21 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/188 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/188/commits/71cf378af0a111e94fa4c94f2de

[GitHub] cordova-plugin-screen-orientation issue #3: Typo on YoikScreenOrientation.m

2016-09-21 Thread hussainak
Github user hussainak commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/3 I cannot seem to raise issues on this github repo. when i do screen.lockRotation("landscape"); it works well on android but iOS half screen goes white. Is

[GitHub] cordova-windows pull request #195: CB-11836 Allow setting of 'ForegroundText...

2016-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-docs pull request #638: CB-11836 Documented Windows ForegroundText p...

2016-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/638 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-media pull request #106: CB-11529 ios: Make available setting...

2016-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

2016-09-21 Thread ephemer
Github user ephemer commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 @manucorporat the term is reference counted and deinited / cleaned up. "Garbage Collection" sounds like heresy to my ears, but the principles are somewhat similar, so you're forg

[GitHub] cordova-plugin-statusbar pull request #65: CB-11191: Statusbar plugin causin...

2016-09-21 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/65 CB-11191: Statusbar plugin causing issues with webview size ### Platforms affected iOS ### What does this PR do? Resizes the webview on CDVViewWillApp

[GitHub] cordova-plugin-statusbar issue #65: CB-11191: Statusbar plugin causing issue...

2016-09-21 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/65 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-statusbar/pull/65/commits/9adc7dbed2aa8c5cdeb81fdea4c3f2f2e86

Re: Google Play change to Android ACCESS_FINE_LOCATION permissions

2016-09-21 Thread Steven Gill
Do it! On Tue, Sep 20, 2016 at 12:20 PM, Joe Bowser wrote: > FYI. I'm going to create an issue to add this to the plugin.xml for > geolocation later. > > -- Forwarded message -- > From: Google Play > Date: Tue, Sep 20, 2016 at 11:40 AM > Subject: Google Play change to Android A

[GitHub] cordova-plugin-geolocation issue #43: Allow Android devices without GPS to s...

2016-09-21 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/43 @mahmoudkhalafallah we are working on adding the permission to the plugin + release it before Oct 15th. --- If your project is set up for it, you can reply to this email and ha

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2016-09-21 Thread hounsellal
Github user hounsellal commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 This is very important. The file sizes are way smaller by this little change - I literally spent 2 days trying to compress the audio files with a lamejs library because they were so

Re: Google Play change to Android ACCESS_FINE_LOCATION permissions

2016-09-21 Thread Joe Bowser
Someone already did it. https://issues.apache.org/jira/browse/CB-11875 But yeah, this is a newbie one, since it's literally one line in plugin.xml. I'll do it tomorrow, but if someone wants an easy PR done, do it up. On Wed, Sep 21, 2016 at 4:55 PM, Steven Gill wrote: > Do it! > > On Tue, Sep

Nightly build #153 for cordova has succeeded!

2016-09-21 Thread Apache Jenkins Server
Nightly build #153 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/153/consoleFull - Jenkins for Apache Cordova -

Re: Google Play change to Android ACCESS_FINE_LOCATION permissions

2016-09-21 Thread Steven Gill
I'll deal with it and start a release for it On Sep 21, 2016 7:37 PM, "Joe Bowser" wrote: > Someone already did it. > > https://issues.apache.org/jira/browse/CB-11875 > > But yeah, this is a newbie one, since it's literally one line in > plugin.xml. I'll do it tomorrow, but if someone wants an