[GitHub] cordova-plugin-dialogs issue #74: [Windows] Separated CSS from JS code. Fixe...

2016-09-09 Thread serbanghita
Github user serbanghita commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/74 @purplecabbage yes I did and also sent it a while ago. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios issue #252: CB-11831 - Add missing LD_RUNPATH_SEARCH_PATHS setti...

2016-09-09 Thread bugnano
Github user bugnano commented on the issue: https://github.com/apache/cordova-ios/pull/252 Yeah, somehow the pull request comment box was empty. However, as this is not my first patch to the Cordova project, I find a little hard to contribute small and easy fixes like this, if

[GitHub] cordova-android pull request #330: Bridge Fixes for Android Jellybean

2016-09-09 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/330 Bridge Fixes for Android Jellybean Updating the Javascript to detect whether we're using Jellybean or not using the userAgent, and pick the right bridge based on the version of Android.

[GitHub] cordova-android issue #330: Bridge Fixes for Android Jellybean

2016-09-09 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/330 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/330?src=pr) is 33.78% (diff: 100%) > Merging [#330](https://codecov.io/gh/apache/cordova-android/pull/330?src=

[GitHub] cordova-android issue #330: Bridge Fixes for Android Jellybean

2016-09-09 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/330 Is there a good way to check if we're using the system webview when making this change? I suspect Crosswalk could use the evaluateJavascript bridge even on Jellybean? --- If your project is

[GitHub] cordova-android pull request #330: Bridge Fixes for Android Jellybean

2016-09-09 Thread infil00p
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cordova-android issue #330: Bridge Fixes for Android Jellybean

2016-09-09 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/330 @dpogue Again, it would be in the userAgent, but I'm fine with leaving ONLINE_BRIDGE as the default for Crosswalk, since we also force Crosswalk to use prompt for the jsToNative bridge even

[GitHub] cordova-android issue #280: CB-10894 Add supports-screens config from the co...

2016-09-09 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/280 I'm going to close this PR with an empty commit. The config-changes code added recently makes this change no longer needed, since you can just do this: ` ` --- If

[GitHub] cordova-android pull request #280: CB-10894 Add supports-screens config from...

2016-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/280 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[DISCUSS] Not requiring an iCLA for contributions

2016-09-09 Thread Shazron
It's up to us to decide, and right now we require the iCLA except for trivial contributions. I want to change this to a more relaxed requirement: 1. Non-committers do not require an iCLA (you need one anyway to get an account, so that's really a non-issue) 2. Require a clear intent by the author t

[GitHub] cordova-plugin-dialogs pull request #86: Add enter key handling and map to d...

2016-09-09 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/86 Add enter key handling and map to default button. ### Platforms affected windows ### What does this PR do? resolves the issue ### What testing has

[VOTE] Plugins Release

2016-09-09 Thread Steven Gill
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11832 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11832/ T

[GitHub] cordova-plugin-dialogs pull request #86: Add enter key handling and map to d...

2016-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/86 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-geolocation issue #78: navigator.geolocation.getCurrentPositi...

2016-09-09 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/78 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-geolocation/pull/78/commits/bb8b4fbc09b5a08bee8314265ce00bbf

[GitHub] cordova-plugin-dialogs issue #86: Add enter key handling and map to default ...

2016-09-09 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/86 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/86/commits/90f9c6df1cae564bbf0f40f1dd3f185d84c71044

[GitHub] cordova-plugin-dialogs issue #86: Add enter key handling and map to default ...

2016-09-09 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/86 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/86/commits/78aa925d2532d894b43c24318128f595470e9933

[GitHub] cordova-plugin-dialogs pull request #82: Make sure the alert buttonLabel is ...

2016-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-dialogs issue #82: Make sure the alert buttonLabel is a strin...

2016-09-09 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/82 Merged! Thanks @Boosten --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cordova-plugin-dialogs pull request #43: Update notification.js

2016-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-dialogs issue #30: Added option to specify the input type of ...

2016-09-09 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/30 Closing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Nightly build #141 for cordova has succeeded!

2016-09-09 Thread Apache Jenkins Server
Nightly build #141 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/141/consoleFull - Jenkins for Apache Cordova -