[GitHub] cordova-plugin-file pull request #190: CB-11693 ios: Make execution callback...

2016-08-16 Thread matrosovN
GitHub user matrosovN opened a pull request: https://github.com/apache/cordova-plugin-file/pull/190 CB-11693 ios: Make execution callback within doCopyMove method in the… ### Platforms affected ios ### What does this PR do? Callback within doCopyMove meth

[GitHub] cordova-plugin-dialogs pull request #82: Make sure the alert buttonLabel is ...

2016-08-16 Thread Boosten
GitHub user Boosten opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/82 Make sure the alert buttonLabel is a string Just a type check to make sure the buttonLabel argument is a string. The fallback to "OK" is already in place. You can merge this pull re

[GitHub] cordova-plugin-media issue #107: CB-11655 (Android) Enabled asynchronous err...

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/107 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/107/commits/6557e2478702fed410f0c28c4814aeb4ae45f534)

[GitHub] cordova-plugin-file issue #190: CB-11693 ios: Make possible to run copy and ...

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/190 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/190/commits/9b9c340b1036e1510cbc4a93f7bdfeaef43d3134)

[GitHub] cordova-plugin-file issue #190: CB-11693 ios: Make possible to run copy and ...

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/190 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/190/commits/66100807aca21b08ffef22ec8d1b85fb5195349a)

[GitHub] cordova-plugin-dialogs issue #81: CB-11677 CB-11214 Android: fix bugs with p...

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/81 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/81/commits/2211ee6684670b19f7b1002305f221cc6fd5e8e6

[GitHub] cordova-plugin-camera issue #219: Dont work camera on Android

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/219 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/219/commits/e588907ac732e58e1a319da3d4e5635ecd8e8414

[GitHub] cordova-plugin-camera issue #230: CB-6708: [iOS]keep the metadata of image, ...

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/230 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/230/commits/16a4315f75161250eb18635ac9c919f0460704b0

[GitHub] cordova-plugin-dialogs issue #81: CB-11677 CB-11214 Android: fix bugs with p...

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/81 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/81/commits/44ee9952a90ea46f7ef449b03aca23fca52721db

[GitHub] cordova-plugin-dialogs issue #82: Make sure the alert buttonLabel is a strin...

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/82 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/82/commits/5ecb3506e0de87d0465713857af132e68c543f00

[GitHub] cordova-plugin-media issue #107: CB-11655 (Android) Enabled asynchronous err...

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/107 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/107/commits/ae8b3567d2400ad6398ff11df2dc600585919e60)

[GitHub] cordova-plugin-media issue #104: Acc+

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/104 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/104/commits/ae8b3567d2400ad6398ff11df2dc600585919e60)

[GitHub] cordova-plugin-file pull request #191: CB-11699 Read files as Data URLs prop...

2016-08-16 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-file/pull/191 CB-11699 Read files as Data URLs properly ### Platforms affected Android, iOS, Windows ### What does this PR do? This PR fixes reading files as data U

[GitHub] cordova-plugin-file issue #191: CB-11699 Read files as Data URLs properly

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/191 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/191/commits/3bc49455963e873af457a440ea240d5422d01865)

[GitHub] cordova-plugin-file-transfer pull request #153: Not able to upload base 64 i...

2016-08-16 Thread ajaysaini95700
GitHub user ajaysaini95700 opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/153 Not able to upload base 64 image url I am able to upload image (jpeg,png) to server if image size is greater than or less than10 MB. only problem is that when i crop im

[GitHub] cordova-plugin-file-transfer issue #153: Not able to upload base 64 image ur...

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/153 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/153/commits/855def11c3c35df6f9de10ccca

[GitHub] cordova-plugin-camera issue #219: Dont work camera on Android

2016-08-16 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/219 This is not the best place to report issues. Try to search for an existing issue in project's JIRA or file a new one as described [here](http://cordova.apache.org/contribute/issues.h

[GitHub] cordova-lib pull request #480: CB-11687 platform-specific plugin prepare hoo...

2016-08-16 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/480#discussion_r74917605 --- Diff: cordova-lib/src/cordova/prepare.js --- @@ -37,23 +37,25 @@ function prepare(options) { return Q().then(function() { var pr

[GitHub] cordova-plugin-camera pull request #219: Dont work camera on Android

2016-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera issue #219: Dont work camera on Android

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/219 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/219/commits/0accbf560baeb2116f434f554a917cb427183b99

[GitHub] cordova-plugin-file-transfer issue #153: Not able to upload base 64 image ur...

2016-08-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/153 @ajaysaini95700, please try to search for an existing issue in project's JIRA or file a new one as described [here](http://cordova.apache.org/contribute/issues.html). A

[GitHub] cordova-plugin-file-transfer pull request #153: Not able to upload base 64 i...

2016-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-wkwebview-engine pull request #14: Feature/readme

2016-08-16 Thread danbucholtz
GitHub user danbucholtz opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/14 Feature/readme README updates You can merge this pull request into a Git repository by running: $ git pull https://github.com/driftyco/cordova-plugin-wkwebview-engin

[GitHub] cordova-plugin-wkwebview-engine pull request #14: Feature/readme

2016-08-16 Thread danbucholtz
Github user danbucholtz closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-camera pull request #231: CB-11709 Tests should use resolveLo...

2016-08-16 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/231 CB-11709 Tests should use resolveLocalFileSystemURL() ### Platforms affected Any ### What does this PR do? Allows tests to use File plugin's resolveLocalFileSystemUR

[GitHub] cordova-plugin-wkwebview-engine pull request #15: Ionic changes to WKWebView...

2016-08-16 Thread danbucholtz
GitHub user danbucholtz opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Ionic changes to WKWebView (For Code Review only) As of August 16th, 2016, this is not ready to be merged. I am just creating this PR to facilitate dialogue and chat abo

[GitHub] cordova-plugin-camera issue #231: CB-11709 Tests should use resolveLocalFile...

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/231 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/231/commits/62d1b01e811753db006a3c75e599a5496b6205fc

[GitHub] cordova-plugin-inappbrowser pull request #178: CB-10467 Hardware back button...

2016-08-16 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/178 CB-10467 Hardware back button, while InAppBrowser is opened, closes t… …he app too in addition to closing InAppBrowser [Jira issue](https://issues.apache.org/ji

[GitHub] cordova-plugin-inappbrowser issue #178: CB-10467 Hardware back button, while...

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/178 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/178/commits/3f180ffa96ac345384e31fd52a4

[GitHub] cordova-plugin-inappbrowser pull request #179: CB-11013 IAB enabling backgro...

2016-08-16 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/179 CB-11013 IAB enabling background play of YouTube videos? ### Platforms affected Android ### What does this PR do? Adds ShouldPauseInAppBrowser preferen

[GitHub] cordova-plugin-inappbrowser issue #179: CB-11013 IAB enabling background pla...

2016-08-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/179 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/179/commits/b50de96d48c0a48d7df65cbef97

[GitHub] cordova-plugin-wkwebview-engine pull request #13: CB-11074 - Ensure settings...

2016-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] cordova-plugin-wkwebview-engine pull request #7: Fixes CB-11074: WKWebView c...

2016-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-wkwebview-engine pull request #8: CB-11074: Ensure settings f...

2016-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2016-08-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Thanks for this! I just merged #13, so can you rebase? I'll review after that is done. Note that the CI auto builds your PR, and it has jshint errors: https://travis-ci.or

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

2016-08-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/237 cordova-common 1.4.1 has been bundled in master, and this PR now fails one unit-test (`npm run unit-tests`: ``` Failures: 1) prepare updateProject method should write out the a

[GitHub] cordova-ios issue #241: CB-11705 - Adding CordovaDefaultWebViewEngine config...

2016-08-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/241 I think you misunderstand that part of the code. You can already swap the default webview engine. It will use the setting "CordovaWebViewEngine" as you can see below the code you are changing.

[GitHub] cordova-ios pull request #242: CB-11703 - travis ci setup is still using 0.1...

2016-08-16 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/242 CB-11703 - travis ci setup is still using 0.10.32 node You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-11703 Altern

[GitHub] cordova-ios issue #242: CB-11703 - travis ci setup is still using 0.10.32 no...

2016-08-16 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/242 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/242?src=pr) is 53.50% (diff: 100%) > Merging [#242](https://codecov.io/gh/apache/cordova-ios/pull/242?src=pr) into [ma

Nightly build #103 for cordova has succeeded!

2016-08-16 Thread Apache Jenkins Server
Nightly build #103 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/103/consoleFull - Jenkins for Apache Cordova -