[GitHub] cordova-android pull request #322: CB-11683 android: Fixed linking to direct...

2016-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/322 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-android issue #317: Tests to verify Android native features.

2016-08-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-android/pull/317 @jedofus, this is not the best place to report issues. Try to search for an existing issue in project's JIRA or file a new one as described [here](http://cordova.apache.org/contribu

[GitHub] cordova-android pull request #317: Tests to verify Android native features.

2016-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/317 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-android pull request #318: Android Keyboard

2016-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/318 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-plugin-statusbar issue #55: Handle extended status bar on iOS

2016-08-11 Thread nnixaa
Github user nnixaa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/55 Hey guys, is there any plans to merge this? Many thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cordova-plugin-dialogs pull request #81: CB-11677 android: fix bug with prom...

2016-08-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/81#discussion_r74416632 --- Diff: src/android/Notification.java --- @@ -286,7 +286,9 @@ public synchronized void prompt(final String message, final String ti

RE: [Android] What is Cordova Plugin Fake, and why is it missing a gradle file?

2016-08-11 Thread Alexander Sorokin (Akvelon)
Hey guys. This test was written by me. It looks like the error is happening here: https://github.com/apache/cordova-android/blob/master/spec/e2e/plugin.spec.js#L38 Surprisingly I cannot reproduce the failure neither on my Windows machine nor on my Mac. Regarding the questions, 1. See the link a

Re: [Android] What is Cordova Plugin Fake, and why is it missing a gradle file?

2016-08-11 Thread Joe Bowser
It was on a branch I was working on, and the bug was that doing an async file check that needed to be synchronous. I fixed that on the pull request I was working on and it all appears to work now. I have to clean up the PR and re-submit the thing, because the PR got all screwed up. On Thu, Aug 1

RE: [Vote] Tools Release

2016-08-11 Thread Alexander Sorokin (Akvelon)
I vote +1. * Verified tags * Ability to install/uninstall Cordova * Ability to update Cordova * Ability to create blank app for Windows, Android * Ability to build/run apps * Reviewed release notes * Verified versions * Verified line breaks * Verified 'cordova serve' * Verified that browserified a

[GitHub] cordova-android pull request #319: Changes for Cordova-Android 6.0.0 - Andro...

2016-08-11 Thread infil00p
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/319 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cordova-android pull request #323: Changes for Cordova-Android 6.0.0 - Andro...

2016-08-11 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/323 Changes for Cordova-Android 6.0.0 - Android Modules as Plugins Redoing this branch as gradle_respect, where we don't nuke the gradle files of AARs, Library Projects and other things that h

[GitHub] cordova-android issue #323: Changes for Cordova-Android 6.0.0 - Android Modu...

2016-08-11 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/323 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/323?src=pr) is 33.78% (diff: 100%) > Merging [#323](https://codecov.io/gh/apache/cordova-android/pull/323?src=

[GitHub] cordova-plugin-camera pull request #229: CB-11661: (ios) Add mandatory iOS 1...

2016-08-11 Thread mhartington
GitHub user mhartington opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/229 CB-11661: (ios) Add mandatory iOS 10 privacy description ### Platforms affected iOS ### What does this PR do? Adds the mandatory NSCameraUsageDescription

[GitHub] cordova-plugin-camera pull request #229: CB-11661: (ios) Add mandatory iOS 1...

2016-08-11 Thread pke
Github user pke commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/229#discussion_r74502437 --- Diff: plugin.xml --- @@ -150,6 +150,11 @@ + + + $CAMERA_USAGE_DES

[GitHub] cordova-plugin-camera issue #229: CB-11661: (ios) Add mandatory iOS 10 priva...

2016-08-11 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/229 Is there a way to localise such texts in `plist`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cordova-ios pull request #240: CB-11528 - Remove verbose mode from xcrun in ...

2016-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/240 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request #259: CB-11607 breakout cordova-create from cordova...

2016-08-11 Thread carynbear
GitHub user carynbear opened a pull request: https://github.com/apache/cordova-cli/pull/259 CB-11607 breakout cordova-create from cordova-lib You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-cli decouple Alterna

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

2016-08-11 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 Recapping our chat: 5 unit test failures: ``` Failures: 1) installPodSync throws cordova error when no pod name provided Message: Error: ENOENT: no such

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

2016-08-11 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 1 unit-test failure: ``` Failures: 1) unit tests for pod module tear down encountered a declaration exception Message: Error: ENOENT: no such file or directory,