[GitHub] cordova-paramedic pull request #11: Appium tests

2016-07-05 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/11#discussion_r69516761 --- Diff: lib/appium/AppiumRunner.js --- @@ -0,0 +1,491 @@ +#!/usr/bin/env node + +/* + * Licensed to the Apache Software Fo

Regarding Pull request for cordova file-transfer-plugin

2016-07-05 Thread Homen Borgohain
Hi, I made a pull request for cordova file-transfer-plugin.Please anyone review it and merge it.Pull request url https://github.com/apache/cordova-plugin-file-transfer/pull/150 Regards, Homen Borgohain, Software developer

Re: Regarding Pull request for cordova file-transfer-plugin

2016-07-05 Thread Jesse
Thanks Homen. We get notifications via github so you don't need to send an email. Thanks for contributing, we'll look at it soon. Cheers, Jesse > On Jul 4, 2016, at 11:07 PM, Homen Borgohain wrote: > > Hi, > I made a pull request for cordova file-transfer-plugin.Please anyone > review it

RE: CB-11491 Introduce before_deploy hook

2016-07-05 Thread Sergey Shakhnazarov (Akvelon)
Sorry, forgot to mention the docs update PR: https://github.com/apache/cordova-docs/pull/616/files -Original Message- From: Sergey Shakhnazarov (Akvelon) [mailto:v-ses...@microsoft.com] Sent: Monday, July 4, 2016 22:03 To: dev@cordova.apache.org Subject: CB-11491 Introduce before_deploy

[GitHub] cordova-plugin-inappbrowser pull request #172: [CB-5758] (android/iOS) Possi...

2016-07-05 Thread MLaudren
GitHub user MLaudren opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/172 [CB-5758] (android/iOS) Possibility to disable ssl verification (allow selfsigned certificate) I think it's linked to this issue: https://issues.apache.org/jira/browse/CB-5

[GitHub] cordova-plugin-network-information pull request #45: Update NetworkManager.j...

2016-07-05 Thread NickyYo
GitHub user NickyYo opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/45 Update NetworkManager.java ### Platforms affected ### What does this PR do? ### What testing has been done on this change?

[GitHub] cordova-plugin-file issue #159: Fix/file locations for Chrome

2016-07-05 Thread mpaland
Github user mpaland commented on the issue: https://github.com/apache/cordova-plugin-file/pull/159 This need to be merged very urgent! In the moment, file plugin is not running, if used in Chrome on a http://localhost site. ```window.resolveLocalFileSystemURL``` is returni

[GitHub] cordova-plugin-file pull request #182: CB-11305 Enable cdvfile: assets fs ro...

2016-07-05 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-file pull request #186: CB-11305 Enable cdvfile: assets fs ro...

2016-07-05 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file/pull/186 CB-11305 Enable cdvfile: assets fs root for DOM requests ### Platforms affected Android ### What does this PR do? * Added test for cdvfile applicationDirectory

[GitHub] cordova-plugin-file issue #182: CB-11305 Enable cdvfile: assets fs root for ...

2016-07-05 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-file/pull/182 Resent this in #186 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-windows pull request #181: CB-11537 Do not duplicate log entries whe...

2016-07-05 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-windows/pull/181 CB-11537 Do not duplicate log entries when printing logs https://issues.apache.org/jira/browse/CB-11537 You can merge this pull request into a Git repository by running: $ git pull h

[GitHub] cordova-windows issue #181: CB-11537 Do not duplicate log entries when print...

2016-07-05 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/181 ## [Current coverage][cc-pull] is **72.17%** > Merging [#181][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@ master #181 di

[GitHub] cordova-windows pull request #182: CB-11538 Update README with information a...

2016-07-05 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-windows/pull/182 CB-11538 Update README with information about logging https://issues.apache.org/jira/browse/CB-11538 You can merge this pull request into a Git repository by running: $ git pull http

[GitHub] cordova-windows issue #182: CB-11538 Update README with information about lo...

2016-07-05 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/182 ## [Current coverage][cc-pull] is **72.17%** > Merging [#182][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@ master #182 di

[GitHub] cordova-paramedic pull request #11: Appium tests

2016-07-05 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/11#discussion_r69585501 --- Diff: lib/appium/AppiumRunner.js --- @@ -0,0 +1,483 @@ +#!/usr/bin/env node + +/* + * Licensed to the Apache Software Foundatio

[GitHub] cordova-windows issue #173: CB-10653 Making the windows activation context c...

2016-07-05 Thread rakatyal
Github user rakatyal commented on the issue: https://github.com/apache/cordova-windows/pull/173 @dasarge: I don't recall the exact OS but I could reproduce @afourney's problem. The details were lost by the time I could access it in plugin's code. I think I could see this happening for

Nightly build #62 for cordova has succeeded!

2016-07-05 Thread Apache Jenkins Server
Nightly build #62 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/62/consoleFull - Jenkins for Apache Cordova ---

[GitHub] cordova-windows issue #173: CB-10653 Making the windows activation context c...

2016-07-05 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/173 @rakatyal, thanks for the details! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-windows issue #173: CB-10653 Making the windows activation context c...

2016-07-05 Thread afourney
Github user afourney commented on the issue: https://github.com/apache/cordova-windows/pull/173 To follow up: I was testing on Windows 10 desktop and Windows 10 mobile. On both platforms the e.detail.result field goes missing when e.detail.kind === activation.ActivationKind.voiceComma

[GitHub] cordova-windows issue #173: CB-10653 Making the windows activation context c...

2016-07-05 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/173 @afourney, see https://issues.apache.org/jira/browse/CB-11522?focusedCommentId=15359160&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15359160 - we'll need to

[GitHub] cordova-windows issue #173: CB-10653 Making the windows activation context c...

2016-07-05 Thread afourney
Github user afourney commented on the issue: https://github.com/apache/cordova-windows/pull/173 Yes. It was all UWP and obviously all with WinJS. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha