[GitHub] cordova-windows pull request #179: CB-11516 windows: Preparing icons w/ targ...

2016-06-30 Thread hoovercj
GitHub user hoovercj opened a pull request: https://github.com/apache/cordova-windows/pull/179 CB-11516 windows: Preparing icons w/ target fails Putting the following line in the config will will cause an error: "Source directory does not exist: Square44x44Logo_100.scale"

[GitHub] cordova-windows issue #179: CB-11516 windows: Preparing icons w/ target fail...

2016-06-30 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/179 ## [Current coverage][cc-pull] is **72.17%** > Merging [#179][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@ master #179 di

[GitHub] cordova-plugin-network-information issue #43: CB-11384 android: Does not pas...

2016-06-30 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/43 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-network-information/pull/43/commits/2fe49199e2503507

[GitHub] cordova-windows issue #173: CB-10653 Making the windows activation context c...

2016-06-30 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/173 @cnsdato, could you please file a corresponding Jira issue at http://issues.cordova.io/? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cordova-docs pull request #616: CB-11491 Introduce before_deploy hook

2016-06-30 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/616 CB-11491 Introduce before_deploy hook [Jira issue](https://issues.apache.org/jira/browse/CB-11491) You can merge this pull request into a Git repository by running: $ git pull https://git

[GitHub] cordova-lib pull request #460: CB-11491 Introduce before_deploy hook

2016-06-30 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/460 CB-11491 Introduce before_deploy hook Updated tests [Jira issue](https://issues.apache.org/jira/browse/CB-11491) You can merge this pull request into a Git repository by running:

[GitHub] cordova-lib issue #460: CB-11491 Introduce before_deploy hook

2016-06-30 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/460 ## [Current coverage][cc-pull] is **80.63%** > Merging [#460][cc-pull] into [master][cc-base-branch] will increase coverage by **0.04%** ```diff @@ master #4

RE: [Vote] 5.2.0 Android Release

2016-06-30 Thread Alexander Sorokin (Akvelon)
I vote +1. * Verified archives via `coho verify-archive` * Verified tags manually * Verified that blank app creates correctly with platform * Verified that blank app can be successfully built and ran * Verified that platform can be updated from previous version * Verified compatibility with core p

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-06-30 Thread alesveselka
Github user alesveselka commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 Good job! So far only solution that fixed the problem for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-inappbrowser pull request #171: CB-11136: Fix OAuth by preven...

2016-06-30 Thread alesveselka
GitHub user alesveselka opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/171 CB-11136: Fix OAuth by preventing InAppBrowser from blocking WKWebVie… You can merge this pull request into a Git repository by running: $ git pull https://github.co

[GitHub] cordova-plugin-inappbrowser issue #171: CB-11136: Fix OAuth by preventing In...

2016-06-30 Thread alesveselka
Github user alesveselka commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/171 Copy of PR to original repo #171 https://github.com/apache/cordova-plugin-inappbrowser/pull/171 Same fix in our fork so we don't have to wait for the merge. ---

[GitHub] cordova-plugin-splashscreen issue #107: Browser platform brought closer to i...

2016-06-30 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/107 @petermetz, thanks for your contribution! The code looks good to me, although there is an issue that the splashscreen does not hide on server cold-start sometimes: ```java

[GitHub] cordova-plugin-inappbrowser pull request #171: CB-11136: Fix OAuth by preven...

2016-06-30 Thread alesveselka
Github user alesveselka closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-inappbrowser issue #171: CB-11136: Fix OAuth by preventing In...

2016-06-30 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/171 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/171/commits/714e24595833590bac85fadd1eb

[GitHub] cordova-plugin-inappbrowser issue #171: CB-11136: Fix OAuth by preventing In...

2016-06-30 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/171 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/171/commits/1216a3ea8c12c8415e7e1b93553

[GitHub] cordova-windows pull request #180: CB-11470 App crashes when trying to open ...

2016-06-30 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/180 CB-11470 App crashes when trying to open from another app using Custo… …m URL (Protocol) [Jira issue](https://issues.apache.org/jira/browse/CB-11470) According to [the

Re: [Vote] 5.2.0 Android Release

2016-06-30 Thread Joe Bowser
I vote +1 * Ran coho audit-license-headers * Ran through testing section at https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#what-to-test On Wed, Jun 29, 2016 at 3:11 PM, Steven Gill wrote: > Please review and vote on this 5.2.0 Android Release > by replying t

[GitHub] cordova-windows issue #180: CB-11470 App crashes when trying to open from an...

2016-06-30 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/180 ## [Current coverage][cc-pull] is **72.17%** > Merging [#180][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@ master #180 di

[GitHub] cordova-coho issue #128: CB-11484 Fix library vulnerability in nlf

2016-06-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-coho/pull/128 Let's get this in, I'd like status.cordova.io to be all green (this is the last red issue) 💯 For those wondering, bithound.io found that those two deps were not used. --- If your

[Android] Creation of 5.0.x branch and addition of Cordova-Android 6.0 featues

2016-06-30 Thread Joe Bowser
In case anyone missed the Snapchat hints today, an Android N release is imminent and I think it's important that we make sure that we release the latest version of Cordova built against that target as soon as possible. Because of other API changes, we should make sure that we support the old 5.0.x

[FYI] Contributors from Adobe will be away next week July 4-8 2016

2016-06-30 Thread Shazron
If anyone was wondering why activity drops next week eh. It's Adobe's July break. Some are taking July 1st (tomorrow) off for Canada Day as well for Canadians' annual "Shed Your Winter Coatapalooza" and maple tree tapping refresher courses.

[GitHub] cordova-plugin-inappbrowser issue #171: CB-11136: Fix OAuth by preventing In...

2016-06-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/171 Not sure what happened here with closing this PR, I assume you are withdrawing the contrib? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-inappbrowser issue #171: CB-11136: Fix OAuth by preventing In...

2016-06-30 Thread alesveselka
Github user alesveselka commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/171 Hi, sorry for confusion. There is already an open PR solving exactly same thing as this PR (https://github.com/apache/cordova-plugin-inappbrowser/pull/162). I und

[GitHub] cordova-windows issue #180: CB-11470 App crashes when trying to open from an...

2016-06-30 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-windows/pull/180 What is the type of Windows.ApplicationModel.Activation.ActivationKind? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-inappbrowser issue #94: CB-3360: Set custom inappbrowser user...

2016-06-30 Thread cjpearson
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/94 @shazron, just did a rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-inappbrowser issue #94: CB-3360: Set custom inappbrowser user...

2016-06-30 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/94 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/94/commits/c84daf918dea72cb91c2afc70a267

[GitHub] cordova-ios pull request #233: CB-9371, CB-9703: Fix how prepare handles ori...

2016-06-30 Thread cjpearson
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-ios/pull/233 CB-9371, CB-9703: Fix how prepare handles orientation on ios Relates to https://github.com/apache/cordova-lib/pull/260 This changes the behavior of the default orientation preference

[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...

2016-06-30 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/260 ## [Current coverage][cc-pull] is **80.58%** > Merging [#260][cc-pull] into [master][cc-base-branch] will decrease coverage by **0.01%** ```diff @@ master #2

[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...

2016-06-30 Thread cjpearson
Github user cjpearson commented on the issue: https://github.com/apache/cordova-lib/pull/260 Thanks, @shazron. I've rebased this pr and opened a new one here https://github.com/apache/cordova-ios/pull/233 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-ios issue #233: CB-9371, CB-9703: Fix how prepare handles orientatio...

2016-06-30 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/233 ## [Current coverage][cc-pull] is **51.81%** > Merging [#233][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@ master #233 diff @

Nightly build #57 for cordova has succeeded!

2016-06-30 Thread Apache Jenkins Server
Nightly build #57 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/57/consoleFull - Jenkins for Apache Cordova ---

[GitHub] cordova-windows issue #173: CB-10653 Making the windows activation context c...

2016-06-30 Thread cnsdato
Github user cnsdato commented on the issue: https://github.com/apache/cordova-windows/pull/173 @daserge, issue was created: https://issues.apache.org/jira/browse/CB-11522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: [Android] Creation of 5.0.x branch and addition of Cordova-Android 6.0 featues

2016-06-30 Thread julio cesar sanchez
+1 to this N was Nougat! 2016-06-30 20:13 GMT+02:00 Joe Bowser : > In case anyone missed the Snapchat hints today, an Android N release is > imminent and I think it's important that we make sure that we release the > latest version of Cordova built against that target as soon as possible. > > B