[GitHub] cordova-plugin-wkwebview-engine issue #11: CB-9888: (iOS) check & reload WKW...

2016-06-14 Thread mccraigmccraig
Github user mccraigmccraig commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11 like this ? do you need a new PR with squashed commits ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-lib pull request #457: Bugfix

2016-06-14 Thread aramando
GitHub user aramando opened a pull request: https://github.com/apache/cordova-lib/pull/457 Bugfix sourceCfg was being assigned the 'path' property, rather than the whole project config object. This was causing an error when attempting to access the path property on line 191. You c

[GitHub] cordova-plugin-file issue #185: BugFix - Import java.nio.charset.Charset in ...

2016-06-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-file/pull/185 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

2016-06-14 Thread David Barth
Pinging this old thread to indicate that : 1. The release has been voted and is now available publicly I would need a green light to either merge and publish that announcement blog post: https://github.com/apache/cordova-docs/pull/607 and the documentation update that accompanies it: https://git

[GitHub] cordova-plugin-file issue #185: BugFix - Import java.nio.charset.Charset in ...

2016-06-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/185 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/185/commits/master) **Dashboard** - [Link](http://c

[GitHub] cordova-windows pull request #157: TypeScript Error

2016-06-14 Thread cadesalaberry
Github user cadesalaberry commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/157#discussion_r66942554 --- Diff: template/package.phone.appxmanifest --- @@ -40,11 +40,9 @@ Description="CordovaApp"

[GitHub] cordova-plugin-statusbar issue #51: New feature 'styleAndroidTranslucent'

2016-06-14 Thread fentas
Github user fentas commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/51 +1 for **blacktranslucent** For me transparent statusbar is only working with this pull. :/ Android 5.0.1. Please merge. --- If your project is set up for it, you can

[GitHub] cordova-plugin-file pull request #185: BugFix - Import java.nio.charset.Char...

2016-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-device-motion pull request #39: CB-10400 Added Appium tests f...

2016-06-14 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] cordova-plugin-media pull request #99: Pass in the settings object we build

2016-06-14 Thread charliewilliams
GitHub user charliewilliams opened a pull request: https://github.com/apache/cordova-plugin-media/pull/99 Pass in the settings object we build ### Platforms affected iOS ### What does this PR do? Uses an audio settings object which previously was built and

[GitHub] cordova-plugin-media issue #99: Pass in the settings object we build

2016-06-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/99 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/99/commits/master) **Dashboard** - [Link](http://c

RE: Apache Cordova Project Global Status Page

2016-06-14 Thread Nikhil Khandelwal
This is awesome, Shaz! Love it! -Nikhil -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Monday, June 13, 2016 1:51 PM To: dev@cordova.apache.org Subject: Re: Apache Cordova Project Global Status Page https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fstatu

[GitHub] cordova-docs pull request #607: Cordova Ubuntu 4.3.4 release announcement

2016-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/607 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request #610: CB 11328 - Ubuntu platform documentation upd...

2016-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/610 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[Plugin: Geolocation] Wrong permission message displayed

2016-06-14 Thread Philipp Kursawe
I tried to post this to the issue tracker, but it would just spin the spinner and never let met create the issue. So I post it here instead: - When having this react component {code} import React from "react" import { connect } from "react-redux" import { update } from

Re: [Plugin: Geolocation] Wrong permission message displayed

2016-06-14 Thread Shazron
Hi, Please never post an issue here. Wait until the issue tracker is back up, Apache is having issues. On Tue, Jun 14, 2016 at 12:49 PM, Philipp Kursawe wrote: > I tried to post this to the issue tracker, but it would just spin the > spinner and never let met create the issue. > > > So I post it

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

2016-06-14 Thread Steven Gill
I merged the PRs in. Building and deploying site now. I'll post here once it is live. -Steve On Tue, Jun 14, 2016 at 2:32 AM, David Barth wrote: > Pinging this old thread to indicate that : > > 1. The release has been voted and is now available publicly > > I would need a green light to either

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

2016-06-14 Thread Shazron
Thanks Steve, David - none of us have privileges to do anything on the Github mirrors. You would act on them by committing to the Apache repos. The pull request emails to dev@ have instructions for each pull request on how to proceed. On Tue, Jun 14, 2016 at 1:24 PM, Steven Gill wrote: > I merg

[GitHub] cordova-lib issue #449: CB-11023 Add edit-config functionality

2016-06-14 Thread riknoll
Github user riknoll commented on the issue: https://github.com/apache/cordova-lib/pull/449 This is working fine for me! When this feature gets documented, we need to make sure to document how to get your project back in order if you mess it up by adding a plugin with `--force`. I thin

[GitHub] cordova-coho pull request #126: CB-11329 added linkify module

2016-06-14 Thread carynbear
GitHub user carynbear opened a pull request: https://github.com/apache/cordova-coho/pull/126 CB-11329 added linkify module You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-coho master Alternatively you can revie

Proof of Concept: Plugins as Android Modules

2016-06-14 Thread Joe Bowser
Hey Here's a proof of concept for Android Modules. It works for cordova core plugins, but it's kinda brittle because I need to figure out how to handle dependencies and excluding duplicate compilation in our tools. https://github.com/infil00p/cordova-android/tree/framework_fixes https://github.c

[GitHub] cordova-coho pull request #126: CB-11329 added linkify module

2016-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: [Plugin: Geolocation] Wrong permission message displayed

2016-06-14 Thread Shazron
I've deleted your 6 duplicates and left: https://issues.apache.org/jira/browse/CB-11433 On Tue, Jun 14, 2016 at 12:49 PM, Philipp Kursawe wrote: > I tried to post this to the issue tracker, but it would just spin the > spinner and never let met create the issue. > > > So I post it here instead:

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

2016-06-14 Thread Steven Gill
http://cordova.apache.org/announcements/2016/06/14/cordova-ubuntu-4.3.4.html On Tue, Jun 14, 2016 at 1:29 PM, Shazron wrote: > Thanks Steve, > David - none of us have privileges to do anything on the Github mirrors. > You would act on them by committing to the Apache repos. The pull request > em

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

2016-06-14 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67070160 --- Diff: cordova-lib/spec-cordova/create.spec.js --- @@ -38,15 +37,17 @@ var configNormal = { version: 'testCordovaCreate'

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

2016-06-14 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67071311 --- Diff: cordova-lib/spec-cordova/create.spec.js --- @@ -121,6 +122,36 @@ describe('create end-to-end', function() { // expect(configXml.

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

2016-06-14 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67073107 --- Diff: cordova-lib/spec-cordova/fixtures/templates/withsubdirectory_package_json/template/blah.txt --- @@ -0,0 +1 @@ +blah --- End diff --

Android 6 permission prompts for Web APIs

2016-06-14 Thread Darryl Pogue
Hey folks (in particular Joe), While cordova-android 5.x gives plugin developers the tools needed for prompting for runtime permissions on Android 6, there's a gap where some natively supported web APIs fail to prompt for permission. Geolocation is one example, but the plugin handles that case fo

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

2016-06-14 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67077184 --- Diff: cordova-lib/src/cordova/create.js --- @@ -252,133 +249,116 @@ function create(dir, optionalId, optionalName, cfg, fetchOpt) {

[GitHub] cordova-lib issue #456: CB-11412 improve template implementation

2016-06-14 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/456 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

2016-06-14 Thread carynbear
Github user carynbear commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67077366 --- Diff: cordova-lib/spec-cordova/create.spec.js --- @@ -121,6 +122,36 @@ describe('create end-to-end', function() { // expect(configXml.n

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

2016-06-14 Thread carynbear
Github user carynbear commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67077463 --- Diff: cordova-lib/spec-cordova/fixtures/templates/withsubdirectory_package_json/template/blah.txt --- @@ -0,0 +1 @@ +blah --- End diff --

[GitHub] cordova-lib issue #456: CB-11412 improve template implementation

2016-06-14 Thread carynbear
Github user carynbear commented on the issue: https://github.com/apache/cordova-lib/pull/456 @stevengill fixed up the little details --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

Re: Android 6 permission prompts for Web APIs

2016-06-14 Thread Joe Bowser
It should be added as a plugin, similar to Geolocation for consistency. I don't want to try adding it to core again because that turned out to be a bad idea since we don't know which webview we're running. On Tue, Jun 14, 2016, 4:34 PM Darryl Pogue wrote: > Hey folks (in particular Joe), > > Wh

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

2016-06-14 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67084182 --- Diff: cordova-lib/src/cordova/create.js --- @@ -252,133 +249,116 @@ function create(dir, optionalId, optionalName, cfg, fetchOpt) {

[GitHub] cordova-ios pull request #229: Incorrect reference to UIWebView

2016-06-14 Thread eladmoshe
GitHub user eladmoshe opened a pull request: https://github.com/apache/cordova-ios/pull/229 Incorrect reference to UIWebView In `CDVUIWebViewNavigationDelegate.m` there is a call to `self.enginePlugin.webView` which returns nil. This bug breaks the Cordova mechanism for posting