[GitHub] cordova-plugin-inappbrowser pull request: CB-10944 : NoSuchMethodE...

2016-03-24 Thread akofman
GitHub user akofman opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/158 CB-10944 : NoSuchMethodError in InAppBrowser plugin Sorry for that guys. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ako

[GitHub] cordova-android pull request: Update SystemWebViewEngine

2016-03-24 Thread alin1771
Github user alin1771 commented on the pull request: https://github.com/apache/cordova-android/pull/266#issuecomment-200705741 No, I didn't create a jira issue. I've just had this issue on my own apps --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-splashscreen pull request: CB-10562 hide() not work...

2016-03-24 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/91#issuecomment-200729015 This can be done as a UI tests suite in the context of Appium integration. --- If your project is set up for it, you can reply to this email and hav

[GitHub] cordova-plugin-dialogs pull request: Added options to customize ke...

2016-03-24 Thread chemerisuk
GitHub user chemerisuk opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/69 Added options to customize keyboard for prompt and theme on Andorid Hi. I found that ability to customize keyboard on the `prompt` dialog is very useful. For example, if you expect

[GitHub] cordova-ios pull request: CB-10942 - Cannot

2016-03-24 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-ios/pull/211#issuecomment-200759257 Tested and working fine I think the first if can be removed ``` if (allowNavigationsPass && allowIntentPass) { return CDVIntentAndNaviga

[GitHub] cordova-plugin-inappbrowser pull request: Add fix for iOS file upl...

2016-03-24 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/139#issuecomment-200816701 Thanks for the pull request. I've had a look at it and think it looks good. Before we can merge it though, you need to sign Apache's Contributo

[GitHub] cordova-plugin-splashscreen pull request: Transition bugfix

2016-03-24 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/92#issuecomment-200817652 Corresponding Jira issue: [CB-10895](https://issues.apache.org/jira/browse/CB-10895) Transparent Splashscreen view sometimes remains --- If you

[GitHub] cordova-plugin-splashscreen pull request: CB-10562 hide() not work...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-windows pull request: CB-10845 Invalidate manifest cache i...

2016-03-24 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/164 CB-10845 Invalidate manifest cache in prepare This fixes [CB-10845](https://issues.apache.org/jira/browse/CB-10845) You can merge this pull request into a Git repository by running

Re: [DISCUSS] cordova-ios release

2016-03-24 Thread Edna Y Morales
bump to this discussion since cordova-common has been released Thanks, Edna Morales From: Shazron To: "dev@cordova.apache.org" Date: 03/18/2016 10:34 PM Subject:Re: [DISCUSS] cordova-ios release Another issue, the bundled ios-sim should be updated: https://issues.apache.or

[GitHub] cordova-android pull request: Update SystemWebViewEngine

2016-03-24 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/266#issuecomment-200885817 Please create a JIRA issue with repro steps so that we can see what's actually being fixed, otherwise we can't accept this pull request. --- If your project i

Re: [ANNOUNCE] Tools Release!

2016-03-24 Thread Carlos Santana
Anyone having problems installing cordova cli 6.1.0 from npm? I tried this morning cordova help works it provided the update message ┌──┐ │ Update available: 6.1.0 (current: 6.0.0) │ │ Run npm install -g cordova to update.│ └

[GitHub] cordova-plugin-inappbrowser pull request: CB-10944 : NoSuchMethodE...

2016-03-24 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/158#issuecomment-200886254 It's fine. I'll do a check on Android 4.4 today to make sure this is resolved. I missed it on this end while doing a quick test here. --- If yo

[GitHub] cordova-plugins pull request: Return after calling complete

2016-03-24 Thread ankon
GitHub user ankon opened a pull request: https://github.com/apache/cordova-plugins/pull/22 Return after calling complete This fixes a SIGABRT in `GCDWebServerConnection`: calling `complete` twice fails, because we already have a `_responseMessage` for the connection after the first

6.1.0 (cordova-lib@undefined) ?

2016-03-24 Thread Carlos Santana
Why do we need to print the version of cordova-lib inside CLI ? $ cordova -v 6.1.0 (cordova-lib@undefined) I opened a JIRA [1] Do we want to remove the extra info of cordova-lib and only print the CLI version? cordova-lib is a npm dependency on cordova-cli like any of the other dependencies [2]

Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

2016-03-24 Thread Joe Bowser
Seriously, it would be super helpful to know which version of Android this failure happened on. I'm having a really difficult time trying to reproduce this bug, and I'm not keen on just throwing things at the CI to see what passes. On Wed, Mar 23, 2016 at 7:56 PM, Joe Bowser wrote: > Well, that

[GitHub] cordova-plugin-media pull request: Request audio focus when playin...

2016-03-24 Thread fafaman
GitHub user fafaman opened a pull request: https://github.com/apache/cordova-plugin-media/pull/88 Request audio focus when playing, pause when focus lost… This solves https://issues.apache.org/jira/browse/CB-10951 Request audio focus when playing. Pause audio when audi

Re: 6.1.0 (cordova-lib@undefined) ?

2016-03-24 Thread Steven Gill
Shoot! So I am checking this out at the airport. So usually cordova-lib version is not supposed to show. It is for development only and I find it very useful. Looks like I made a mistake when publishing cordova-lib :( I was doing some tests to see what modules were being picked up when running n

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

2016-03-24 Thread kukikiloke
Github user kukikiloke commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-200909071 @swbradshaw what devices did you see this issue? I am seeing similar issue only on Samsung devices (S6 5.1.1 and S3 5.1.1) that selecting a ph

[GitHub] cordova-plugin-splashscreen pull request: Transition bugfix

2016-03-24 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/92#issuecomment-200910910 Tested and merged in bea0a4e4083f2c19b71606f76a334439b0b17b40, thanks, @jeroenv! Could you please close the PR? (looks like github did not like a

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

2016-03-24 Thread swbradshaw
Github user swbradshaw commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-200913136 I personally saw the issue on on LG G2(5.0.2) and LG V10 (5.1). I believe it affects all devices running Android 4.4 and newer because the e

RE: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

2016-03-24 Thread Richard Knoll
Both of the Android CI builders run KitKat. We should probably document that somewhere or have medic print it out; I'll look into doing that. Thanks, Richard -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Thursday, March 24, 2016 8:43 AM To: dev Subject: Re: [BUG]

[GitHub] cordova-plugins pull request: Return after calling complete

2016-03-24 Thread ankon
Github user ankon commented on the pull request: https://github.com/apache/cordova-plugins/pull/22#issuecomment-200932334 FWIW: This is the fix for the issue https://issues.apache.org/jira/browse/CB-10953 --- If your project is set up for it, you can reply to this email and have your

Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

2016-03-24 Thread Joe Bowser
Are you sure? I couldn't reproduce this on my KitKat devices, or my Jellybean Devices. I had to dig up a Moto RAZR running 4.0.3 to see this bug happen. On Thu, Mar 24, 2016 at 10:08 AM, Richard Knoll wrote: > Both of the Android CI builders run KitKat. We should probably document > that somewhe

[GitHub] cordova-plugin-inappbrowser pull request: CB-10944 : NoSuchMethodE...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

RE: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

2016-03-24 Thread Richard Knoll
Yep, I'm sure. I double-checked just now to verify and the cordova-android-osx AVD is definitely running KitKat. I was also able to reproduce this on a Jellybean device and a KitKat emulator locally with the mobilespec auto tests. I don't have an actual KitKat device on hand, though. Thanks, Ri

Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

2016-03-24 Thread Joe Bowser
I managed to get a repro on a Jellybean device. BTW: Nexus devices can be downgraded in a pinch, but I usually test my KitKat stuff on a Moto E, because it's cheap. On Thu, Mar 24, 2016 at 11:01 AM, Richard Knoll wrote: > Yep, I'm sure. I double-checked just now to verify and the > cordova-andr

[GitHub] cordova-plugins pull request: CB-10956: Update the GCDWebServer

2016-03-24 Thread ankon
GitHub user ankon opened a pull request: https://github.com/apache/cordova-plugins/pull/23 CB-10956: Update the GCDWebServer These are multiple parts: 1. Fix the README.md 2. Drop the existing GCDWebServer subtree, and readd it at the new path, with the same revision as befo

[GitHub] cordova-plugins pull request: CB-10958: Retain the `src` attribute...

2016-03-24 Thread ankon
GitHub user ankon opened a pull request: https://github.com/apache/cordova-plugins/pull/24 CB-10958: Retain the `src` attribute of the `content` element when it… … already points to localhost Note that this does also add a package.json file for the urijs depende

[GitHub] cordova-plugins pull request: CB-10959: Retain the index page as p...

2016-03-24 Thread ankon
GitHub user ankon opened a pull request: https://github.com/apache/cordova-plugins/pull/25 CB-10959: Retain the index page as path of the generated URL Note that this includes CB-10958 / #24 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-android pull request: CB-10897 Refactor URI Parsing for Wh...

2016-03-24 Thread ktop
Github user ktop commented on the pull request: https://github.com/apache/cordova-android/pull/283#issuecomment-200991279 I've added a test now. Should we open another jira issue to update the Whitelist in the test project? It's still using the tags in config.xml and in

[GitHub] cordova-android pull request: [CB-10689] fix issue with app_name c...

2016-03-24 Thread akofman
Github user akofman commented on the pull request: https://github.com/apache/cordova-android/pull/272#issuecomment-201023548 @infil00p any status about that ? It's a quite annoying issue when you have an app with an apostrophe and having to juggle between ios and android. Thanks !

[GitHub] cordova-docs pull request: Changing docs styling.

2016-03-24 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/567 Changing docs styling. - Styling ToC - Changing color scheme for headings - Changing the font Result: ![capture](https://cloud.githubusercontent.com/assets/405489/1403292

How do we include fonts?

2016-03-24 Thread Dmitry Blotsky
Hey folks, Have any of you added or referenced fonts in Apache projects before? I'm doing a slight docs styling redesign on the site (PR: https://github.com/apache/cordova-docs/pull/567). As part of the redesign it was suggested that we use this font on the site: https://www.google.com/fonts/s

Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

2016-03-24 Thread Jesse
The CI uses emulators, so this in an AVD running KitKat. I know you hate the android emulator Joe, but that is probably the repro step you need. @purplecabbage risingj.com On Thu, Mar 24, 2016 at 8:07 AM, Joe Bowser wrote: > I managed to get a repro on a Jellybean device. > > BTW: Nexus device

Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

2016-03-24 Thread Joe Bowser
Was this really necessary? On Thu, Mar 24, 2016 at 4:03 PM, Jesse wrote: > The CI uses emulators, so this in an AVD running KitKat. > I know you hate the android emulator Joe, but that is probably the repro > step you need. > > > @purplecabbage > risingj.com > > On Thu, Mar 24, 2016 at 8:07 AM,

[GitHub] cordova-plugin-file-transfer pull request: CB-10771: Fixing failur...

2016-03-24 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/133 CB-10771: Fixing failure when empty string passed as a value for opti… …on parameter in upload function CreateUploadAsync fails when passed an empty string as a va

[GitHub] cordova-plugin-file-transfer pull request: CB-10771: Fixing failur...

2016-03-24 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/133#issuecomment-201082490 @riknoll, @jasongin: Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cordova-plugin-file-transfer pull request: CB-10771: Fixing failur...

2016-03-24 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/133#issuecomment-201085977 Is this the only workaround? If so, this quirk should definitely be documented. --- If your project is set up for it, you can reply to this email

Re: GitHub pull request housekeeping

2016-03-24 Thread Jesse
Yeah, I also have done the allow-empty way: git commit --allow-empty -m "Closing stale pull requests: close #99, close #46, close #82" ... @purplecabbage risingj.com On Wed, Mar 23, 2016 at 12:01 PM, Carlos Santana wrote: > I have done cleaning by using coho instructions on other repos in th

[GitHub] cordova-plugin-file-transfer pull request: CB-10771: Fixing failur...

2016-03-24 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/133#issuecomment-201103598 I believe so. As mentioned, passing empty string as a value for SetText function. It also fails when we skip specifying a value for it. One way to

Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

2016-03-24 Thread Jesse
Make that: "I know we all hate the android emulator but " No offense intended. > On Mar 24, 2016, at 5:04 PM, Joe Bowser wrote: > > Was this really necessary? > >> On Thu, Mar 24, 2016 at 4:03 PM, Jesse wrote: >> >> The CI uses emulators, so this in an AVD running KitKat. >> I know you

RE: 6.1.0 (cordova-lib@undefined) ?

2016-03-24 Thread Vladimir Kotikov (Akvelon)
I'll take care of it - Best regards, Vladimir -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, March 24, 2016 7:11 PM To: dev@cordova.apache.org Subject: Re: 6.1.0 (cordova-lib@undefined) ? Shoot! So I am checking this out at the airport. So usually