GitHub user ThillaiganeshChan opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/164
Fix for CB-9753 : index out of bounds on requestFileSystem
This for the CB-9753, "index out of bounds on requestFileSystem".
Changed
if (type > self.fileSystems.c
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/383
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/260#discussion_r53140038
--- Diff: bin/templates/cordova/lib/run.js ---
@@ -41,8 +41,9 @@ var path = require('path'),
var self = this;
-
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/50
CB-10636 Add JSHint for plugins
Added Travis badge
Added node_modules to gitignore
Disabled quotmark as it is
[deprecated](http://jshint.com/docs/options/#quotmark)
Fixed j
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#issuecomment-185169590
There is one issue remaining:
https://github.com/apache/cordova-plugin-device/blob/52f0b41d841238659d7c7f32d60d9231718b27ac/src/ubuntu/device.js#L28
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#issuecomment-185169780
@vladimir-kotikov, could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user BBosman opened a pull request:
https://github.com/apache/cordova-docs/pull/503
Fix splashscreen typo in latest blogpost
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BBosman/cordova-docs patch-1
Alternatively you c
GitHub user imaffett opened a pull request:
https://github.com/apache/cordova-ios/pull/194
CB-10138 Adds missing plugin metadata to plugin_list module
This is the same fix as https://issues.apache.org/jira/browse/CB-10138 ,
but for Cordova iOS
You can merge this pull request into
GitHub user dhams opened a pull request:
https://github.com/apache/cordova-docs/pull/504
Cb 10637
Fixed link location which was previously not correct.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Accenture/cordova-docs CB-10
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-ios/pull/194#issuecomment-185221787
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#discussion_r53170790
--- Diff: .jshintrc ---
@@ -0,0 +1,16 @@
+{
+"node": true
--- End diff --
Should't we use `browser: true` inste
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#discussion_r53171195
--- Diff: .jshintrc ---
@@ -0,0 +1,16 @@
+{
+"node": true
+ , "bitwise": true
+ , "undef": true
+ , "trailing
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-docs/pull/498#issuecomment-185230674
I think this should be added too:
`@Override
public void onDestroy() {
if (this.webInterface!=null) {
this.webInter
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/259#issuecomment-185239609
@nikhilkh, added tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/259
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/389
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#issuecomment-185273857
Addressed, thanks for review, @vladimir-kotikov.
BTW, jshint does not highlight the `src\ubuntu\device.js: line 27, col 24,
'name' is not defined.` iss
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#issuecomment-185276032
I think this is because of
https://developer.mozilla.org/docs/Web/API/Window/name
---
If your project is set up for it, you can reply to this em
It seems Shaz sorted the bug out already [1]. And I agree with and
understand every point you made, Carlos. Thank you.
[1] - https://github.com/apache/cordova-ios/pull/193
2016-02-16 16:22 GMT-02:00 Carlos Santana :
> Cutting releases don't cost $$, just some time
>
> We just try to minimize ef
Shazron has sent a pull request for CB-10530 and an user already confirmed
that it fixed the issue for him, so I think we can wait a bit more.
2016-02-16 19:22 GMT+01:00 Carlos Santana :
> Cutting releases don't cost $$, just some time
>
> We just try to minimize effort and consolidate many bugs
Thoughts on this? Some people on slack are asking if they should be 5.1.1
instead of 5.2.0.
On Tue, Feb 16, 2016 at 4:47 PM, Steven Gill wrote:
> Any issues with me starting this release?
>
> I think I will wait for the cordova-common release to finish so I can
> bundle it in.
>
> Changes:
> * C
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-185330171
I agree we should remove the file all together is not required for
functionality that the plugin offers.
@infil00p Are you OK with the remov
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-docs/pull/502#issuecomment-185333634
+1 Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
It should be 5.2.0. I think we should reserve .1 releases for security
fixes and release screw-ups only.
On Wed, Feb 17, 2016 at 10:07 AM, Steven Gill
wrote:
> Thoughts on this? Some people on slack are asking if they should be 5.1.1
> instead of 5.2.0.
>
> On Tue, Feb 16, 2016 at 4:47 PM, Stev
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/502
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
I vote +1.
* Ran coho verify-archive
* Verified tag
* Built and ran blank app on windows and android platforms using this
cordova-common module
-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
Sent: Tuesday, February 16, 2016 1:18 PM
To: dev@cordova.ap
+1 to wait for cordova-common, then to platforms
On Tue, Feb 16, 2016 at 7:48 PM Steven Gill wrote:
> Any issues with me starting this release?
>
> I think I will wait for the cordova-common release to finish so I can
> bundle it in.
>
> Changes:
> * CB-10510: Add an optional timeout to emu st
Well we should be following semver.
- Bug fixes and other minor changes: Patch release, increment the last
number, e.g. 1.0.1
- New features which don't break existing features: Minor release,
increment the middle number, e.g. 1.1.0
- Changes which break backwards compatibility: Ma
OK, are we sure we didn't add any new minor features?
On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill
wrote:
> Well we should be following semver.
>
>
>- Bug fixes and other minor changes: Patch release, increment the last
>number, e.g. 1.0.1
>- New features which don't break existing
GitHub user RyanWFiorini opened a pull request:
https://github.com/apache/cordova-windows/pull/150
CB-10138 Adds missing plugin metadata to plugin_list module for Windows
This is in conjunction with vladimir-kotikov pull request/commit
ac25c0f03380bb0640831a32ffa47c20df2b0126 to app
Github user omefire closed the pull request at:
https://github.com/apache/cordova-docs/pull/482
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-docs/pull/505
CB-10526: iOS Guide Improvements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-docs CB-10526
Alternatively you can revi
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-docs/pull/506
CB-10333: Improving windows guide
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs raghav-windows
Alternatively y
We built a Cordova app that wraps a remote site. The only HTML page
bundled in our app redirects to our remote site on load. I was new to
Cordova at the time and was looking for the fastest way possible to get the
app out the door. To do so I modified the generated iOS and Android
projects with
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/505#issuecomment-185371859
@shazron could you please take a look ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user daserge commented on the pull request:
https://github.com/apache/cordova-android/pull/260#issuecomment-185384284
I will take a look at this once more tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user daserge commented on the pull request:
https://github.com/apache/cordova-android/pull/260#issuecomment-185383888
@vladimir-kotikov, addressed, thanks.
@nikhilkh, I've tried to test private `getInstallTarget` with `rewire` but
faced an issue caused by the fact that the t
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53225642
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -53,15 +48,13 @@ include all iPad® models, iPhone® 3GS and above, and
iPod® Touch
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53225665
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -53,15 +48,13 @@ include all iPad® models, iPhone® 3GS and above, and
iPod® Touch
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53226134
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -74,190 +67,123 @@ There are two ways to download Xcode:
Once Xcode is installed,
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53229214
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -74,190 +67,123 @@ There are two ways to download Xcode:
Once Xcode is installed, seve
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/505#issuecomment-185405382
@devgeeks , please take a look as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Cool new feature from github!
https://github.com/blog/2111-issue-and-pull-request-templates
Since we don't do issues on github, that feature isn't useful to us. But
providing PR templates sounds like a good idea. Just need to add a
PULL_REQUEST_TEMPLATE.md to the root of our repos.
What type of i
Hey Brad,
This sounds pretty cool. Have you also looked at projects like ManifoldJS -
http://manifoldjs.com/? They also do almost the same thing. They also have a
Cordova plugin that displays an error page when you go offline. Note that
Manifold is not a plugin, but a tool built on top of Cordo
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53238166
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -74,190 +67,123 @@ There are two ways to download Xcode:
Once Xcode is installed,
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r53241742
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -23,24 +23,17 @@ title: Android Plugins
# Android Plugins
This section
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r53242147
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -23,24 +23,17 @@ title: Android Plugins
# Android Plugins
This section
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53246246
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -74,190 +67,123 @@ There are two ways to download Xcode:
Once Xcode is installed, seve
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-windows/pull/151
CB-10640: Windows logging is broken
CB-10640: Windows logging is broken
@dblotsky @riknoll @rakatyal @nikhilkh Can you please review and merge this
PR?
You can merge this pull
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/151#discussion_r53247225
--- Diff: template/cordova/lib/log.js ---
@@ -47,10 +47,10 @@ var appTracingInitialState = null,
* and prints them to console
*/
modu
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/471#issuecomment-185450815
Are we adding link to the 'Upgrading' article?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/471#issuecomment-185451042
@rakatyal I thought we were deleting the upgrading article
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/151#discussion_r53247772
--- Diff: template/cordova/lib/log.js ---
@@ -47,10 +47,10 @@ var appTracingInitialState = null,
* and prints them to console
*/
m
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r53248266
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -23,24 +23,17 @@ title: Android Plugins
# Android Plugins
This section
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/151#issuecomment-185453467
+ @alsorokin to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/151#discussion_r53248411
--- Diff: template/cordova/lib/log.js ---
@@ -47,10 +47,10 @@ var appTracingInitialState = null,
* and prints them to console
*/
mod
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/471#issuecomment-185456589
We are not deleting it but referencing it from the main guide.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-185457013
I'm curious - is this a recent regression?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/471#issuecomment-185457758
Alright, I'll resurrect it and add some stuff about 5.0.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/151#discussion_r53250824
--- Diff: template/cordova/lib/log.js ---
@@ -47,10 +47,10 @@ var appTracingInitialState = null,
* and prints them to console
*/
m
(y)
On Tue, Feb 16, 2016 at 4:44 PM Steven Gill wrote:
> Blog post for review.
>
> https://github.com/apache/cordova-docs/pull/502
>
> Add any comments to the PR
>
> On Thu, Feb 11, 2016 at 4:28 PM, Steven Gill
> wrote:
>
> >
> > Does anyone have any reason to delay a cordova-osx platform relea
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53255568
--- Diff: www/_data/redirects.yml ---
@@ -166,3 +166,5 @@ docs-global:
- {old: "guide_plugin-development_blackberry10_index.md.html", new:
"gu
Github user sarangan12 closed the pull request at:
https://github.com/apache/cordova-windows/pull/151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/151#discussion_r53257649
--- Diff: template/cordova/lib/log.js ---
@@ -151,23 +154,23 @@ function exitGracefully(exitCode) {
}
function startLogging(channel)
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#discussion_r53258984
--- Diff: .travis.yml ---
@@ -0,0 +1,6 @@
+language: node_js
+sudo: false
+node_js:
+ - "0.10"
--- End diff --
The
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#discussion_r53259132
--- Diff: .travis.yml ---
@@ -0,0 +1,6 @@
+language: node_js
+sudo: false
+node_js:
+ - "0.10"
+ - "0.12"
+ - "4.2"
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-medic/pull/80
CB-10510: Reapply Android Emulator retry logic with process fix
This brings back commits 90d06a39cbaf9313edae0fa3cc63a63003b65553
and 7682cd7205f153bc252ab8e1ef445169d34e11c2 which were rev
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/80#issuecomment-185499533
:space_invader: :space_invader: :space_invader: :space_invader:
:space_invader: :space_invader:
:space_invader: :space_invader: :space_invader: :space_invader
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/172
CB-10552 Replacing images in README.md.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-1055
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/172#issuecomment-185515468
@riknoll @nikhilkh @sarangan12 please review when you have a moment.
---
If your project is set up for it, you can reply to this email and have your
rep
btw, here's the PR to update the docs for OSX:
https://github.com/apache/cordova-docs/pull/496
if there are no objections, I'll merge it into master soonish.
regards, toby
On Wed, Feb 17, 2016 at 3:42 PM, Anis KADRI wrote:
> (y)
>
> On Tue, Feb 16, 2016 at 4:44 PM Steven Gill wrote:
>
>> Blog
Github user gaoyuan123 closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
+1
* Review changes (compared w/ previous release content)
-Sergey
-Original Message-
From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com]
Sent: Wednesday, February 17, 2016 2:20 PM
To: dev@cordova.apache.org
Subject: RE: [Vote] Cordova common 1.1.0 Release
I vote +1.
* Ra
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#issuecomment-185571218
@nikhilkh, @dblotsky, addressed, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
+1
Ran coho verify-archive
Ran npm test on cordova-common
On Wed, Feb 17, 2016 at 10:39 PM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:
> +1
>
> * Review changes (compared w/ previous release content)
>
> -Sergey
> -Original Message-
> From: Alexander Sorokin (Akvelon) [mai
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
The vote has now closed. The results are:
Positive Binding Votes: 4
Vladimir Kotikov
Alexander Sorokin
Sergey Grebnov
Steven Gill
The vote has passed.
-
Best regards, Vladimir
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Thursday, February 18, 2016 10:33
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/172#issuecomment-185583719
@dblotsky, should not these changes be made in js source instead?
Then you need to re-generate the docs using [`npm install && npm run
gen-docs`](http
80 matches
Mail list logo
