[GitHub] cordova-blackberry pull request: Icons outside www

2015-09-14 Thread kdubuc
Github user kdubuc commented on the pull request: https://github.com/apache/cordova-blackberry/pull/188#issuecomment-140013143 Here we go https://issues.apache.org/jira/browse/CB-9653 :wink: --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-browser pull request: CB-9654 'cordova run browser' -> dup...

2015-09-14 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-browser/pull/16 CB-9654 'cordova run browser' -> duplicate 'CTRL + C' messages. Utilize *cordova-serve*'s `noServerInfo` flag to prevent it from displaying this info, since *cordova-browser* wants to disp

[GitHub] cordova-plugin-camera pull request: CB-9490 Fixed cleanup function

2015-09-14 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-140016250 @cojomojo the fix makes perfect sense, but I see that the code you use is very similar to what we have in `checkForDuplicateImage` and looks like that f

[GitHub] cordova-plugin-camera pull request: CB-9490 Fixed cleanup function

2015-09-14 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/115#discussion_r39375449 --- Diff: src/android/CameraLauncher.java --- @@ -983,12 +983,39 @@ private Cursor queryImgDB(Uri contentStore) { * @param newImage

[GitHub] cordova-lib pull request: CB-9297 Parse xcode project syncronously...

2015-09-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/305#issuecomment-140033673 Ok, so this PR could be merged then? Regarding fix for node-xcode, could you please take a look at https://github.com/vladimir-kotikov/node-xcode/c

[GitHub] cordova-plugin-dialogs pull request: Fixes Samsung Galaxy S5 cance...

2015-09-14 Thread scheinem
GitHub user scheinem opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/60 Fixes Samsung Galaxy S5 cancelling on touch outside On Samsung Galaxy S5 (tested on Android 5.0) a touch outside the AlertDialog won't make it disappear without this line of code add

[GitHub] cordova-windows pull request: CB-9632 Fixed tests not to fail on T...

2015-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-lib pull request: CB-9617 Do not restore plugins immediate...

2015-09-14 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/304#discussion_r39388053 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -283,6 +283,31 @@ module.exports = function plugin(command, targets, opts) { } };

[GitHub] cordova-lib pull request: CB-9297 Parse xcode project syncronously...

2015-09-14 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/305#issuecomment-140060516 @vladimir-kotikov yes, This PR is good to merge to cordova-lib, that's what I meant with "I agree with the change then..." :-) :+1: --- If your projec

[GitHub] cordova-lib pull request: CB-9297 Parse xcode project syncronously...

2015-09-14 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/305#issuecomment-140060717 We need to merge and release fast cli and lib with this bug, nodejs@4 is out and this is a major bug --- If your project is set up for it, you can reply to thi

[GitHub] cordova-lib pull request: CB-9297 Parse xcode project syncronously...

2015-09-14 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/305#issuecomment-140061087 @vladimir-kotikov yes change to node-code looks good send the PR to see what they want to do, we don't have to wait for a new node-xcode since we switched cordov

[GitHub] cordova-lib pull request: CB-9617 Do not restore plugins immediate...

2015-09-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/304#discussion_r39400734 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -283,6 +283,31 @@ module.exports = function plugin(command, targets, opts) { }

[GitHub] cordova-lib pull request: CB-9617 Do not restore plugins immediate...

2015-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/304 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9297 Parse xcode project syncronously...

2015-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: Update index.html

2015-09-14 Thread oliviertassinari
GitHub user oliviertassinari opened a pull request: https://github.com/apache/cordova-ios/pull/162 Update index.html You can merge this pull request into a Git repository by running: $ git pull https://github.com/oliviertassinari/cordova-ios patch-1 Alternatively you can revi

[GitHub] cordova-ios pull request: Update index.html

2015-09-14 Thread oliviertassinari
Github user oliviertassinari closed the pull request at: https://github.com/apache/cordova-ios/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...

2015-09-14 Thread macdonst
Github user macdonst commented on the pull request: https://github.com/apache/cordova-ios/pull/160#issuecomment-140149314 @shazron okay, I think I've got it. I don't want to merge until I get a second set of eyes though. --- If your project is set up for it, you can reply to this ema

[GitHub] cordova-docs pull request: Implemented 404 page with redirect for ...

2015-09-14 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/342 Implemented 404 page with redirect for old docs links Adds a simple 404 page in desperate need of styling that redirects old documentation links to their new paths (if they exist). You can me

[GitHub] cordova-docs pull request: Added back in the blue stripe identifyi...

2015-09-14 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/343 Added back in the blue stripe identifying official plugins Taken from cordova-registry-web's npm search You can merge this pull request into a Git repository by running: $ git pull https:

[GitHub] cordova-docs pull request: Added back in the blue stripe identifyi...

2015-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Implemented 404 page with redirect for ...

2015-09-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/342#issuecomment-140179724 Merged. Feel free to close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-docs pull request: Implemented 404 page with redirect for ...

2015-09-14 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/342 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Responsive mailing list

2015-09-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/341#issuecomment-140181179 Merged! Feel free to close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-docs pull request: Responsive mailing list

2015-09-14 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/341 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-inappbrowser pull request: Canot open PDF file with...

2015-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/114 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-splashscreen pull request: Add line to increase rea...

2015-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-splashscreen pull request: Add line to increase rea...

2015-09-14 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/58#issuecomment-140203580 Sorry, I couldn't pull from your branch. Your fork is private or something. I have made the change for you. Thanks. --- If your project i

[GitHub] cordova-docs pull request: Cordova website restyle docs

2015-09-14 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/344 Cordova website restyle docs Restyles the /docs/language/version/index.html pages using the styling from the [old website](https://github.com/apache/cordova-docs/blob/master/template/docs/def

[GitHub] cordova-lib pull request: CB-9617 Do not restore plugins immediate...

2015-09-14 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/304#issuecomment-140217724 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-docs pull request: Removed keyword index from docs

2015-09-14 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/345 Removed keyword index from docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/riknoll/cordova-docs cordova-website-remove-keyword-index

[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...

2015-09-14 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/160#issuecomment-140233427 thanks @macdonst I suppose this needs to get the patched 5.0.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cordova-ios pull request: CB-9558 Blob schemes won't load in ifram...

2015-09-14 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-ios/pull/163 CB-9558 Blob schemes won't load in iframes You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-ios CB-9558 Alterna

[GitHub] cordova-docs pull request: Removed keyword index from docs

2015-09-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/345#issuecomment-140249123 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: Cordova website restyle docs

2015-09-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/344#issuecomment-140249152 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature