Github user EddyVerbruggen closed the pull request at:
https://github.com/apache/cordova-wp8/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user EddyVerbruggen commented on the pull request:
https://github.com/apache/cordova-wp8/pull/77#issuecomment-76902445
Ha, cool, makes a lot of sense. Work you magic!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/175
CB-8551 npm registry integration for fetching and removing plugins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cordova-lib CB
Also, Issue: https://issues.apache.org/jira/browse/CB-8551
On Tue, Mar 3, 2015 at 12:54 AM, Steven Gill wrote:
> PR: https://github.com/apache/cordova-lib/pull/175/files
>
> Please review, leave feedback and ask questions!
>
PR: https://github.com/apache/cordova-lib/pull/175/files
Please review, leave feedback and ask questions!
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25671898
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -218,10 +205,18 @@ module.exports = {
/**
* @method initSettings
+ *
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25672017
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings =
r
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25672404
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
return
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25672462
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -47,7 +47,7 @@ function uninstall(platform, project_dir, id,
plugins_dir, options) {
opt
Github user Bubkastor commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/64#issuecomment-76925942
Image not open this uri object.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25690367
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -238,7 +239,21 @@ module.exports = function plugin(command, targets,
opts) {
retu
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25690407
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -147,6 +146,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
checkID(options.e
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25690540
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings =
rc(
1) Is there any reason why --save isn't true by default? It would seem
that in a majority of cases I'd want to save my plugins to the
configuration file. I definitely see times when I would *not* want to
do so, but it seems like that would be the minority of cases.
2) This is probably an edge case
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25690632
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
return r
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25691265
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
return r
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25691366
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
return r
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25691445
--- Diff: cordova-lib/package.json ---
@@ -19,6 +19,7 @@
"dependencies": {
"bplist-parser": "0.0.6",
"cordova-js": "3.8.0",
+
+1 on Raymond's idea, I also why --save isn't default. When talking about
SCMs, the best practice for Cordova applications is to share them with no
platforms nor plugins, so each time a developer checks out the project from
the repo, he/she will need to add the appropriate plugins and desired
platf
Good stuff. Added some style comments, but logic lgtm!
On Tue, Mar 3, 2015 at 3:55 AM, Steven Gill wrote:
> Also, Issue: https://issues.apache.org/jira/browse/CB-8551
>
> On Tue, Mar 3, 2015 at 12:54 AM, Steven Gill
> wrote:
>
> > PR: https://github.com/apache/cordova-lib/pull/175/files
> >
> >
Less a comment on the code and more of a question about the NPM
transition from an end-user pespective:
Is Cordova going to automatically discover and use plugins that are
found in the node_modules folder (from package.json), or will it still
keep its own plugins folder and require they be install
GitHub user VeldMuijz opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/85
Inappbrowser always on top wp8.1
For windows 8.1 the inappbrowser can be displayed with a lower zindex
than the current viewing page. Causing the inappbrowser to be opened o
1) I would say it is not autosave by default so we follow node/npm style.
You have to be explicit when saving dependencies to node projects. Example
"npm install browserify --save".
2) I believe their is a --link command to point to your www for your
Cordova project to use. This isn't a perfect so
1) I can see the logic there, but it seems like folks would want to
save so much, overwhelmingly so, that it makes sense to not follow the
expectation here? Also, would our "typical" user be more familiar with
Node and be confused by this?
2) I know about the link too, my issue is more about what
My thoughts:
- The split between , , and : Like
it a lot.
- I think the defaults *for the plugin* are very reasonable. However, we
may want to provide a default set of tags for the hello world app. A year
or so ago we added a default access * whitelist and I think maybe we should
continue that.
Sorry to be absent for so long, product work here is eating me up.
After a customer question, I noticed the behavior of the system Back button on
the InAppBrowser on Android. In the scenario where the user navigates a couple
of pages forward in the IAB, when they hit the system Back button the a
..taking a look at the cli create.js script, we would need to update it a
bit to actually have it import a hello-world config.xml. The lib actually
ships the template config.xml right now instead of the hello-world project,
which seems unnecessary given our --copy-from/--link-to import logic.
Seem
Darryl,
I believe that cordova-cli will continue to use `cordova plugin add` and
not use `node_modules` at all for phase 1 rollout. It will use the `npm`
library to fetch into the existing plugins/ folder. There will be no user
visible change to project structure, though the plugins are being re
Raymond, you should just include your config.xml in the repo along with
your www. It will be imported as part of --copy-from and should (I haven't
tested!) auto-restore plugins with this new feature.
As for default not --save, this is mostly for npm compatibility, but also
because we decided to a
Darryl,
+1 to what Michal said. We are still figuring out details for phase 2.
Support for package.json and installation from node_modules are two things
I'd love to see supported.
On Mar 3, 2015 8:54 AM, "Michal Mocny" wrote:
> Darryl,
>
> I believe that cordova-cli will continue to use `cordov
GitHub user cmarcelk opened a pull request:
https://github.com/apache/cordova-plugins/pull/19
clarify wording on browser intent
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cmarcelk/cordova-plugins wording
Alternatively you c
Yet more clarification: your git repo should look like:
- www/
- index.html
- ...
- config.xml
- ...
NOT
- config.xml
- index.html
- ...
On Tue, Mar 3, 2015 at 11:59 AM, Michal Mocny wrote:
> Raymond, you should just include your config.xml in the repo along with
> your www. It will be i
Also also ;) cca applications include a default .gitignore with these
contents:
---
##
## This file is the suggested default .gitignore to be used by cca
applications
##
# Usually, you shouldn't version control `platforms/` and `plugins/`. They
are
# build artefacts which change from ma
Thanks Michal. I forgot --copy-from was smart like that. If I remember
right, it can tell if the folder is "just" WWW crap and use it like
WWW crap, otherwise it merges it into a a new project.
Is that a good way of saying it?
On Tue, Mar 3, 2015 at 11:12 AM, Michal Mocny wrote:
> Yet more clari
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25708820
--- Diff: cordova-lib/package.json ---
@@ -19,6 +19,7 @@
"dependencies": {
"bplist-parser": "0.0.6",
"cordova-js": "3.8.0",
+
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25709035
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -238,7 +239,21 @@ module.exports = function plugin(command, targets,
opts) {
retur
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25709236
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -238,7 +239,21 @@ module.exports = function plugin(command, targets,
opts) {
retur
Michal, there is a 'mass save' feature for both platforms and plugins on the
way. They will allow the saving of already installed platforms and plugins
respectively : 'cordova platform save' and 'cordova plugin save'.
The platform's one is currently in code review:
https://github.com/apache/co
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25709472
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -218,10 +205,18 @@ module.exports = {
/**
* @method initSettings
+ * @pa
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25709825
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
return re
Assuming that pull request code works, merge away.
The only concern I had was that the 'hardwareback' option should default to
true.
@purplecabbage
risingj.com
On Tue, Mar 3, 2015 at 8:27 AM, Marcel Kinard wrote:
> Sorry to be absent for so long, product work here is eating me up.
>
> After a c
Makes sense to me!
On Tue, Mar 3, 2015 at 11:27 AM, Marcel Kinard wrote:
> Sorry to be absent for so long, product work here is eating me up.
>
> After a customer question, I noticed the behavior of the system Back
> button on the InAppBrowser on Android. In the scenario where the user
> navigat
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25710017
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
return re
Like your ideas a lot. Updating the project template makes a lot of sense.
Tried to make it clear in the README, so if any part was not clear please
fix it. But, the CSP tag is the more important bit, since can't
actually block all requests. The only reason to even leave in
there is to support p
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-lib/pull/175#issuecomment-76999272
Overall, impressed with the lack of significant impact.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Ah, the bit about being mostly useful for pre-kitkat was context I
was missing. Seems important to note at the start of the section. I'll
update the README.
On Tue, Mar 3, 2015 at 1:02 PM, Andrew Grieve wrote:
> Like your ideas a lot. Updating the project template makes a lot of sense.
>
> Tr
Sweet!
Ray: I think `www and config.xml crap` is a great way to say it ;)
On Tue, Mar 3, 2015 at 12:53 PM, Mefire O. wrote:
> Michal, there is a 'mass save' feature for both platforms and plugins on
> the way. They will allow the saving of already installed platforms and
> plugins respectively
(Added this note:
https://github.com/apache/cordova-plugins/commit/3ed17046ea7efaeccda4c4ffe82bb351e8b966f1,
let me know if its inacurate).
-Michal
On Tue, Mar 3, 2015 at 1:06 PM, Michal Mocny wrote:
> Ah, the bit about being mostly useful for pre-kitkat was context
> I was missing. Seems imp
You can enable auto save by adding auto_save_plugins to be true on the
.cordova/config.json file. I think this helps with the case 1
--
Gorkem
On 3 Mar 2015, at 9:27, Raymond Camden wrote:
1) Is there any reason why --save isn't true by default? It would seem
that in a majority of cases I'd
Good to know this trick. .. Thanks, Gorkem!
2015-03-03 12:14 GMT-06:00 Gorkem Ercan :
>
> You can enable auto save by adding auto_save_plugins to be true on the
> .cordova/config.json file. I think this helps with the case 1
> --
> Gorkem
>
>
>
> On 3 Mar 2015, at 9:27, Raymond Camden wrote:
>
>
Worthy of a blogpost, Ray!
On Tue, Mar 3, 2015 at 1:17 PM, Victor Sosa wrote:
> Good to know this trick. .. Thanks, Gorkem!
>
> 2015-03-03 12:14 GMT-06:00 Gorkem Ercan :
>
> >
> > You can enable auto save by adding auto_save_plugins to be true on the
> > .cordova/config.json file. I think this h
On Tue, Mar 3, 2015 at 8:10 AM, Raymond Camden
wrote:
> 1) I can see the logic there, but it seems like folks would want to
> save so much, overwhelmingly so, that it makes sense to not follow the
> expectation here? Also, would our "typical" user be more familiar with
> Node and be confused by t
+1
On 4 Mar 2015 5:21 am, "Michal Mocny" wrote:
> Worthy of a blogpost, Ray!
>
> On Tue, Mar 3, 2015 at 1:17 PM, Victor Sosa
> wrote:
>
> > Good to know this trick. .. Thanks, Gorkem!
> >
> > 2015-03-03 12:14 GMT-06:00 Gorkem Ercan :
> >
> > >
> > > You can enable auto save by adding auto_save_p
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25715497
--- Diff: cordova-lib/package.json ---
@@ -19,6 +19,7 @@
"dependencies": {
"bplist-parser": "0.0.6",
"cordova-js": "3.8.0",
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-77011164
@agrieve , I addressed your comments. could you please take another look ?
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25715602
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -238,7 +239,21 @@ module.exports = function plugin(command, targets,
opts) {
r
We should save the phase 2 planning for a separate thread / next hangout.
Many strong opinions and bikeshedding to be had, lets finish phase 1 and
sit on the changes for a bit to get comfortable.
-Michal
On Tue, Mar 3, 2015 at 1:55 PM, Steven Gill wrote:
> On Tue, Mar 3, 2015 at 8:10 AM, Raymo
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25716406
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
retur
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25716498
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
retur
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25716916
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
retur
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25717156
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
retur
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25716978
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
retur
I've filed a JIRA issue with my thoughts on how to approach this:
https://issues.apache.org/jira/browse/CB-8597
On Tue, Mar 3, 2015 at 1:02 PM, Andrew Grieve wrote:
> Like your ideas a lot. Updating the project template makes a lot of sense.
>
> Tried to make it clear in the README, so if any pa
This came up in the context of whitelist discussion, but wanted to bring it
to everyones attention.
JIRA: https://issues.apache.org/jira/browse/CB-8597
We would like the default app to support installing the whitelist plugin
automatically using the new plugin auto-restore feature (If you disagree
+1. So on board with this. I'll take a look at your Jira issue later on
today.
On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny wrote:
> This came up in the context of whitelist discussion, but wanted to bring it
> to everyones attention.
>
> JIRA: https://issues.apache.org/jira/browse/CB-8597
>
>
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25718379
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
retur
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25718971
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings =
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25719020
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -218,10 +205,18 @@ module.exports = {
/**
* @method initSettings
+ *
+1
Does this affect the ability to use an individual platform?
ie. cordova-ios/bin/create ...
Will platform create scripts need to change?
@purplecabbage
risingj.com
On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny wrote:
> This came up in the context of whitelist discussion, but wanted to bring
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25719212
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -147,6 +146,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
checkID(option
Jesse, I think not. The platform scripts just copy the bundled www/ (its
already included with the platform).
This is only for the top-level project www/ of a cordova-cli project.
I guess, though, that we could consider changing the platform create
scripts to import config.xml's, since they curr
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25720506
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings =
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25720721
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -218,10 +205,18 @@ module.exports = {
/**
* @method initSettings
+ *
Thanks for all of the feedback so far! I will spend some time this
afternoon making some changes.
On Tue, Mar 3, 2015 at 9:13 AM, Steven Gill wrote:
> Darryl,
>
> +1 to what Michal said. We are still figuring out details for phase 2.
> Support for package.json and installation from node_modules
Pushed first attempt to remote branches:
- https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world
-
https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-hello-world
Cleaning up cordova-lib is strictly required, though I think we should
still take the opportunity to do
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25722381
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
return re
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25725351
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings =
rc(
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-test-framework/pull/10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/72
CB-8599 fix threading issue with cameraPicker
Fixes the issue where cameraPicker is trying to modify the main thread UI
from a background thread.
You can merge this pull request into
What is the expected behaviour here?
`cordova build`
My expectation is that it would build for both device and emulator. In
iOS pre-3.8.0 it does, but now it only builds for emulator only after
the node.js script port, which may or may not be a bug depending on
consensus.
The online docs and cli
Been a while. Thoughts?
What needs to be updated? Should we wait for Android 4.0.0 release?
Hi Steven.
Just want to point out that Russian docs are not completely translated yet
https://crowdin.com/project/cordova
This is mainly because Andrey requested holding back the automated
translation while he is working on the validation framework for the
documentation.
As an FYI, I'll review wh
Sounds good. Keep me in the loop and let me know when you all are ready to
release.
On Tue, Mar 3, 2015 at 1:56 PM, Victor Sosa wrote:
> Hi Steven.
> Just want to point out that Russian docs are not completely translated yet
> https://crowdin.com/project/cordova
>
> This is mainly because Andr
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/63
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Imho, it should do what: "cordova run" would do.
I would think it would run once for each platform, defaulting to device if
attached.
On Tue, Mar 3, 2015 at 4:37 PM, Shazron wrote:
> What is the expected behaviour here?
> `cordova build`
>
> My expectation is that it would build for both device
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/71#issuecomment-77058089
This looks good. Can you fix the white-space additions?
Also, I don't see you listed on
https://people.apache.org/committer-index.html
C
Currently `cordova run` on iOS defaults to emulator as well, like the
compile/build commands.
It's probably safe to say we never specified what happens when no
target is specified (thus right now the behaviour is not consistent
for all platforms) -- and this is a new "feature request".
On Tue, M
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25737174
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings =
r
Fwiw, BlackBerry 10 is building both (tested w/ cordova 4.3.1-dev and
blackberry10 3.7.0):
$ cordova -v
4.3.1-dev (cordova-lib@4.2.1-dev)
$ cordova platform update blackberry10
Updating blackberry10 project...
BlackBerry10 project is now at version 3.7.0
$ cordova build
Running command: "platform
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/commit/4cf298cab1af6b02ddb9ee96df597bfe5ef5b1d3#commitcomment-10018781
In cordova-lib/src/plugman/registry/registry.js:
In cordova-lib/src/plugman/registry/registry.js on line 341:
below you
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25737449
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings =
rc('
Defaulting to device might be problematic on iOS: sure we can detect
if a device is attached (using iso-deploy), but the build might fail
because a signing cert/provisioning profile is not valid (I think the
only way to check is to just build, I might be wrong).
The only "guaranteed" way it will a
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/commit/4cf298cab1af6b02ddb9ee96df597bfe5ef5b1d3#commitcomment-10018789
In cordova-lib/src/plugman/registry/registry.js:
In cordova-lib/src/plugman/registry/registry.js on line 344:
`to for`
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/commit/049548a5994d4efcd85560c81526bcd0cd4c3ed5#commitcomment-10018768
In cordova-lib/src/plugman/registry/registry.js:
In cordova-lib/src/plugman/registry/registry.js on line 163:
you proba
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/commit/7db3df134aba1bb5b5c1ea547ff919d621c30575#commitcomment-10018820
In cordova-lib/src/plugman/registry/registry.js:
In cordova-lib/src/plugman/registry/registry.js on line 381:
it might
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/commit/38a0afbdaef58dd2bc9cff88c76b0e382d835592#commitcomment-10018840
In cordova-lib/src/cordova/plugin.js:
In cordova-lib/src/cordova/plugin.js on line 185:
`changes` -> `changed`
---
If
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/commit/d49159b783909bee31858eb92279253698c9ec9d#commitcomment-10018875
In cordova-lib/src/cordova/plugin.js:
In cordova-lib/src/cordova/plugin.js on line 321:
if we're changing lines, it'd b
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25738050
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings =
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25738089
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings =
1 - 100 of 128 matches
Mail list logo
