Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-wp8/pull/76#issuecomment-75211406
LGTM, propose to move config parsing logic to separate file/class similar
to how this is done on windows
https://github.com/apache/cordova-windows/blob/master/te
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/59#discussion_r25058822
--- Diff: template/cordova/lib/prepare.js ---
@@ -40,14 +40,37 @@ module.exports.applyPlatformConfig = function () {
return false;
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-medic/pull/33#issuecomment-75212956
merged, @alsorokin please close PR (I've misspelled github directive in
commit message to close it automatically)
---
If your project is set up for it, you can re
Github user alsorokin closed the pull request at:
https://github.com/apache/cordova-medic/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user Mitko-Kerezov commented on the pull request:
https://github.com/apache/cordova-ios/pull/128#issuecomment-75227834
Issue was fixed with
https://github.com/apache/cordova-ios/commit/8dcc9dd626c523e6e217dd7e8ce43d0af849fa3a
So I'm closing this now
---
If your project is
Github user Mitko-Kerezov closed the pull request at:
https://github.com/apache/cordova-ios/pull/128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75235633
if no locale is not found it uses the current default language which is
en-us. Since that is already hardcoded in proj files I'm not re-setting it.
removing might
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75238727
I meant if you changed locale in config.xml and then removed this settings
it will continue pointing to the wrong previously used locale, not the default
one.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75238948
May be just use something like this
var defaultLocale = config.defaultLocale() || 'en-us';
---
If your project is set up for it, you can reply to this email
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75239086
But this is minor, so I'm +1 merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Hey Jason - Glad to see this proposal! A number of us at Microsoft have been
talking along these same lines actually. Windows 10 apps will include CSP
support as the latest version of IE has support so I'd say we're completely in
support of moving Cordova apps down this path. In fact I'd want
GitHub user thehuijb opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/65
Fix issue where android cordova app crashes on selecting images from dropbox
Cordova android apps would crash if you picked an image from a remote
system e.g. Drive, OneDrive, Mega, D
Github user dariosalviwork commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/84#issuecomment-75285312
Did not work on my tests unfortunately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/170
CB-8499 `cordova platform save` should save all currently installed
platforms and their versions/git-url/folder-location into config.xml.
CB-8499 `cordova platform save` should save all current
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-android/pull/159
CB 8520 - Simple fix for extra args being added twice for build command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/co
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75298546
I'll fix the default locale to en-US. When a defaultlocale is not present
we should set it to en-US. Good catch!
---
If your project is set up for it, you can re
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-75298325
@agrieve , @vladimir-kotikov and @gorkem, please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25095035
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -158,6 +160,11 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25095044
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -174,6 +181,24 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25095040
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -174,6 +181,24 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25095419
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) u
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25096417
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) u
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25096560
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) u
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-firefoxos/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-wp8/pull/76#issuecomment-75305949
We actually don't want to merge this right now. Let's hold on until I
review how winpho8 locale works.
---
If your project is set up for it, you can reply to this em
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75305927
This looks good! @sgrebnov Can you please help merge this one? It will be
good to have this in the next cordova-windows release.
---
If your project is set up f
Hello Apache Cordova devs! I've submitted a patch (
https://github.com/apache/cordova-firefoxos/pull/22 ) to fix
https://issues.apache.org/jira/browse/CB-7567 . I've emailed my ICLA in,
so I'm wondering what the next step is? Could I get a review from
someone?
Thanks, Jon
Hello Guys,
I'm working on a Cordova project and we are implementing a Log Mechanism that
writes all messages sent to our javascript API on a file persisted on the
device file system.
It works on Android and iOS, but we did not find out a solution to retrieve the
generated log file from iOS fil
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-wp8/pull/76#discussion_r25098154
--- Diff: template/cordova/lib/build.js ---
@@ -68,6 +70,40 @@ module.exports.run = function (argv) {
}
return parseAndValidateArg
Fabio,
This mailing list is about Cordova Development; it isn’t intended for user
support. Please ask on the Google Group or Stack Overflow.
~Kerri
From: Wellington Queiroz, Fabio
Reply: dev@cordova.apache.org >
Date: February 20, 2015 at 1:47:57 PM
To: dev@cordova.apache.org >
Cc: Gayard,
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25098780
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25098622
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25098877
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) u
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25100140
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -174,6 +181,24 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
});
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25100062
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -174,6 +181,24 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
});
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-75314035
@vladimir-kotikov Thanks for reviewing, All your reviews have been
addressed, please take another look.
---
If your project is set up for it, you can reply to this
GitHub user PiotrPiesiak opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/66
fix crash when trying to pick picture on iPad
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PiotrPiesiak/cordova-plugin-cam
Chuck,
Thanks for the feedback, it's good to know others are interested in CSP.
I've created a doc to capture the proposal in a little more detail, and
allow for more robust comments:
https://docs.google.com/document/d/1sfFs6LB1_giodyR4QwBMQssLKP_UxACZifk-VYVX2T8/edit?usp=sharing
In that doc, I'
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-75336770
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/128#issuecomment-75339637
Note that the fix enables it to be disabled using a build.xcconfig
preprocessor macro definition (which can be done through a project/plugin
hook). In 3.8.0 it still
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/168#issuecomment-75346177
There will need to be another pass to update dependent modules to handle
the possibility that some new code depending on old syntax might have been
inserted in the i
Hi Steven,
I would be happy to submit a pull request. Can you point me in the
direction of the tests that should be updated? I'm not seeing
anything obvious related to browserify in the test directory.
Christian
On Thu, Feb 19, 2015 at 04:02:19PM -0700, Steven Gill wrote:
> Good catch. Thanks f
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-75350562
Is platforms.json an existing file? Is it used anywhere else? I suspect
that it is a new file and I am not sure if it is really needed
---
If your project is set up
43 matches
Mail list logo
