[GitHub] cordova-firefoxos pull request: [CB-4556] Add a ./cordova/clean pr...

2014-07-29 Thread marti1125
Github user marti1125 commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/18#issuecomment-50462836 ok @zalun --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cordova-plugin-geolocation pull request: [CB-6422] Use cordova/exe...

2014-07-29 Thread marti1125
GitHub user marti1125 opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/20 [CB-6422] Use cordova/exec/proxy instead of platform dupes https://issues.apache.org/jira/browse/CB-6422 [CB-6422] Use cordova/exec/proxy instead of platform dupes You can m

[GitHub] cordova-plugin-inappbrowser pull request: [CB-6422] Use cordova/ex...

2014-07-29 Thread marti1125
GitHub user marti1125 opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/54 [CB-6422] Use cordova/exec/proxy instead of platform dupes https://issues.apache.org/jira/browse/CB-6422 [CB-6422] Use cordova/exec/proxy instead of platform dupes You can

[GitHub] cordova-plugin-network-information pull request: [CB-6422] Use cor...

2014-07-29 Thread marti1125
GitHub user marti1125 opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/15 [CB-6422] Use cordova/exec/proxy instead of platform dupes https://issues.apache.org/jira/browse/CB-6422 [CB-6422] Use cordova/exec/proxy instead of platform dupes

[GitHub] cordova-plugin-vibration pull request: [CB-6422] Use cordova/exec/...

2014-07-29 Thread marti1125
GitHub user marti1125 opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/18 [CB-6422] Use cordova/exec/proxy instead of platform dupes https://issues.apache.org/jira/browse/CB-6422 [CB-6422] Use cordova/exec/proxy instead of platform dupes You can mer

[GitHub] cordova-blackberry pull request: CB-7186 --no-signing will be igno...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cordova-firefoxos pull request: [CB-4556] Add a ./cordova/clean pr...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-firefoxos/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cordova-plugin-file pull request: Remove unsupported paths from re...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cordova-plugin-splashscreen pull request: CB-7196 port splashscree...

2014-07-29 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/22 CB-7196 port splashscreen tests to framework You can merge this pull request into a Git repository by running: $ git pull https://github.com/stacic/cordova-plugin-splashscre

[GitHub] cordova-plugin-statusbar pull request: CB-7195 ported statusbar te...

2014-07-29 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/12 CB-7195 ported statusbar tests to framework You can merge this pull request into a Git repository by running: $ git pull https://github.com/stacic/cordova-plugin-statusbar CB-7

[GitHub] cordova-plugin-network-information pull request: [CB-7166] Fix nav...

2014-07-29 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/13#issuecomment-50518791 Personally, I don't want commit messages to have spelling errors in them. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib pull request: CB-7190: Add browserify support in cordo...

2014-07-29 Thread surajpindoria
GitHub user surajpindoria opened a pull request: https://github.com/apache/cordova-lib/pull/66 CB-7190: Add browserify support in cordova-lib/cordova-cli https://issues.apache.org/jira/browse/CB-7190 You can merge this pull request into a Git repository by running: $ git pull h

[GitHub] cordova-cli pull request: Added browserify flag to cli options

2014-07-29 Thread surajpindoria
GitHub user surajpindoria opened a pull request: https://github.com/apache/cordova-cli/pull/185 Added browserify flag to cli options You can merge this pull request into a Git repository by running: $ git pull https://github.com/surajpindoria/cordova-cli CB-7001 Alternatively

Browserify support for cordova-lib/cordova-cli

2014-07-29 Thread Suraj Pindoria
Hi everyone, I have been working with Anis and Steve to add browserify support in cordova-lib and cordova-cli.  They way this is being done is through a flag in the CLI which then calls prepare-browserify versus the standard prepare, an example: "cordova plugin --browserify add org.apache.cordo

[GitHub] cordova-lib pull request: CB-7190: Add browserify support in cordo...

2014-07-29 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/66#discussion_r15544876 --- Diff: cordova-lib/src/plugman/plugman.js --- @@ -70,6 +70,7 @@ addProperty(plugman, 'install', './install', true); addProperty(plugman, 'uni

[GitHub] cordova-cli pull request: CB-7220 Split cordova help into per feat...

2014-07-29 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/186 CB-7220 Split cordova help into per feature help files This splits the documentation for the various commands into individual files. It also exposes the bash help (although it doesn't m

[GitHub] cordova-lib pull request: CB-7190: Add browserify support in cordo...

2014-07-29 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/66#discussion_r15545141 --- Diff: cordova-lib/src/plugman/uninstall.js --- @@ -316,6 +316,10 @@ function handleUninstall(actions, platform, plugin_id, plugin_et, project_di

[GitHub] cordova-lib pull request: CB-7190: Add browserify support in cordo...

2014-07-29 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/66#discussion_r15545303 --- Diff: cordova-lib/src/plugman/install.js --- @@ -571,7 +571,11 @@ function handleInstall(actions, pluginInfo, platform, project_dir, plugins_dir

missing documentation and missing major version bump

2014-07-29 Thread Josh Soref
Hi. https://issues.apache.org/jira/browse/CB-6024 Broke a number of people. While there was a pull request and a bug, there wasn't a major version bump. People using npm w/ grunt-cordovacli in a continuous integration setting w/ reasonable package.json settings went from having a working build

[GitHub] cordova-cli pull request: CB-7220 Split cordova help into per feat...

2014-07-29 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-cli/pull/186#issuecomment-50524957 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Browserify support for cordova-lib/cordova-cli

2014-07-29 Thread Steven Gill
cordova prepare --browserify works too https://issues.apache.org/jira/browse/CB-7001 https://issues.apache.org/jira/browse/CB-7190 On Tue, Jul 29, 2014 at 12:02 PM, Suraj Pindoria < suraj.pindo...@yahoo.com.invalid> wrote: > Hi everyone, > > I have been working with Anis and Steve to add browse

[DISCUSS] Plugins Release

2014-07-29 Thread Steven Gill
How do you all feel about a plugins release? I can aim to start a vote thread tomorrow or Thursday if people feel good about it. -Steve

[GitHub] cordova-plugin-geolocation pull request: [CB-6422] Use cordova/exe...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-inappbrowser pull request: [CB-6422] Use cordova/ex...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-network-information pull request: [CB-6422] Use cor...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-vibration pull request: [CB-6422] Use cordova/exec/...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-cli pull request: CB-7220 Split cordova help into per feat...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/186 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-camera pull request: [CB-6422] Use cordova/exec/pro...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-device-motion pull request: [CB-6422] Use cordova/e...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-contacts pull request: [CB-6422] Use cordova/exec/p...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device-orientation pull request: [CB-6422] Use cord...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-device pull request: [CB-6422] Use cordova/exec/pro...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

Re: What's Stopping us From Independent Platform Releases

2014-07-29 Thread Steven Gill
Started creating issues to keep track of all of these things. Master issue can be seen at https://issues.apache.org/jira/browse/CB-7221 Setting CLI to version 4.0.0 sounds good to me. We can mention in the release blog post how platforms are on their own schedule now. Option 3 for docs - Docs ge

[GitHub] cordova-plugin-dialogs pull request: [CB-6422] Use cordova/exec/pr...

2014-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-7190: Add browserify support in cordo...

2014-07-29 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/66#discussion_r15553301 --- Diff: cordova-lib/src/plugman/uninstall.js --- @@ -316,6 +316,10 @@ function handleUninstall(actions, platform, plugin_id, plugin_et, project_dir,

Re: missing documentation and missing major version bump

2014-07-29 Thread Michal Mocny
Current cli is cadver-semver and if even if we had bumped the semver MAJOR it would not have mattered. If you were using semantic version matching in your package.json for cli dependancy, the current scheme does not match the way you expect. Josh your suggestion is that we should have used our ca

Re: Browserify support for cordova-lib/cordova-cli

2014-07-29 Thread Michal Mocny
Just to confirm: Can I run "cordova prepare --browserify" is any existing workspace, or would I have needed to add all plugins / platforms with that flag as well? -Michal On Tue, Jul 29, 2014 at 3:27 PM, Steven Gill wrote: > cordova prepare --browserify works too > > https://issues.apache.org/

[GitHub] cordova-lib pull request: CB-7190: Add browserify support in cordo...

2014-07-29 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/66#discussion_r15553576 --- Diff: cordova-lib/src/plugman/uninstall.js --- @@ -316,6 +316,10 @@ function handleUninstall(actions, platform, plugin_id, plugin_et, project_di

[GitHub] cordova-lib pull request: CB-7190: Add browserify support in cordo...

2014-07-29 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/66#discussion_r15553653 --- Diff: cordova-lib/src/plugman/plugman.js --- @@ -70,6 +70,7 @@ addProperty(plugman, 'install', './install', true); addProperty(plugman, 'uninst

[GitHub] cordova-lib pull request: CB-7190: Add browserify support in cordo...

2014-07-29 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/66#discussion_r15553915 --- Diff: cordova-lib/src/plugman/uninstall.js --- @@ -316,6 +316,10 @@ function handleUninstall(actions, platform, plugin_id, plugin_et, project_dir,

Re: Browserify support for cordova-lib/cordova-cli

2014-07-29 Thread Suraj Pindoria
Right now it only works when you add the plugins with the flag.  Current working use case: -Create a project -Add platform -Add plugins with browserify flag Adding a platform after does not use the proper browserify-prepare.  Obviously an issue. We just realized an issue we need to solve first.

Re: Clarification for Camera manual tests

2014-07-29 Thread Shazron
Definitely no developer tests all possible combinations, that’s not feasible :/ More likely these manual tests (at least how I’ve used them) is to verify a Camera bug, then verify the fix to the bug worked. It’s not ideal of course since the fix could break some other functionality, but I don’t h

Re: Browserify support for cordova-lib/cordova-cli

2014-07-29 Thread Steven Gill
Decided to add a few more issues and organize around a master issue. https://issues.apache.org/jira/browse/CB-7190 If you guys think of other use cases, let us know! On Tue, Jul 29, 2014 at 2:47 PM, Suraj Pindoria < suraj.pindo...@yahoo.com.invalid> wrote: > Right now it only works when you ad

Re: Question About Official Plugins

2014-07-29 Thread Peter Metz
Carlos, Jesse and Joe, Thank you guys, loads of helpful info! I will go with the renaming as suggested and it seems like even from the user side it won't be as painful as I anticipated, so thanks for the additional info. Losing control over the releases and contributions is indeed a bit of a pai

Re: missing documentation and missing major version bump

2014-07-29 Thread Josh Soref
Michal wrote: > Current cli is cadver-semver and if even if we had bumped the semver MAJOR it > would not have mattered. > If you were using semantic version matching in your package.json for cli dependancy, > the current scheme does not match the way you expect. > Josh your suggestion is that we

Re: missing documentation and missing major version bump

2014-07-29 Thread Carlos Santana
if you know of assumptions on cordova cli like passing extra arguments down to the platform scripts (i.e. emulate), this is something that can be added to the unit tests for cordova-lib, this way it's part of the CI tests with "npm test" you can mockup the expected call down to the platforms script

Re: Browserify support for cordova-lib/cordova-cli

2014-07-29 Thread Michal Mocny
Sounds like a setting that would go well in .cordova/config.json, I think. -Michal On Tue, Jul 29, 2014 at 6:10 PM, Steven Gill wrote: > Decided to add a few more issues and organize around a master issue. > > https://issues.apache.org/jira/browse/CB-7190 > > If you guys think of other use cas

Re: missing documentation and missing major version bump

2014-07-29 Thread Michal Mocny
Throwing out another option: can we just patch cli now to pass arguments on like it used to, even with the new nopt? Failing that, I don't mind reverting the config changes and releasing tools again, assuming we're going to get 4.0 out soon anyway. Josh: RE CI -- I look forward to your patch for

Re: missing documentation and missing major version bump

2014-07-29 Thread Carlos Santana
Yep Michal I agree to update cli to pass down extra parameters to platform scripts like it used. this allow for greater flexibility in platform scripts and no hardcoded platform concerns in cli. No need to remove nopt if the this can be achieved. On Tue, Jul 29, 2014 at 10:45 PM, Michal Mocny w