Hi,
I propose to add integration w/ travis-ci to automatically run CLI and LIB
tests for new commits and pull requests. In this case we will be more confident
that the code is healthy and well formatted. Adding more spec tests will make
this even more helpful.
We can do the same for the platfor
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-lib/pull/43
Reverts CB-6976 Add support for Windows Universal apps
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib master
Alter
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-cli/pull/183
Reverts CB-6976 Add support for Windows Universal apps
Requires to not break upcoming CLI and LIB release. This will be added back
and released along with of 3.6.0.
You can merge this pull re
I've sent the following pull requests to make CLI and LIB release working on
windows. Please let me know whether they look good and I'll apply them (tested
manually and via Medic).
https://github.com/apache/cordova-lib/pull/43
https://github.com/apache/cordova-cli/pull/183
Sorry for having to
Hi All,
Is there a plan to provide the older Cordova versions of the platforms on
npm. At the moment only version 3.5.0 is available, I think one of the
value adds with usenpm is the ability to use older versions.
--
Gorkem
I don't think it's been discussed at all on this list, so no, I don't think
there's a plan.
If someone wanted to take the time to package them up, then I don't think
they would be blocked at all. It was all "released" previously, so it's a
matter of repackaging now.
One topic of discussion for th
I imagine versions greater than 3.0.0 would be the target. I have doubts
that CLI can support earlier versions (may even choke on some of the >3.0.0
versions).
I am OK with uploading only the latest patched versions so that we would
have to do less.
--
Gorkem
On Fri, Jun 27, 2014 at 9:06 AM, Ian
Is it really worth it?
git clone --branch=
cordova platform add /dir/where/it/cloned
is not much longer and gives you full control at what version exactly you
are getting. In addition it provides an indication that this is not the
most recommended way and one should know what he is doing when expl
Anyone else?
(I'd love for someone outside of Google to take a quick look, but if I have
to, I'll grab David or Max here ;) )
Ian
On Thu, Jun 26, 2014 at 11:17 AM, Andrew Grieve
wrote:
> +1
>
> * verified signature & hash
> * verified archive contents matches git hash
>
>
> On Tue, Jun 24, 20
Would be nice to have this. Specifically Travis will only run on Linux (and
maybe OSX). Here is a random similar service I found that can also run on
windows.
http://www.appveyor.com/
It looks good; I can't see any regressions with ios or android, and I trust
that you've tested it on Windows platforms.
I'll apply it to master as well as a branch off of the 3.5.0-0.2.6 and
0.21.6 tag points, and maybe we can vote on an RC2
On Fri, Jun 27, 2014 at 7:31 AM, Sergey Grebnov (Akvel
(On second thought, I won't apply it to master -- then there's no need to
revert it later :) )
On Fri, Jun 27, 2014 at 10:05 AM, Ian Clelland
wrote:
> It looks good; I can't see any regressions with ios or android, and I
> trust that you've tested it on Windows platforms.
>
> I'll apply it to m
On Fri, Jun 27, 2014 at 09:53:20AM -0400, Mark Koudritsky wrote:
> Is it really worth it?
Cordova packages are consumed in different ways. This will create the
inconvinience of changing retrieval logic with versions for things like
CI tools, and IDEs. It is just a matter of being kind to those fol
Thanks for the patches. I'll try to prep the packages from a branch today.
If that doesn't go smooth, I'll get to it on Wednesday when we are back
from the long weekend.
Github user kamrik closed the pull request at:
https://github.com/apache/cordova-coho/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-coho/pull/31#issuecomment-47352977
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Make it happen :)
On Fri, Jun 27, 2014 at 10:02 AM, Mark Koudritsky wrote:
> Would be nice to have this. Specifically Travis will only run on Linux (and
> maybe OSX). Here is a random similar service I found that can also run on
> windows.
> http://www.appveyor.com/
>
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Hi Sergey, et al.
Thanks for the patches. I haven't had a chance to test them myself, but I
trust your testing regimen.
The adobe phonegap team has been away most of the week, so we've been
noticeably absent, and will be next week as well with holiday breaks.
I'll try to test over the wee
Please review and vote on this Tools Release.
This is from branches with windows revert patches applied.
Branches are cli: rb_3.5.0-0.2.6, lib: rb_0.21.6 (rb for release branch)
Release issue: https://issues.apache.org/jira/browse/CB-7002
Both tools have been published to dist/dev:
https://dis
Ok, just published the new vote.
Just committed a patch to update the URLs in the docs.
http://cordova.apache.org/docs/en/edge/cordova_plugins_pluginapis.md.html#Plugin%20APIs
On Tue, Jun 24, 2014 at 10:14 PM, Ian Clelland
wrote:
> On Tue, Jun 24, 2014 at 4:45 PM, Carlos Santana
> wrote:
>
> > I don't have a problem having
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-battery-status/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r14300639
--- Diff: plugin.xml ---
@@ -33,6 +33,9 @@
+
+
--- End diff --
As discussed on ML, t
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/14#discussion_r14304481
--- Diff: src/ios/CDVCamera.m ---
@@ -736,21 +736,4 @@ @implementation CDVCameraPicker
@synthesize webView;
@synthesize popoverSupporte
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/23#issuecomment-47379219
Camera has a lot of technical debt and a lot of bugs in it. I think you'd
actually be better off forking the plugin rather than extending it. Even better
w
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/30#issuecomment-47379940
Patch looks good, but wondering if this fixes a bug?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-47380724
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/10#issuecomment-47380981
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/21#issuecomment-47381981
Closing for now, please file new pull request with not adding a js-module
to the main plugin.xml
---
If your project is set up for it, you can reply to t
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/14#issuecomment-47382247
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/15#issuecomment-47383450
Closing pull request since this file has been deleted. Plugin now just
defers to browser's geolocation implementation.
---
If your project is set up
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/12#issuecomment-47383772
Code looks awesome, but adding test code to the plugin is a show-stopper.
Going to close PR for now, but please re-open with one of the work-arounds
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/34#issuecomment-47384221
bump - what's the state of this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/42#issuecomment-47384434
@shazron - should this be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/45
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/49#issuecomment-47384868
Dupe of pull #45, (which I just merged). Thanks anyways :)
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/21#issuecomment-47384949
Dupe of #45, which i just merged. Thanks anyways.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/30#issuecomment-47385079
Dupe of #45, which i just merged. Thanks anyway :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/15#issuecomment-47385186
Looks like this change has now been made. Closing pull request. Thanks
anyways! :)
---
If your project is set up for it, you can reply to this email
I've reverted the change to Contacts that switched the order of parameters
in navigator.contacts.find (Sorry, guys, it's just a change that we can't
make in a point release, no matter how out-of-line the signature is with
the rest of the Cordova methods)
That fixes all of the contacts failures for
Github user dpesch commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/29#issuecomment-47385219
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/18#issuecomment-47385693
Sounds like a neat feature, but according to:
https://developer.apple.com/library/ios/documentation/EventHandling/Conceptual/EventHandlingiPhoneOS/Re
Thanks Ian !
On Fri, Jun 27, 2014 at 2:36 PM, Ian Clelland
wrote:
> I've reverted the change to Contacts that switched the order of parameters
> in navigator.contacts.find (Sorry, guys, it's just a change that we can't
> make in a point release, no matter how out-of-line the signature is with
>
I really want/need this plugin to come out with the fixes it has before
monday, otherwise I'll have to apply the changes myself manually. I'd be
great if we had this vote complete today. I appreciate the effort in
advance.
2014-06-27 10:53 GMT-03:00 Ian Clelland :
> Anyone else?
>
> (I'd love fo
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/6#issuecomment-47385929
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-47385999
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Hi Ian,
I planned to take a look on CB-7003 navigator.contacts.pickContact picks wrong
contact on Android 4.3 and 4.4.3 versions" on Monday. It will be great if we
can include this fix to release.
https://issues.apache.org/jira/browse/CB-7003
Thx!
Sergey
-Original Message-
From: iclell
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/19#issuecomment-47386709
Looks good, but as per the ML discussion we don't want tests to be included
in the release version of the plugin. Please create a new PR with the tes
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-lib/pull/44
CB-6879 fix cordova serve
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsoref/cordova-lib cb_6879
Alternatively you can review and apply
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/18#issuecomment-47387136
Looks like this was fixed with #20, which i just merged. Thanks anyways!
---
If your project is set up for it, you can reply to this email and have
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/13#issuecomment-47387215
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/11#issuecomment-47387288
Please open a new PR with not added to main plugin.xml.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/19#issuecomment-47387715
Thanks for the fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/17#issuecomment-47387800
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
-1 on this release, `cordova serve` was broken.
That seems legitimate; I think we can delay for that.
How long do you think it'll take to deal with it?
On Fri, Jun 27, 2014 at 2:44 PM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:
> Hi Ian,
>
> I planned to take a look on CB-7003 navigator.contacts.pickContact picks
> wrong conta
Josh, are you -1'ing a cancelled vote? Was this meant for the currently
active vote thread, or the already-cancelled thread from Monday?
On Fri, Jun 27, 2014 at 3:00 PM, Josh Soref wrote:
> -1 on this release, `cordova serve` was broken.
>
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47388513
Definitely a good bug to have fixed. Could you clarify for me why the need
for swizzling? Instead of just setting shouldAutorotate directly
---
If y
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/13#issuecomment-47388601
Assuming this is merged and closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Not sure. It's best to file an issue at:
http://issues.apache.org/jira/browse/CB
... so it can be tracked and evaluated by the devs, and you can be notified.
Sign up here:
https://issues.apache.org/jira/secure/Signup!default.jspa
Thanks!
On Tue, Jun 24, 2014 at 10:51 AM, Marc Syp wrote:
> H
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/10#issuecomment-47388724
Thanks for the fix. Looks like it was fixed on master recently though.
---
If your project is set up for it, you can reply to this email and have your
r
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/7#issuecomment-47388832
PR needs rebasing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user mbradshawabs commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/34#issuecomment-47389019
It's already been released in the plugin, back in April.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user mbradshawabs closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
There is probably nothing we can do about this. If your image is too large,
or if you don't allow apps to run in the background, this will happen. We
did have an issue but we closed it once it was mitigated. It was open for
over 2 years at that point.
We currently don't have plans to create our
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-47389170
Change looks good to me. @phaitour - have you signed the Apache ICLA (can
be done online):
http://www.apache.org/licenses/#clas
@shazron -
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
1 - 100 of 165 matches
Mail list logo
