[GitHub] cordova-wp8 pull request: Fixes issue when multiple simultaneous r...

2014-05-28 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-wp8/pull/37#issuecomment-44372623 Oops. Returned property to its place. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-05-28 Thread fdummert
Github user fdummert commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/7#issuecomment-44382201 Thank you for adding the basic build functionality for Firefox OS. Unfortunately the adm-zip module used to generate the package.zip is buggy and often cr

Android Plugin API

2014-05-28 Thread Erik Jan de Wit
Hi, When one is writing a plugin for android ATM the api that you have to implement has a execute method that has the action as a string: @Override public boolean execute(String action, JSONArray args, CallbackContext callbackContext) throws JSONException { if ("beep".equals(action))

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-05-28 Thread DanielFreiburger
Github user DanielFreiburger commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-44406214 In File.js always "lastModifiedDate" is used, in Metadata.js always "modificationTime" is used but there is no correlation between these two.

Re: Plugin release

2014-05-28 Thread Lorin Beer
I volunteer Steve! On Tue, May 27, 2014 at 5:05 PM, Steven Gill wrote: > Good idea. I need to merge some PRs in before we move forward. Any > volunteers for being the release master :P > > > On Tue, May 27, 2014 at 3:54 PM, Jesse wrote: > >> I think we have a bunch of plugin updates that need to

Re: Android Plugin API

2014-05-28 Thread Joe Bowser
The execute command exists for security reasons. We don't want any methods other than execute exposed to Javascript. I also prefer this approach because it is less prone to less catastrophic bugs than using Java reflection. We try and only use reflection when we have to. On Wed, May 28, 2014 at

[GitHub] cordova-lib pull request: CB-6698: Support library references for ...

2014-05-28 Thread mbektchiev
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/21 CB-6698: Support library references for Android via the framework tag The framework tag can be contain the following attributes: * **src** - (**required**) relative path to the di

[GitHub] cordova-lib pull request: CB-6711: Use parseProjectFile when worki...

2014-05-28 Thread mbektchiev
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/15#issuecomment-44412361 Ping. Anyone willing to review? :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

Re: adding platforms to npm for dependency sanity

2014-05-28 Thread Michal Mocny
I tend to agree with Andrew that it should not be necessary to add platforms to CLI's package.json dependency list. I'm not sure that there is a benefit to doing that, except perhaps that ability to add platforms when offline and you haven't loaded them previously. On the other hand, I think user

Re: Android Plugin API

2014-05-28 Thread Andrew Grieve
Another reasonable approach would be to use a Map, but that can be implemented on top of what is currently exposed. I'm quite wary of Reflection as well. On Wed, May 28, 2014 at 10:06 AM, Joe Bowser wrote: > The execute command exists for security reasons. We don't want any > methods other tha

[GitHub] cordova-docs pull request: CB-6127 - Latest translation for 3.5

2014-05-28 Thread ldeluca
GitHub user ldeluca opened a pull request: https://github.com/apache/cordova-docs/pull/207 CB-6127 - Latest translation for 3.5 CB-6127 - Latest translation for 3.5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ldeluca/cordova-d

Re: adding platforms to npm for dependency sanity

2014-05-28 Thread Michal Mocny
Also, to Jesse's suggestion about having a package.json for each installed platform in a cordova project -- I'm not sure that is necessary. You can require these node scripts explicitly already: aka: require('./platforms/android/cordova/run') instead of exec('./platforms/android/cordova/run'). W

[GitHub] cordova-lib pull request: CB-6711: Use parseProjectFile when worki...

2014-05-28 Thread kamrik
Github user kamrik commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/15#discussion_r13134502 --- Diff: cordova-lib/src/plugman/util/config-changes.js --- @@ -510,8 +509,7 @@ function ConfigFile_load() { self.data = xml_helpers.parseElem

[GitHub] cordova-lib pull request: CB-6711: Use parseProjectFile when worki...

2014-05-28 Thread mbektchiev
Github user mbektchiev commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/15#discussion_r13134717 --- Diff: cordova-lib/src/plugman/util/config-changes.js --- @@ -510,8 +509,7 @@ function ConfigFile_load() { self.data = xml_helpers.parse

[GitHub] cordova-lib pull request: CB-6711: Use parseProjectFile when worki...

2014-05-28 Thread mbektchiev
Github user mbektchiev commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/15#discussion_r13135048 --- Diff: cordova-lib/src/plugman/util/config-changes.js --- @@ -510,8 +509,7 @@ function ConfigFile_load() { self.data = xml_helpers.parse

Re: Android Plugin API

2014-05-28 Thread Joe Bowser
In case anyone is curious, here's why we minimize reflection: https://labs.mwrinfosecurity.com/blog/2013/09/24/webview-addjavascriptinterface-remote-code-execution/ On Wed, May 28, 2014 at 7:33 AM, Andrew Grieve wrote: > Another reasonable approach would be to use a Map, but > that can be implem

[GitHub] cordova-lib pull request: CB-6711: Use parseProjectFile when worki...

2014-05-28 Thread kamrik
Github user kamrik commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/15#discussion_r13135935 --- Diff: cordova-lib/src/plugman/util/config-changes.js --- @@ -510,8 +509,7 @@ function ConfigFile_load() { self.data = xml_helpers.parseElem

Re: adding platforms to npm for dependency sanity

2014-05-28 Thread Brian LeRoux
npm i cordova-ios@3.5.0 Right? On May 27, 2014 11:06 PM, "Andrew Grieve" wrote: > Lazy loading is what will give us the ability to support multiple versions > of platforms. > > If we don't support users choosing the version of the platform they want, > then they will resist updating their versio

Re: Build Cordova apps in VIsual Studio for iOS, Android, WP8 and Windows Store

2014-05-28 Thread Josh Soref
Parashuram wrote: > At the moment, this is supported only in Pro, Premium and Ultimate but >not is express. > Is that a blocker for you? > I could take your feedback to the Visual Studio team at Microsoft. It's a problem for a number of us. I'd love to use it/give feedback, but I'm not I a positi

Re: Android Plugin API

2014-05-28 Thread Erik Jan de Wit
So this security issue is only a problem if you are able to inject some arbitrary js code. If your app ships with it’s own html and js this is very hard to do. If the only reason for this is security then why not have the same approach on iOS here methods are invoked dynamicly. On 28 May,2014,

[GitHub] cordova-lib pull request: CB-6698: Support library references for ...

2014-05-28 Thread kamrik
Github user kamrik commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/21#discussion_r13137628 --- Diff: cordova-lib/src/plugman/platforms/android.js --- @@ -80,10 +84,115 @@ module.exports = { }, "framework": { install:

[GitHub] cordova-lib pull request: CB-6711: Use parseProjectFile when worki...

2014-05-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-05-28 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-44431873 Hmm File.js represents the File interface in the File API spec: http://www.w3.org/TR/FileAPI/#file and it does specify lastModifiedDate, which is correct.

Re: Build Cordova apps in VIsual Studio for iOS, Android, WP8 and Windows Store

2014-05-28 Thread Shazron
Josh, I believe all Apache Committers get a complimentary subscription to MSDN, if that's a barrier. Login required: https://svn.apache.org/repos/private/committers/donated-licenses/msdn-subscription.html On Wed, May 28, 2014 at 8:23 AM, Josh Soref wrote: > Parashuram wrote: > > At the moment, t

Re: Android Plugin API

2014-05-28 Thread Joe Bowser
We don't want this pattern for Android because it is also more bug prone. On May 28, 2014 8:28 AM, "Erik Jan de Wit" wrote: > > So this security issue is only a problem if you are able to inject some arbitrary js code. If your app ships with it’s own html and js this is very hard to do. No, it's

[GitHub] cordova-docs pull request: CB-6127 - Latest translation for 3.5

2014-05-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/207 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: [Blackberry10] View logging events without the IDE

2014-05-28 Thread Marcel Kinard
Should this info go in the BB10 platform docs in cordova-docs? On May 26, 2014, at 11:09 AM, Martin Gonzalez Glez wrote: > Yes agree, Momentics simplifies the process of course. > This process it's aimed in the case that only Webworks it's available, or > for those who does not use Momentics. >

Re: [GitHub] cordova-lib pull request: CB-6698: Support library references for ...

2014-05-28 Thread Mark Koudritsky
The plugin.xml spec is here http://docs.phonegap.com/en/3.4.0/plugin_ref_spec.md.html On Wed, May 28, 2014 at 1:56 PM, Jesse wrote: > Where is the document that outlines all of the tags supported in > plugin.xml, the expected meaning of those tags, and what attributes they > support. > > Other

Re: [GitHub] cordova-lib pull request: CB-6698: Support library references for ...

2014-05-28 Thread Jesse
Where is the document that outlines all of the tags supported in plugin.xml, the expected meaning of those tags, and what attributes they support. Other than that, I can only assume this doesn't break on iOS + Windows 8. @purplecabbage risingj.com On Wed, May 28, 2014 at 8:34 AM, kamrik wro

Re: Documentation generation process

2014-05-28 Thread Lisa Seacat DeLuca
Andrey~ The information on the translation process is available on our wiki here: http://wiki.apache.org/cordova/CordovaTranslations. It'd be nice if we had additional information somewhere to get people's attention before they start translating. I'm open to suggestions on where to put the de

Re: Android Plugin API

2014-05-28 Thread Erik Jan de Wit
On 28 May,2014, at 19:06 , Joe Bowser wrote: > We don't want this pattern for Android because it is also more bug prone. Doesn’t the same hold true for iOS? > > On May 28, 2014 8:28 AM, "Erik Jan de Wit" wrote: >> >> So this security issue is only a problem if you are able to inject some >

Re: Android Plugin API

2014-05-28 Thread Joe Bowser
On May 28, 2014 11:21 AM, "Erik Jan de Wit" wrote: > > > On 28 May,2014, at 19:06 , Joe Bowser wrote: > > > We don't want this pattern for Android because it is also more bug prone. > > Doesn’t the same hold true for iOS? > I don't know, it very much could be. It could be that this makes sense

Re: Android Plugin API

2014-05-28 Thread Erik Jan de Wit
> > I don't know, it very much could be. It could be that this makes sense in > Obj-C but not in Java based on how they handle NoSuchMethod. I'd prefer to > not have to rely on an exception being caught, especially since it could > suppress other exceptions being thrown that I want to know abou

Re: [GitHub] cordova-lib pull request: CB-6698: Support library references for ...

2014-05-28 Thread Jesse
Thanks Mark, I have updated the doc with details for windows8. I will be testing to make sure there is no regression. @purplecabbage risingj.com On Wed, May 28, 2014 at 10:59 AM, Mark Koudritsky wrote: > The plugin.xml spec is here > http://docs.phonegap.com/en/3.4.0/plugin_ref_spec.md.html

Budapest in November?

2014-05-28 Thread Brian LeRoux
http://events.linuxfoundation.org//events/apachecon-europe/program/cfp Let's get Cordova there! I'm certain the event and some our companies can sponsor travel.

[GitHub] cordova-plugin-inappbrowser pull request: Adding permission info

2014-05-28 Thread rodms10
GitHub user rodms10 opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/46 Adding permission info Adding auto-permissions config. @zalun, please take a look. You can merge this pull request into a Git repository by running: $ git pull https://githu

[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...

2014-05-28 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-44455699 Thx @purplecabbage . I've tested merged version and confirm it works correct on Android, iOS, WP8, Windows8, --- If your project is set up for it, you

Re: Android Plugin API

2014-05-28 Thread Naik, Archana
iOS has [object respondsToSelector:@selector(selector)] to check if selector exists or not. On 5/28/14 12:05 PM, "Erik Jan de Wit" wrote: > >> >> I don't know, it very much could be. It could be that this makes sense >>in >> Obj-C but not in Java based on how they handle NoSuchMethod. I'd >>

Re: Android Plugin API

2014-05-28 Thread Shazron
https://github.com/apache/cordova-ios/blob/50ca482c8e861c1aa480dadba726b1abbacbc0e1/CordovaLib/Classes/CDVCommandQueue.m#L193-L198 On Wed, May 28, 2014 at 12:05 PM, Erik Jan de Wit wrote: > > > > > I don't know, it very much could be. It could be that this makes sense > in > > Obj-C but not in

[Blackberry10] cordova emulate blackberry10 command fails

2014-05-28 Thread Martin Gonzalez
I've been working with the Blackberry 10 simulator, recently I tried to deploy an app into the simulator but it always fails, even if the simulator is registered at .cordova\blackberry10.json. steps: cordova create BB10Test cordova platform add blackberry10 cordova build blackberry10 then cordova

HTML5DevConf Intro talk slides & interview

2014-05-28 Thread Lisa Seacat DeLuca
Just wanted to share this quick youtube interview from the HTML5DevConf last week: https://www.youtube.com/watch?v=N94XLhcbajE I gave my introductory Apache Cordova talk. My slides are available on github here: https://github.com/ldeluca/slides/tree/master/HTML5DevConf2014 I received a wide r

Re: [Blackberry10] cordova emulate blackberry10 command fails

2014-05-28 Thread Bryan Higgins
If it is registered in DHCP leases, it should get automatically detected. There is a known issue when you upgrade VMWare, the file gets blown away and doesn't re-populate until you reboot the simulator. What output do you get from 'blackberry-deploy -test ' ? You could also try manually registeri

Re: [Blackberry10] cordova emulate blackberry10 command fails

2014-05-28 Thread Martin Gonzalez
I have rebooted the simulator several times, installed the latest VMWare and the one before of it. It's curious that when I run blackberry-deploy -test it doesn't return anything. Not a single response, if I use 'blackberry-deploy -listDeviceInfo ' it returns the proper output. 2014-05-28 15:57

Re: [Blackberry10] cordova emulate blackberry10 command fails

2014-05-28 Thread Martin Gonzalez
I have tracked down the problem to the utils.exec, just at the childprocess.exec. This is the exact command that it's sent in there: "c:\Program Files\BlackBerry\BB10 WebWorks SDK 2.0.0.71\cordova-bl ackberry\bin\dependencies\bb-tools\bin\blackberry-deploy" -listDeviceInfo 192.16 8.153.128 Note: c

[GitHub] cordova-plugin-dialogs pull request: Fix Beep exception on Android

2014-05-28 Thread shortstuffsushi
Github user shortstuffsushi commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/20#issuecomment-44468524 @agrieve, would you, or someone who maintains this plugin, care to comment? --- If your project is set up for it, you can reply to this email and

Unknown "committer"

2014-05-28 Thread Shazron
https://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;a=commit;h=b128ad7c6dcf0061c8616ba3e145c07faeaa8e02 Rowell Cruz, from BlackBerry. He has a listed CLA but is definitely not an Apache Cordova committer. Can someone at Blackberry shed some light on this? I was triaging issues and ca

Re: HTML5DevConf Intro talk slides & interview

2014-05-28 Thread Igor Costa
Great follow up Lisa. That's a lot of questions surrounding the area about Cordova don't have a UI for it. I've already posted while 2012 about that, http://goo.gl/WmJ8ep. But this is loop question we always get in. I know that it's hard to keep up with so many UI kits, frameworks for mobile, bu

Re: Unknown "committer"

2014-05-28 Thread Joe Bowser
I'm pretty sure this is more of a git issue than anything else: I found an unknown committer in Cordova-Android: https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commit;h=11fc6be32871c3e6ce5159d34c99665cd7d05de5 It would be good to know how this commit wound up in here, since I wou

Re: Unknown "committer"

2014-05-28 Thread Shazron
Yeah mystery solved: http://apache.markmail.org/thread/zxrdc25iaq4g7bu7 I usually add a ".patch" to the Github PR url and download then apply the patch (after review of course) then do a signoff when applying the patch (git am --signoff ...) On Wed, May 28, 2014 at 4:55 PM, Joe Bowser wrote: >

Re: Unknown "committer"

2014-05-28 Thread Michal Mocny
I think that may be the result of the way we do PR.. I merged the PR Joe points to, and I did it by pulling from his fork, and merging it into cordova-android. In theory, this way any edits I need to do end up in my merge commit, and the contributor changes are isolated in the original work witho

Re: Unknown "committer"

2014-05-28 Thread Michal Mocny
..both the git am --signoff and the git merge --no-ff option ends up with committer: and author: metadata that are not cordova committers. I think that should be fine so long as its clear which committer did the signoff / merge -- but wanted to confirm? On Wed, May 28, 2014 at 8:11 PM, Shazron

Re: Unknown "committer"

2014-05-28 Thread Shazron
http://apache.markmail.org/thread/msim6zib75ppy2c4 On Wed, May 28, 2014 at 4:55 PM, Joe Bowser wrote: > I'm pretty sure this is more of a git issue than anything else: > > I found an unknown committer in Cordova-Android: > > https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commit

Re: Unknown "committer"

2014-05-28 Thread Shazron
I think its fine as long as it's traceable who did the actual commit On Wed, May 28, 2014 at 5:15 PM, Michal Mocny wrote: > ..both the git am --signoff and the git merge --no-ff option ends up with > committer: and author: metadata that are not cordova committers. I think > that should be fine

Re: Unknown "committer"

2014-05-28 Thread Steven Gill
I use coho to manage PRs. Not sure if it handles this use case. ./coho list-pulls -r repoName If commits exist, coho outputs something like --- stevengill: Update tools-release-process.md (stevengill 3 day

[GitHub] cordova-coho pull request: Removed old upload release process

2014-05-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-coho pull request: Update cadence-release-process.md

2014-05-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-coho pull request: Update tools-release-process.md

2014-05-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Unknown "committer"

2014-05-28 Thread Andrew Grieve
The guidance for how to do pull requests is here: https://github.com/apache/cordova-coho/blob/master/docs/processing-pull-requests.md Sounds like it should be updated to include --sign-off or --no-ff or both? On Wed, May 28, 2014 at 8:23 PM, Steven Gill wrote: > I use coho to manage PRs. Not s

Re: Unknown "committer"

2014-05-28 Thread Shazron
It's super convenient if all pulled commits had sign offs for quick verification, but of course we have comm...@cordova.apache.org ML as a backup if we really need to dig down... On Wed, May 28, 2014 at 5:43 PM, Andrew Grieve wrote: > The guidance for how to do pull requests is here: > > https:

Re: Unknown "committer"

2014-05-28 Thread Josh Soref
Shazron wrote: >https://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;a=commit; >h=b128ad7c6dcf0061c8616ba3e145c07faeaa8e02 > >Rowell Cruz, from BlackBerry. He has a listed CLA but is definitely not an >Apache Cordova committer. Can someone at Blackberry shed some light on >this? It was

Pull requests for cordova-lib - allow cordova to be replaceable

2014-05-28 Thread Josh Soref
We didn't have pull request notification (I filed a bug, I think it's fixed), https://github.com/apache/cordova-lib/pull/20 This makes our toolchain much friendlier to users. It will enable phonegap, webworks, and others to use cordova-lib and have error messages which make sense to users inste

Pull requests for cordova-lib - fix windows8 test

2014-05-28 Thread Josh Soref
The test is broken and has been for a while, Introduced by: https://issues.apache.org/jira/browse/CB-5421 fix: https://github.com/apache/cordova-lib/pull/8 Please merge...

[GitHub] cordova-lib pull request: CB-6767 Allow `cordova` to be replaceabl...

2014-05-28 Thread mmocny
Github user mmocny commented on the pull request: https://github.com/apache/cordova-lib/pull/20#issuecomment-44489272 I haven't tested yet, but.. I like it! @kamrik to also take a look, please. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cordova-registry-web pull request: Added the default route to redi...

2014-05-28 Thread jbavari
GitHub user jbavari opened a pull request: https://github.com/apache/cordova-registry-web/pull/4 Added the default route to redirect to homepage incase someone links to the wrong page Better to just show the homepage then to just see nothing. Found this from someone linking to the