Re: Pull request for [CB-2280] and [CB-2281]

2013-02-11 Thread Yaniv De Ridder
Great thanks ! On 10/02/13 20:02, "Andrew Grieve" wrote: >Done and done. > > >On Fri, Feb 8, 2013 at 10:34 AM, Yaniv De Ridder >wrote: > >> Thanks, >> >> You can check the comments in jira and in the pull request. Let me know >>if >> you need something from me :) >> >> /yaniv >> >> On 08/02/13

Re: Changing config.xml settings at runtime

2013-02-11 Thread Brian LeRoux
Hmm. Tricky: can an app modify the whitelist at runtime then? (Probably not a good idea.) On Sun, Feb 10, 2013 at 7:01 PM, Andrew Grieve wrote: > First - I'd like to add yet another setting for iOS: > > KeyboardShrinksView (boolean). > > It applies to apps that position their elements relative to

Re: http://issues.cordova.io is broken

2013-02-11 Thread Brian LeRoux
uuu, thought I had fixed that. should be working now. (its all dave's fault!) On Sun, Feb 10, 2013 at 11:04 PM, Tommy-Carlos Williams wrote: > http://brianleroux.damn-u-dave.jit.su/ > > Best ever failure message in a URL though ;)

Re: http://issues.cordova.io is broken

2013-02-11 Thread Tommy-Carlos Williams
I gathered it was his fault from the domain name. On 11/02/2013, at 8:48 PM, Brian LeRoux wrote: > uuu, thought I had fixed that. should be working now. (its all > dave's fault!) > > On Sun, Feb 10, 2013 at 11:04 PM, Tommy-Carlos Williams > wrote: >> http://brianleroux.damn-u-dave.jit.su

Re: Changing config.xml settings at runtime

2013-02-11 Thread Shazron
The only case (as Brian mentions) is not allowing the whitelist to be set at runtime. Also - does the app have to "reset" if a setting that was read at runtime was changed? ie we probably need a "configchanged" event/notification or something. For example, BackupWebStorage in iOS, etc. On Sun, Fe

Re: Changing config.xml settings at runtime

2013-02-11 Thread Andrew Grieve
Hmm, yeah, definitely doesn't make sense for the whitelist. Not really for BackupWebStorage either... If we're not saving across restarts, then BackupWebStorage won't use the updated settings anyways. Looking through the documentation, I think that most settings wouldn't have a reason to change...

Re: Android file chooser

2013-02-11 Thread Joe Bowser
I'm not familiar with Chrome's API, but I believe that there is a FileUtils API as well as the File Picker that Simon added a release ago that fires an intent to pick a file if you have a file picker installed. (Note: I don't use one, so it brings up the Gallery, Audio Player and other things assoc

Re: Changing config.xml settings at runtime

2013-02-11 Thread Shazron
Not sure about explicit methods since we will have more docs (and separate ones for the diff platforms). I personally would go with a generic API, and the setting to use would already be documented in the Project Settings doc. e.g. navigator.app.setConfigSetting('KeyboardShrinksView', false, win,

Re: Changing config.xml settings at runtime

2013-02-11 Thread Michal Mocny
I'm not sure why a single generic api would mean less docs? We would still need to document each valid key, wouldn't we? Anyway, I like the plugin approach suggested, especially since there will likely be very few configurations that need adjusting at runtime. (btw, another adjustable setting mi

Re: Changing config.xml settings at runtime

2013-02-11 Thread Michal Mocny
Regarding less docs: okay I see now Shaz, we use the same key names as we have in configurations, and so we defer to the documentation there. Makes sense. Should we then have a separate section/attribute for run-time adjustable config values? On Mon, Feb 11, 2013 at 2:38 PM, Michal Mocny wrote

Re: Android file chooser

2013-02-11 Thread Max Woghiren
You're right about the FileUtils API, but I need a Cordova File object to access those methods. yields a native File object, so, for instance, I can't use FileWriter with it. Native File objects also don't have full paths, which are useful (eg. for FileTransfer.upload, which requires a full path

Re: Android file chooser

2013-02-11 Thread Simon MacDonald
Check out some code I wrote in a side project that can do it. https://github.com/macdonst/corinthian Simon Mac Donald http://hi.im/simonmacdonald On Mon, Feb 11, 2013 at 3:05 PM, Max Woghiren wrote: > You're right about the FileUtils API, but I need a Cordova File object to > access those metho

BlackBerry 2.4.0 Release

2013-02-11 Thread Tim Kim
Hey gang, So it appears I forgot to push out a commit to update the version number in the BlackBerry repo, but accidently tagged 2.4.0 anyways. Should I force re-tag the repo? Also, the download on phonegap.com for the BlackBerry repo was kinda messed up anyways. In that the robson tool didn't co

Re: BlackBerry 2.4.0 Release

2013-02-11 Thread Shazron
Since it's a low risk change (version number only), I say re-tag, and re-package - who is in charge of the robson tool? File a bug against it Or is the version number not worth it? On Mon, Feb 11, 2013 at 1:16 PM, Tim Kim wrote: > Hey gang, > > So it appears I forgot to push out a commit to upd

RE: Tagging 2.3.0rc2?

2013-02-11 Thread Herm Wong
both requests have been merged. > From: markus.leutwy...@hp.com > To: dev@cordova.apache.org > Subject: RE: Tagging 2.3.0rc2? > Date: Fri, 8 Feb 2013 10:35:12 + > > Hi Herm, > > I have 2 pull requests to put into Cordova webOS 2.5.0rc1 > > https://github.com/apache/cordova-js/pull/7 > https

Re: BlackBerry 2.4.0 Release

2013-02-11 Thread Brian LeRoux
Tim, has anyone reported this or are you the only one who has noticed? (if the latter, I say we re-package, if the former we should probably do a retag =( On Mon, Feb 11, 2013 at 10:16 PM, Shazron wrote: > Since it's a low risk change (version number only), I say re-tag, and > re-package - who is

Re: BlackBerry 2.4.0 Release

2013-02-11 Thread Tim Kim
Someone had brought it up through the google groups: https://groups.google.com/forum/#!topic/phonegap/wnICEdCs-Qk/discussion On 11 February 2013 15:24, Brian LeRoux wrote: > Tim, has anyone reported this or are you the only one who has noticed? > (if the latter, I say we re-package, if the form

cordova command cli and merges concept pull request

2013-02-11 Thread Michael Wolf
Hey all: I submitted a pull request for an enhancement of the addition of a merges folder/concept into the cli build process. https://github.com/apache/cordova-cli/pull/3 The concept of merges is pretty simple, to support a common core web base across platforms, but allow for deploying platfor