Re: cordova-plugin-inappbrowser@4 major version bump - proposal

2019-12-31 Thread Niklas Merz
Thanks Bryan Ellis, that's the plan I would like to follow, too. If anyone else would like to see a PR in this minor, let us know or just add it to the 3.2.0 milestone on Github. Am 31. Dez. 2019, 03:17, um 03:17, Chris Brody schrieb: >+1 to wait for the minor release to be published and +1 on

Re: cordova-plugin-inappbrowser@4 major version bump - proposal

2019-12-30 Thread Chris Brody
+1 to wait for the minor release to be published and +1 on the background, thanks! I just wanted to announce something that I think should be in consideration for the near future, for reasons that are hopefully clear on GitHub. On Mon, Dec 30, 2019 at 8:57 PM Bryan Ellis wrote: > For some back

Re: cordova-plugin-inappbrowser@4 major version bump - proposal

2019-12-30 Thread Bryan Ellis
For some background information on the minor release, there are a lot of changes already merged into master and waiting for a release. Additionally, since Cordova iOS last minor introduced of the WKWebViewOnly feature, it would be nice if IAB can pair this supported in a minor release, and not a m

Re: cordova-plugin-inappbrowser@4 major version bump - proposal

2019-12-30 Thread Bryan Ellis
A minor release is currently in progress so we will not do a major version bump until the minor is finished. On Tue, Dec 31, 2019 at 10:29 AM Chris Brody wrote: > I would like to propose that we do this major version bump, review > https://github.com/apache/cordova-plugin-inappbrowser/pull/600 t

cordova-plugin-inappbrowser@4 major version bump - proposal

2019-12-30 Thread Chris Brody
I would like to propose that we do this major version bump, review https://github.com/apache/cordova-plugin-inappbrowser/pull/600 then merge it in order to resolve multiple issues stemming from window.open overwrite. My purpose is to help relieve some plugin support burden moving forward. I would