Re: cordova-cli plugin add/remove/prepare proposal

2013-03-08 Thread Lorin Beer
Thanks! Will try to drop in once I'm stationary On Fri, Mar 8, 2013 at 10:20 AM, Filip Maj wrote: > Here's the hangout link! > > https://plus.google.com/hangouts/_/d769196db4691ea063c6787c6d660719e021e594 > ?authuser=0&hl=en > > > On 3/7/13 11:21 AM, "Jesse" wrote: > > >Do we have a time set f

Re: cordova-cli plugin add/remove/prepare proposal

2013-03-08 Thread Filip Maj
Here's the hangout link! https://plus.google.com/hangouts/_/d769196db4691ea063c6787c6d660719e021e594 ?authuser=0&hl=en On 3/7/13 11:21 AM, "Jesse" wrote: >Do we have a time set for this? >I won't be able to attend in person, but I will be in the hangout. > >Cheers, > Jesse > >On Wed, Feb 27,

Re: cordova-cli plugin add/remove/prepare proposal

2013-03-07 Thread Jesse
Do we have a time set for this? I won't be able to attend in person, but I will be in the hangout. Cheers, Jesse On Wed, Feb 27, 2013 at 4:42 PM, Al Harding wrote: > ...and the BlackBerry guys! :) > > > > On Wed, Feb 27, 2013 at 4:37 PM, Jeffrey Heifetz wrote: > > > Actually I'm lucky enough

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Al Harding
...and the BlackBerry guys! :) On Wed, Feb 27, 2013 at 4:37 PM, Jeffrey Heifetz wrote: > Actually I'm lucky enough to be heading down to join in on the fun, > looking forward to meeting all of you. > > On 2013-02-27, at 6:26 PM, Al Harding wrote: > > > Awesome! We've got a room booked at Adobe

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Jeffrey Heifetz
Actually I'm lucky enough to be heading down to join in on the fun, looking forward to meeting all of you. On 2013-02-27, at 6:26 PM, Al Harding wrote: > Awesome! We've got a room booked at Adobe SF with projector, camera, beer, > so we can loop anyone in who is remote. > > Look forward to meeti

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Tommy-Carlos Williams
Poking my nose in… Aside from 100% agreeing that the user's www should no be polluted, I would also like to flag that perhaps being able to re-add a plugin to a platform would be useful. If you are not pushing your platforms dirs to your repo, for instance… you will need some way to get your p

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Al Harding
Awesome! We've got a room booked at Adobe SF with projector, camera, beer, so we can loop anyone in who is remote. Look forward to meeting the Google guys! -Al On Wed, Feb 27, 2013 at 2:44 PM, Michal Mocny wrote: > Oh sweet, we were just saying how we still haven't met most of you. > > Sadl

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Michal Mocny
Oh sweet, we were just saying how we still haven't met most of you. Sadly, Braden is not coming on this trip, but Andrew, Max and I will be there (and working from Adobe Friday) we will have time to chat. Can bring Braden in via Hangout. -Michal On Wed, Feb 27, 2013 at 5:40 PM, Filip Maj wrot

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Filip Maj
Yep! There's an online code review planned for March 22nd for both the cli tools as well as the plugman tool. Also: next week most Adobe cordova folk will be in SF, and so will you Googlers ya? We can talk specifics and hash out our ideas better then and bring it back to the list. On 2/27/13 2:26

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Michal Mocny
I think we have a hangout scheduled for that conversation (among others) right? Its good that Braden is setting up topics of conversation :) -Michal On Wed, Feb 27, 2013 at 4:37 PM, Filip Maj wrote: > I think this is a good conversation to have. > > Note that, if we do split up how plugins ar

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Filip Maj
I think this is a good conversation to have. Note that, if we do split up how plugins are treated and when we copy files around (I.e. Move the www assets on every prepare, but the native files only on platform/plugin adds), then the plugman tool will either need finer-grained support for these typ

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Braden Shepherdson
I'm on the fence about native plugin code. I think iOS has some complications there. Over the course of my work on the installation prototype, I've actually moved to copying plugin www files on every prepare, that works great. For native code, I wonder if that's best done on add/remove. I was mos

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Filip Maj
Couple notes before I add some comments: - in general plugin add and rm is COMPLETELY delegated to the plugman tool. See [1]. Most of the code linked is error checking, otherwise it shells out to plugman.. With one exception.. - what happens in [2]. Which is the point Braden brought up about pollu

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-25 Thread Michal Mocny
Just to clarify this in my head: * Since we have a prepare step now, you propose moving some of the logic that used to run on plugin add out into the prepare step. That sounds good. * You want to fix how we track which plugins are installed by going to source instead of some config file. That so

cordova-cli plugin add/remove/prepare proposal

2013-02-25 Thread Braden Shepherdson
I'm running into several problems with the current implementation of cordova-cli: * There's no single source of truth for what plugins are installed. It uses the presence of a plugin's name in the www/config.xml currently. This doesn't work for JS-only plugins, and there are some, especially on ot