Re: Review Request 12668: Unified whitelist implementation for iOS

2013-07-17 Thread Ian Clelland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12668/ --- (Updated July 17, 2013, 3:50 p.m.) Review request for cordova. Changes --

Re: Review Request 12668: Unified whitelist implementation for iOS

2013-07-17 Thread Ian Clelland
> On July 17, 2013, 3:05 p.m., Andrew Grieve wrote: > > CordovaLib/Classes/CDVWhitelist.m, line 174 > > > > > > why remove? maybe at least replace with a comment. Removed because (whitelist==nil) is now the condition

Re: Review Request 12668: Unified whitelist implementation for iOS

2013-07-17 Thread Andrew Grieve
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12668/#review23280 --- CordovaLib/Classes/CDVWhitelist.m

Review Request 12668: Unified whitelist implementation for iOS

2013-07-17 Thread Ian Clelland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12668/ --- Review request for cordova. Repository: cordova-ios Description --- CB-4