Re: Supported Git version

2015-07-23 Thread Victor Sosa
Thanks a lot!! On Thu, Jul 23, 2015 at 12:23 PM Jesse wrote: > CB-9384 > https://github.com/apache/cordova-lib/pull/265 > > > > On Jul 23, 2015, at 10:10 AM, Victor Sosa > wrote: > > > > Now I understand. Thanks. > > Jesse, do you know the JIRA in which you worked this problem? > > > >> On Wed,

Re: Supported Git version

2015-07-23 Thread Jesse
CB-9384 https://github.com/apache/cordova-lib/pull/265 > On Jul 23, 2015, at 10:10 AM, Victor Sosa wrote: > > Now I understand. Thanks. > Jesse, do you know the JIRA in which you worked this problem? > >> On Wed, Jul 22, 2015 at 5:27 PM Jesse wrote: >> >> Yes, we absolutely need to be able t

Re: Supported Git version

2015-07-23 Thread Victor Sosa
Now I understand. Thanks. Jesse, do you know the JIRA in which you worked this problem? On Wed, Jul 22, 2015 at 5:27 PM Jesse wrote: > Yes, we absolutely need to be able to install plugins via github url and > support branches/tags/commit-sha as part of the url. Also, sub-folders > within githu

Re: Supported Git version

2015-07-22 Thread Jesse
Yes, we absolutely need to be able to install plugins via github url and support branches/tags/commit-sha as part of the url. Also, sub-folders within github repos. The feature I removed was the 'git version checking bs' [1] Carlos, npm supports installing from github too[2]. I'm not sure why y

Re: Supported Git version

2015-07-22 Thread Darryl Pogue
Thanks for clarifying :) On 22 July 2015 at 14:53, Steven Gill wrote: > To clarify, we aren't removing installing from git. It is totally > important. > > Jesse fixed a problem with not being able to install from git when you > point to specific commit. This was do the --depth flag being used. H

Re: Supported Git version

2015-07-22 Thread Steven Gill
To clarify, we aren't removing installing from git. It is totally important. Jesse fixed a problem with not being able to install from git when you point to specific commit. This was do the --depth flag being used. He recently removed the use of --depth and this may fix the git 1 vs 2 issues Victo

Re: Supported Git version

2015-07-22 Thread Darryl Pogue
Support for installing from git URLs for plugins is a pretty important requirement for us as end users. On 22 July 2015 at 14:21, Carlos Santana wrote: > +1 only npm id or local path should be supported > On Wed, Jul 22, 2015 at 5:16 PM Victor Sosa > wrote: > > > Wait a minute, Jesse? what you

Re: Supported Git version

2015-07-22 Thread Carlos Santana
+1 only npm id or local path should be supported On Wed, Jul 22, 2015 at 5:16 PM Victor Sosa wrote: > Wait a minute, Jesse? what you mean by "I removed this 'feature'"? What > feature are you referring to? > > On Wed, Jul 22, 2015 at 3:50 PM Jesse wrote: > > > No idea, but, I just removed this '

Re: Supported Git version

2015-07-22 Thread Victor Sosa
Wait a minute, Jesse? what you mean by "I removed this 'feature'"? What feature are you referring to? On Wed, Jul 22, 2015 at 3:50 PM Jesse wrote: > No idea, but, I just removed this 'feature' as there were errors with > checking out a particular tag or commit. > > > > > On Jul 22, 2015, at 1:29

Re: Supported Git version

2015-07-22 Thread Jesse
No idea, but, I just removed this 'feature' as there were errors with checking out a particular tag or commit. > On Jul 22, 2015, at 1:29 PM, Victor Sosa wrote: > > Hello community. > > I've been playing a little with Cordova on simple scenarios, and noticed > that when using Git 2.x I get