Re: Naming: cordova-2.8.0.js --> cordova.js

2013-05-01 Thread Michael Brooks
Jeff, thanks for the valuable recap! That is exactly the difference I was talking about. I would propose that > instead of native placing the file there, we just make it a final part of > the build step. Just as we've done with other CLI tasks, make a micro > cordova script to do it, and have it c

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-05-01 Thread Brian LeRoux
Or we put the version in the filename. On Wed, May 1, 2013 at 9:00 AM, Jesse MacFadyen wrote: > Interesting journey, Jeffery. > What if instead of linking from www/index.html to www/cordova.js, we > put the js in the app root above www? > > Or:

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-05-01 Thread Jesse MacFadyen
Interesting journey, Jeffery. What if instead of linking from www/index.html to www/cordova.js, we put the js in the app root above www? Or:

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-05-01 Thread Jeffrey Heifetz
Tl;dr I'd like to propose a different but similar solution based on the evolution of WebWorks. That we automatically inject cordova.js into a specific place in the app (say the root since thats where cordova_plugins is) and then the developer simply adds a script tag to the correct location account

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-05-01 Thread Giorgio Natili
+1 cordova.js with version as a header comment On Wed, May 1, 2013 at 6:15 AM, Benn Mapes wrote: > +1 for sure > > > On Tue, Apr 30, 2013 at 2:39 PM, Anis KADRI wrote: > > > +1! > > > > > > On Tue, Apr 30, 2013 at 1:19 PM, Jesse wrote: > > > > > +1 > > > > > > @purplecabbage > > > risingj

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-04-30 Thread Benn Mapes
+1 for sure On Tue, Apr 30, 2013 at 2:39 PM, Anis KADRI wrote: > +1! > > > On Tue, Apr 30, 2013 at 1:19 PM, Jesse wrote: > > > +1 > > > > @purplecabbage > > risingj.com > > > > > > On Tue, Apr 30, 2013 at 1:04 PM, Shazron wrote: > > > > > +1 > > > > > > > > > On Tue, Apr 30, 2013 at 12:54

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-04-30 Thread Anis KADRI
+1! On Tue, Apr 30, 2013 at 1:19 PM, Jesse wrote: > +1 > > @purplecabbage > risingj.com > > > On Tue, Apr 30, 2013 at 1:04 PM, Shazron wrote: > > > +1 > > > > > > On Tue, Apr 30, 2013 at 12:54 PM, James Jong > wrote: > > > > > +1 Cleaner. Thanks Andrew! > > > > > > -James Jong > > > > > > On

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-04-30 Thread Jesse
+1 @purplecabbage risingj.com On Tue, Apr 30, 2013 at 1:04 PM, Shazron wrote: > +1 > > > On Tue, Apr 30, 2013 at 12:54 PM, James Jong wrote: > > > +1 Cleaner. Thanks Andrew! > > > > -James Jong > > > > On Apr 30, 2013, at 3:31 PM, Lorin Beer > wrote: > > > > > +1 > > > duplicated informatio

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-04-30 Thread Shazron
+1 On Tue, Apr 30, 2013 at 12:54 PM, James Jong wrote: > +1 Cleaner. Thanks Andrew! > > -James Jong > > On Apr 30, 2013, at 3:31 PM, Lorin Beer wrote: > > > +1 > > duplicated information is a good redundancy to remove > > > > > > On Tue, Apr 30, 2013 at 11:41 AM, Brian LeRoux wrote: > > > >>

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-04-30 Thread James Jong
+1 Cleaner. Thanks Andrew! -James Jong On Apr 30, 2013, at 3:31 PM, Lorin Beer wrote: > +1 > duplicated information is a good redundancy to remove > > > On Tue, Apr 30, 2013 at 11:41 AM, Brian LeRoux wrote: > >> Sounds good. FTR we did it for issue tracking not arbitrarily. Having >> a sta

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-04-30 Thread Lorin Beer
+1 duplicated information is a good redundancy to remove On Tue, Apr 30, 2013 at 11:41 AM, Brian LeRoux wrote: > Sounds good. FTR we did it for issue tracking not arbitrarily. Having > a stamp at the top of the file fulfills the same end. > > On Tue, Apr 30, 2013 at 11:31 AM, Filip Maj wrote:

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-04-30 Thread Andrew Grieve
Great! I'll make it happen :) https://issues.apache.org/jira/browse/CB-3307 On Tue, Apr 30, 2013 at 2:41 PM, Brian LeRoux wrote: > Sounds good. FTR we did it for issue tracking not arbitrarily. Having > a stamp at the top of the file fulfills the same end. > > On Tue, Apr 30, 2013 at 11:31 AM,

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-04-30 Thread Brian LeRoux
Sounds good. FTR we did it for issue tracking not arbitrarily. Having a stamp at the top of the file fulfills the same end. On Tue, Apr 30, 2013 at 11:31 AM, Filip Maj wrote: > If I recall correctly the original reason was because putting the version > in after the lib name in the JS filename was

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-04-30 Thread Ken Wallis
Subject: Re: Naming: cordova-2.8.0.js --> cordova.js +1 cordova.js with version as a header comment On Tue, Apr 30, 2013 at 11:31 AM, Filip Maj wrote: > If I recall correctly the original reason was because putting the version > in after the lib name in the JS filename was wh

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-04-30 Thread Lucas Holmquist
+1 nice and clean On Apr 30, 2013, at 2:36 PM, Michael Brooks wrote: > +1 cordova.js with version as a header comment > > > On Tue, Apr 30, 2013 at 11:31 AM, Filip Maj wrote: > >> If I recall correctly the original reason was because putting the version >> in after the lib name in the JS file

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-04-30 Thread Michael Brooks
+1 cordova.js with version as a header comment On Tue, Apr 30, 2013 at 11:31 AM, Filip Maj wrote: > If I recall correctly the original reason was because putting the version > in after the lib name in the JS filename was what "other libraries did" > aka jQuery. > > +1 from me. > > On 4/30/13 11

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-04-30 Thread Filip Maj
If I recall correctly the original reason was because putting the version in after the lib name in the JS filename was what "other libraries did" aka jQuery. +1 from me. On 4/30/13 11:24 AM, "tommy-carlos Williams" wrote: >+1 > >Wouldn't this make mobile spec easier too? > >On 01/05/2013, at 4:

Re: Naming: cordova-2.8.0.js --> cordova.js

2013-04-30 Thread tommy-carlos Williams
+1 Wouldn't this make mobile spec easier too? On 01/05/2013, at 4:20, Andrew Grieve wrote: > This has been brought up a few times, but I'm not sure there's been a > decisive answer here yet... > > iOS now uses "cordova.ios.js" > Android uses "cordova.android.js", but renames it in a build step