Hello Team,
A PR is now ready for your review, I also updated all unit tests with this
new Camera API behavior across all platforms:
https://github.com/apache/cordova-plugin-camera/pull/432
Thank you
On Fri, Mar 8, 2019 at 6:42 PM Hazem Saleh wrote:
> I have implemented and tested the DATA_URL
I have implemented and tested the DATA_URL fix across all of the Camera
plugin supported platforms:
1. Android (Java)
2. iOS (Objective C)
3. OS X (Objective C)
4. Browser (JavaScript)
5. Windows Platform (JavaScript)
Since this is a cross-cutting concern across all of platforms f
I agree with Jesse.
IMHO regarding the positive impact of this change is that it simply fixes a
bug that exists for a long time ago, and will make the code that consumes
this API more cleaner, the user will not have hard code a DATA url prefix
every-time before the returned base64 string.
On Fri,
The downside would be that it would add yet another quirky implementation,
while this about not dragging along the existing quirky non-standard
implementation.
Existing users who don't want to change their code don't need to change
anything.
I expect usage of this api is quite low already ( anecdo
What is the downside of just introducing new options and not creating a
breaking change?
And what is the positive impact of this change that it necessitates that
every consumer of the existing API change their code?
IMHO that has not been made clear enough.
On 01/03/2019 02:17, Hazem Saleh wro
>> My only reservation is that it is a questionable api imho, converting
binary to text just to pass it through the bridge is computationally
expensive and ram intensive and better cameras continue to make it worse.
Regarding this, I think we can generally recommend in the documentation to
use th
I think I am okay with the breaking change, as long as we update major
My only reservation is that it is a questionable api imho, converting binary to
text just to pass it through the bridge is computationally expensive and ram
intensive and better cameras continue to make it worse.
> On Feb 2
I’m +1 to changing it and doing a major release.
It was called data url but it’s not a data url, that’s a bug that has
become “feature”.
I think we should have the new type but that returns current string and
make data url return the real data url and document it on the breaking
changes.
El miér
I don't think the behavior should be changed. If anything, just
introduce another type that has the prefix. And maybe add an alias for
the existing type to make the differences clearer.
On 27/02/2019 03:51, Hazem Saleh wrote:
Hello Team,
When calling navigator.camera.getPicture with destinati
