Re: CB-11602: (android) Adds onRestart event support

2017-01-26 Thread Kerri Shotts
Indeed; it felt distinctly strange documenting launch storyboards in the plugin when 99% of the logic went into the platform instead. IIRC, the code changes in the plugin only amounted to a few lines. ~ Kerri > On Jan 25, 2017, at 16:47, julio cesar sanchez wrote: > > +1, iOS needs the launch

Re: CB-11602: (android) Adds onRestart event support

2017-01-25 Thread julio cesar sanchez
+1, iOS needs the launch images even if you don't install the plugin and the launch storyboard has some of the logic in cordova-ios 2017-01-25 22:31 GMT+01:00 Filip Maj : > +1 ! > > On Wed, Jan 25, 2017 at 11:35 AM, Kerri Shotts > wrote: > > +1 to moving splash screen into platforms. > > > > > >

Re: CB-11602: (android) Adds onRestart event support

2017-01-25 Thread Filip Maj
+1 ! On Wed, Jan 25, 2017 at 11:35 AM, Kerri Shotts wrote: > +1 to moving splash screen into platforms. > > > ~ Kerri > >> On Jan 25, 2017, at 01:09, Simon MacDonald wrote: >> >> I would be happy to see Splash Screen go back to the platforms as well. >> >> Simon Mac Donald >> http://simonmacdona

Re: CB-11602: (android) Adds onRestart event support

2017-01-25 Thread Kerri Shotts
+1 to moving splash screen into platforms. ~ Kerri > On Jan 25, 2017, at 01:09, Simon MacDonald wrote: > > I would be happy to see Splash Screen go back to the platforms as well. > > Simon Mac Donald > http://simonmacdonald.com > > On Tue, Jan 24, 2017 at 10:56 PM, Joe Bowser wrote: > >> O

Re: CB-11602: (android) Adds onRestart event support

2017-01-24 Thread Simon MacDonald
I would be happy to see Splash Screen go back to the platforms as well. Simon Mac Donald http://simonmacdonald.com On Tue, Jan 24, 2017 at 10:56 PM, Joe Bowser wrote: > OK, time to address the elephant in the room: > > Why is the Splashscreen still a plugin? It was only made a plugin because >

Re: CB-11602: (android) Adds onRestart event support

2017-01-24 Thread Joe Bowser
OK, time to address the elephant in the room: Why is the Splashscreen still a plugin? It was only made a plugin because someone wanted to be a purist about plugins, and there's actually no good reason for it to not just be built into Cordova. I used to think Splashscreens were dumb and were used

Re: CB-11602: (android) Adds onRestart event support

2017-01-24 Thread Jesse
I would like to see us move towards making this platform level functionality, The requirements of this API happen mostly outside of the scope of a plugin's lifetime. If we could get to an api that was just, images with the right names are presented when the OS decides to do it, the way all native

RE: CB-11602: (android) Adds onRestart event support

2017-01-20 Thread daserge
Hello, There's a related issue marked as WontFix [1][2] but as far as I understand it does not apply to the SplashScreen plugin as it is initialized on startup (via ). So the question is - should we add onRestart as it is not fundamentally different from onStart, which is supported? Or is there