Just created an issue for swapping to cordovaDependency from engine.
https://issues.apache.org/jira/browse/CB-13123
I agree that we should switch the behavior to fail. It would need to be a
major version of cordova. Chatted with Shaz & Simon and decided it would
make sense to add a flag to current
OMG late to this thread but yes, this should fail and freakout. My
assumption is the same as the person who reported CB-12122 is: any
dependent plugins that fail constraint checking would bubble the
failure up the dependency chain. Unfortunately, the behaviour is not
_super_ explicit in the docs [1
+1 Fail (I think principle of least surprise applies here; most devs would
expect an incompatible plugin to fail the build.)
~ Kerri
> On Jun 2, 2017, at 12:15, Shazron wrote:
>
> Consensus on this long stewing issue of 7 months?
>
> If you deleted the thread:
> 1. Issue https://issues.apache
+1 Fail and freak out so everyone knows!
@purplecabbage
risingj.com
On Fri, Jun 2, 2017 at 10:59 AM, Steven Gill wrote:
> You are right in that we don't fail the build when a incompatible plugin
> fails to install.
>
> cordova-fetch doesn't change this behavior as it is install time vs fetch
>
You are right in that we don't fail the build when a incompatible plugin
fails to install.
cordova-fetch doesn't change this behavior as it is install time vs fetch
time. Also this is a difference between using cordovaDependencies in
package.json vs engine in config.xml. If a CordovaDependencies c
Consensus on this long stewing issue of 7 months?
If you deleted the thread:
1. Issue https://issues.apache.org/jira/browse/CB-12122
2. Thread https://s.apache.org/ofqR
+1 on engine check failing the build.
Questions that need answered: Does cordova-fetch on cordova@7 do this
already, like Simon
I think an engine check should fail the build. If there plugin version
they are trying to use will not work with the version of cordova or
platform they are currently using in their project it should not
build. Folks can screw up their semver in config.xml and end up
pulling in a plugin version tha
See https://issues.apache.org/jira/browse/CB-12122
Right now if a plugin fails an check, it just warns. Should we
make engine checks fail the build?
