Re: File Transfer plugin and Crosswalk engine cookies

2015-02-04 Thread Jesse
eve > Sent: Wednesday, January 28, 2015 10:46 PM > To: dev > Subject: Re: File Transfer plugin and Crosswalk engine cookies > > --webview=crosswalk sounds good. All it will do is add the plugin > >> On Tue, Jan 27, 2015 at 4:09 PM, Murat Sutunc wrote: >> >> What

RE: File Transfer plugin and Crosswalk engine cookies

2015-02-04 Thread Fu, Junwei
2015 9:52 AM To: dev Subject: Re: File Transfer plugin and Crosswalk engine cookies It's not necessary. You can still just add the plugin after-the-fact as well. (but perhaps I'm misunderstanding your question?) On Wed, Feb 4, 2015 at 8:06 PM, Fu, Junwei wrote: > Is it necessa

Re: File Transfer plugin and Crosswalk engine cookies

2015-02-04 Thread Andrew Grieve
e- > From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew > Grieve > Sent: Wednesday, January 28, 2015 10:46 PM > To: dev > Subject: Re: File Transfer plugin and Crosswalk engine cookies > > --webview=crosswalk sounds good. All it will do is add the plugin &g

RE: File Transfer plugin and Crosswalk engine cookies

2015-02-04 Thread Fu, Junwei
Is it necessary to add the flag when creating Cordova project? -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Wednesday, January 28, 2015 10:46 PM To: dev Subject: Re: File Transfer plugin and Crosswalk engine cookies --webview

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-28 Thread Andrew Grieve
>>> development > >>>>> > >>>>> Please let us know if there are anything missed. > >>>>> > >>>>> Thanks, > >>>>> -ningxin > >>>>> > >>>>>> > >>>&g

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-27 Thread Murat Sutunc
gt;>> >>>>> Thanks, >>>>> -ningxin >>>>> >>>>>> >>>>>>> On Mon Jan 26 2015 at 10:14:11 PM Fu, Junwei >>>>>> wrote: >>>>>> >>>>>>> Crosswalk engine

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-27 Thread Jesse
hanks, > > > > -ningxin > > > > > > > > > > > > > > On Mon Jan 26 2015 at 10:14:11 PM Fu, Junwei > > > > wrote: > > > > > > > > > > > Crosswalk engine have been tested with mobile-spec and owned >

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-27 Thread Andrew Grieve
> > > > > > Crosswalk engine have been tested with mobile-spec and owned > > > > > functionality test, but there are no JUnit test for Crosswalk > engine, > > > > > and the JUnit test in cordova-anroid 4.0 were being re-wrote. Does > > the &g

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-27 Thread Joe Bowser
bile-spec and owned > > > > functionality test, but there are no JUnit test for Crosswalk engine, > > > > and the JUnit test in cordova-anroid 4.0 were being re-wrote. Does > the > > > > Crosswalk engine need pass JUnit test before voting on releases? > > > &g

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-27 Thread Andrew Grieve
r Crosswalk engine, > > > and the JUnit test in cordova-anroid 4.0 were being re-wrote. Does the > > > Crosswalk engine need pass JUnit test before voting on releases? > > > What's plan about making JUnit test cases to test pluggable webView. > > > > > &

RE: File Transfer plugin and Crosswalk engine cookies

2015-01-26 Thread Hu, Ningxin
> > Junwei. > > > > -Original Message----- > > From: Joe Bowser [mailto:bows...@gmail.com] > > Sent: Tuesday, January 27, 2015 7:55 AM > > To: dev > > Subject: Re: File Transfer plugin and Crosswalk engine cookies > > > > As far as I'm

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-26 Thread Darryl Pogue
I've got the first (core CordovaLib) part of this as a PR[1]. Would be great to hear if this is the direction we want to go. [1]: https://github.com/apache/cordova-android/pull/151 On 26 January 2015 at 17:25, Andrew Grieve wrote: > Go for it! > > On Mon, Jan 26, 2015 at 7:13 PM, Darryl Pogue w

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-26 Thread Joe Bowser
, January 27, 2015 7:55 AM > To: dev > Subject: Re: File Transfer plugin and Crosswalk engine cookies > > As far as I'm aware, we're basically waiting for this to be done before > starting the vote thread. Does this code exist yet? > > On Tue Jan 20 2015 at 12:12:22

RE: File Transfer plugin and Crosswalk engine cookies

2015-01-26 Thread Fu, Junwei
aking JUnit test cases to test pluggable webView. Thanks, Junwei. -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Tuesday, January 27, 2015 7:55 AM To: dev Subject: Re: File Transfer plugin and Crosswalk engine cookies As far as I'm aware, we're basically wait

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-26 Thread Andrew Grieve
Go for it! On Mon, Jan 26, 2015 at 7:13 PM, Darryl Pogue wrote: > On 26 January 2015 at 15:54, Joe Bowser wrote: > > > > As far as I'm aware, we're basically waiting for this to be done before > > starting the vote thread. Does this code exist yet? > > Not yet on my end. I'll try to get the co

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-26 Thread Darryl Pogue
On 26 January 2015 at 15:54, Joe Bowser wrote: > > As far as I'm aware, we're basically waiting for this to be done before > starting the vote thread. Does this code exist yet? Not yet on my end. I'll try to get the core pieces of it together tonight unless someone else already has a head start.

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-26 Thread Joe Bowser
As far as I'm aware, we're basically waiting for this to be done before starting the vote thread. Does this code exist yet? On Tue Jan 20 2015 at 12:12:22 PM Andrew Grieve wrote: > I was planning on doing exactly what Darryl described. Would love such a > PR! Note that we've just used this appr

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-20 Thread Andrew Grieve
I was planning on doing exactly what Darryl described. Would love such a PR! Note that we've just used this approach for the new WebView security hooks: https://github.com/apache/cordova-android/commit/623b394c830b8a83b5c2f16624d8013b6f851cd9 https://github.com/apache/cordova-android/commit/11002d

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-20 Thread Joe Bowser
I think we should make the File Transfer plugin not need a CookieManager. It sounds like that's the bigger problem than it having to be tied to a particular implementation of Cookies. On Tue Jan 20 2015 at 10:32:25 AM Darryl Pogue wrote: > With the idea of preparing Cordova Android 4.0.x for re

File Transfer plugin and Crosswalk engine cookies

2015-01-20 Thread Darryl Pogue
With the idea of preparing Cordova Android 4.0.x for release starting to come up in discussions, I thought it was worth raising this as a potential blocker. The file transfer plugin uses the Android webview cookie manager. When you're using a Crosswalk webview (or GeckoView presumably), in the be