Re: Code review of new ios plugins

2013-10-21 Thread Shazron
https://issues.apache.org/jira/browse/CB-5138 On Mon, Oct 21, 2013 at 5:10 PM, Shazron wrote: > Answers inline. > > > Looking at the Keyboard & Statusbar plugins, would you be opposed to using: >> >> >> >> instead of: >> >> >> >> > > Agreed. > > >> Would require a major version bump, but prob

Re: Code review of new ios plugins

2013-10-21 Thread Shazron
Answers inline. Looking at the Keyboard & Statusbar plugins, would you be opposed to using: > > > > instead of: > > > > Agreed. > Would require a major version bump, but probably it has little usage since > it's new & in labs still? > > Agreed, major version bump. > Thinking here is that s

Code review of new ios plugins

2013-10-21 Thread Andrew Grieve
Hey Shaz, Looking at the Keyboard & Statusbar plugins, would you be opposed to using: instead of: Would require a major version bump, but probably it has little usage since it's new & in labs still? Thinking here is that since it's not implementing any spec, we should keep symbols off of wi