Re: [iOS] Keyboard Preferences - move to a plugin for 3.2.0

2013-10-02 Thread Andrew Grieve
Nice work Shaz! Like the JS API so that they can be enabled / disabled at runtime. Gotta upload that to the registry! plugman adduser shazron && plugman publish plugins/keyboard On Thu, Oct 3, 2013 at 12:02 AM, Shazron wrote: > Should be in. Try: > plugman install --platform ios --plugin > > h

Re: [iOS] Keyboard Preferences - move to a plugin for 3.2.0

2013-10-02 Thread Shazron
Should be in. Try: plugman install --platform ios --plugin https://git-wip-us.apache.org/repos/asf/cordova-labs.git#plugins:keyboard--project /path/to/your/project/here On Thu, Sep 26, 2013 at 10:25 PM, Shazron wrote: > Alright I'll add it to the > https://github.com/apache/cordova-labs/tree/pl

Re: [iOS] Keyboard Preferences - move to a plugin for 3.2.0

2013-09-26 Thread Shazron
Alright I'll add it to the https://github.com/apache/cordova-labs/tree/plugins branch On Thu, Sep 26, 2013 at 7:30 PM, Brian LeRoux wrote: > +1 > On Sep 26, 2013 11:04 PM, "Michal Mocny" wrote: > > > You mean put it within cordova-labs/plugins? I agree it should start > life > > there. I don

Re: [iOS] Keyboard Preferences - move to a plugin for 3.2.0

2013-09-26 Thread Brian LeRoux
+1 On Sep 26, 2013 11:04 PM, "Michal Mocny" wrote: > You mean put it within cordova-labs/plugins? I agree it should start life > there. I don't think plugins should live in the platform repos, even if > they are currently platform specific. > > > On Thu, Sep 26, 2013 at 4:11 PM, Andrew Grieve

Re: [iOS] Keyboard Preferences - move to a plugin for 3.2.0

2013-09-26 Thread Shazron
Published the branch on apache/cordova-ios/CB-4935 (see the issue for the specific branch commit) Decided to make the settings dynamic, although HideKeyboardFormAccessoryBar can't be "unhidden" currently - so that setting is readonly (there's a TODO: in there) On Thu, Sep 26, 2013 at 4:48 PM, Sha

Re: [iOS] Keyboard Preferences - move to a plugin for 3.2.0

2013-09-26 Thread Shazron
I've added https://issues.apache.org/jira/browse/CB-4935 Scheduled this for 3.2.0 - I've already got this working in a branch on cordova-ios actually (will publish to the branch EOD). I suppose it could go to cordova-labs? On Thu, Sep 26, 2013 at 1:56 PM, Michal Mocny wrote: > You mean put it

Re: [iOS] Keyboard Preferences - move to a plugin for 3.2.0

2013-09-26 Thread Michal Mocny
You mean put it within cordova-labs/plugins? I agree it should start life there. I don't think plugins should live in the platform repos, even if they are currently platform specific. On Thu, Sep 26, 2013 at 4:11 PM, Andrew Grieve wrote: > Makes sense to me if taking it out is feasible code-w

Re: [iOS] Keyboard Preferences - move to a plugin for 3.2.0

2013-09-26 Thread Andrew Grieve
Makes sense to me if taking it out is feasible code-wise. Would encourage people to fork / fiddle with it themselves as well I think. Now that we have a registry, we don't need to create new repos for them (yay!). Maybe just put the plugins within cordova-ios/plugins? I think we'll need to wait u

Re: [iOS] Keyboard Preferences - move to a plugin for 3.2.0

2013-09-24 Thread James Jong
+1 Separating this from the core into a plugin is a good idea. Not sure that this fits into any existing plugin though. -James Jong On Sep 24, 2013, at 2:37 PM, Shazron wrote: > Issue: https://issues.apache.org/jira/browse/CB-3020 > > I've got it mostly working but I'm thinking this really sh

[iOS] Keyboard Preferences - move to a plugin for 3.2.0

2013-09-24 Thread Shazron
Issue: https://issues.apache.org/jira/browse/CB-3020 I've got it mostly working but I'm thinking this really should move to a plugin, perhaps reside in an existing one? The things we are doing with hiding the keyboard accessory bar and shrinking the view etc are hackish and might break with any i