Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/106#issuecomment-126521787
I'm game. Let's make a Jira for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/106#issuecomment-126521511
Ah makes sense - thanks. At what point can we remove this code from
cordova-lib - not sure if support for older project template is that relevant
now? We could
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/106#issuecomment-126520990
It only goes into the case if it's an "old project template." This change
is only expected for newer Cordova projects.
(src/cordova/metadata/windows_parser.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/106#issuecomment-126520317
@robpaveza - Did you get a chance to look at the comment I mentioned?
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/106#issuecomment-126515663
cordova-lib does some replacement using the `displayname` and it might not
work with this change. I'm not tally familiar with what cordova-lib is doing -
but w
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/106
CB-9410: Added preferences for Windows Store ingestion.
`WindowsStoreDisplayName` and `WindowsStorePublisherName` are the new
properties. If they are not provided, we fall back to the de
