[GitHub] cordova-windows pull request: CB-6266 Windows8. Add Whitelisting r...

2014-05-14 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-windows/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cordova-windows pull request: CB-6266 Windows8. Add Whitelisting r...

2014-05-13 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/27#issuecomment-43029923 Ultimately, the issue should be simply that during cordova-cli prepare the values from the cross-device config.xml are copied over to the platform config.xm

[GitHub] cordova-windows pull request: CB-6266 Windows8. Add Whitelisting r...

2014-05-13 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/27#issuecomment-43030700 Agree, default configuration is correct so closing this... But still think that something is broken in prepare step since we shouldn't get redundant values in co

[GitHub] cordova-windows pull request: CB-6266 Windows8. Add Whitelisting r...

2014-05-13 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/27#issuecomment-43030780 Yeah, I will look at that. @purplecabbage risingj.com On Tue, May 13, 2014 at 5:43 PM, Sergey Grebnov wrote: > Agree, def

[GitHub] cordova-windows pull request: CB-6266 Windows8. Add Whitelisting r...

2014-05-13 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/27#issuecomment-43031008 Issue is here: CB-6687 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-windows pull request: CB-6266 Windows8. Add Whitelisting r...

2014-05-13 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/27#issuecomment-43029796 It will be changed after the build command on windows8, will have to check for wp8. You also have to remember that people can create projects for wp8 by

[GitHub] cordova-windows pull request: CB-6266 Windows8. Add Whitelisting r...

2014-05-13 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/27#issuecomment-43029614 Actually it looks strange, that we always have access origin=* on windows8 and wp8, for example, if I change main config.xml and replace * with some real domain,

[GitHub] cordova-windows pull request: CB-6266 Windows8. Add Whitelisting r...

2014-05-13 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/27#issuecomment-43027902 I don't think we need this. It is okay for the template to have a default value of all, and when the build command comes along, it will copy whatever is in

[GitHub] cordova-windows pull request: CB-6266 Windows8. Add Whitelisting r...

2014-04-17 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-windows/pull/27 CB-6266 Windows8. Add Whitelisting rules support from config file Removes default template setting which always allows everything. https://issues.apache.org/jira/browse/CB-6266 You can