Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-203621399
@rakatyal Thanks for prompt review and working with @dubeejw :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/163
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-203584731
Cool. LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dubeejw commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-203582975
@rakatyal, I just copied the content from DummyProject to create the
testProj.
---
If your project is set up for it, you can reply to this email and have your
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57940423
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -419,6 +426,8 @@ describe('windows project handler', function () {
var
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-203562741
I see. Thanks for explaining. Just to make sure, from where did you copied
the content to the proj and the solution files?
---
If your project is set up for i
Github user dubeejw commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57907153
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -305,17 +306,25 @@ describe('windows project handler', function () {
var fra
Github user dubeejw commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57906698
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -85,12 +85,12 @@ var handlers = {
var src = obj.src;
var dest
Github user dubeejw commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-203483657
@rakatyal, the existing test fixtures could not be used because the paths
to the framework references are no longer absolute, they are now relative to
the Cordo
Github user dubeejw commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57905517
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -85,12 +85,12 @@ var handlers = {
var src = obj.src;
var dest
Github user dubeejw commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57905311
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -85,12 +85,12 @@ var handlers = {
var src = obj.src;
var dest
Github user dubeejw commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57904729
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -441,40 +451,47 @@ describe('windows project handler', function () {
});
Github user dubeejw commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57904108
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -164,6 +164,7 @@ describe('windows project handler', function () {
}
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-203131675
Also I couldn't understand the reason for creating a new testproj
directory. Couldn't we have used the existing DummyProject repo for this?
---
If your projec
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57799518
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -85,12 +85,12 @@ var handlers = {
var src = obj.src;
var des
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57799378
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -85,12 +85,12 @@ var handlers = {
var src = obj.src;
var des
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57798321
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -441,40 +451,47 @@ describe('windows project handler', function () {
});
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57797833
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -164,6 +164,7 @@ describe('windows project handler', function () {
}
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57797472
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -305,17 +306,25 @@ describe('windows project handler', function () {
var fr
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-202988290
ping @rakatyal can you review this PR and merge if its good
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user dubeejw commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-200555450
@csantanapr, @nikhilkh, @rakatyal, all tests are now passing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-199926536
@rakatyal to help review after the test failures are fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-199892126
@dubeejw can you review your changes again , CI is failing appveyor and
travois-ci
---
If your project is set up for it, you can reply to this email and ha
GitHub user dubeejw opened a pull request:
https://github.com/apache/cordova-windows/pull/163
CB-10927 - Framework references in plugin.xml file prevent Windows
Universal projects from being used on other machines
- Stop using a hardcoded path to framework references
You ca
24 matches
Mail list logo
