[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-09-09 Thread f3rno
Github user f3rno commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-138998550 @cjpearson, you are a gentleman and a scholar. After nearly a day of on-off debugging due to keyboard related issues, your fork works perfectly (so far) :dancer:

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-05-30 Thread akrymski
Github user akrymski commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-107082152 @Fmstrat it’s just basic js/css … assuming your app is wrapped in a you can use css like this: $(div).css(‘bottom’, keyboardHeight) t

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-05-30 Thread cjpearson
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-107043443 @Fmstrat these changes should be in the latest version. Cordova no longer supports this as a core plugin though. I have a fork [here](https://github.com/cjpear

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-05-29 Thread Fmstrat
Github user Fmstrat commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-106986865 Ahh, I gave that a shot, thanks. I've got a console.log running with the keyboard height, but any idea where I can find an example of using JS to shrink the wind

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-05-29 Thread akrymski
Github user akrymski commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-106972661 I believe the general consensus is that it’s too hard to get resizing to behave reliably across many OS versions, and that the best solution is to use detect

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-05-29 Thread Fmstrat
Github user Fmstrat commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-106969886 So, is this not ever being merged? There are a buttload of posts on Google of people trying to figure out how to get the WebView to resize on 7.1+, it took me al

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-03-30 Thread cjpearson
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-87709992 Thanks for the merge @agrieve. Unfortunately, I've just found another issue. If I recall correctly, one of the major factors was because iOS 7 shrank we

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-03-30 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-87696102 Merged this in, but last I recall discussing the plugin on the dev mailinglist, I don't think anyone was interested in pursuing it. Might try raising the subject

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugins/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-03-28 Thread cjpearson
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-87343580 @davidtlee If you're using the cordova command line, `cordova plugin add "https://github.com/cjpearson/cordova-plugins#master:keyboard"` should work --- If you

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-03-28 Thread davidtlee
Github user davidtlee commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-87331872 Would be great to have this merged in! :) @cjpearson, while I'm waiting for it to get merged in, is there a way for me to use your branch? (do I just c

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-02-11 Thread cjpearson
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-73932253 @akrymski I removed the animation block because it wasn't actually working. Even though the webview's frame was changing size inside the block, the content woul

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-02-10 Thread akrymski
Github user akrymski commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-73753163 Just tried this together with wk-webview and getting compilation errors. Works fine with the old UIWebView though. --- If your project is set up for it, you ca

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-02-10 Thread akrymski
Github user akrymski commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-73752088 Thanks for this, I've been cracking my head open trying to get the web view to shrink! This fork is the only one that does it on the latest iOS 8.1 but you MUST

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-01-27 Thread sandstrom
Github user sandstrom commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-71673165 @shazron friendly ping! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-01-21 Thread cjpearson
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugins/pull/18 CB-8337: Fix keyboardShrinksView for external keyboards, CB-8339 enable keyboardShrinksView on iOS 7.1+ Instead of listening for keyboard show and hide events, the plugin now listens for