[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...

2015-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...

2015-08-04 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/57#issuecomment-127625076 reviewed, lgtm :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...

2015-08-03 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/57#issuecomment-127279922 @dblotsky, rebased and tested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...

2015-07-31 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/57#issuecomment-126635115 Ping. Please rebase atop latest master changes, and verify that it still works. Then we can merge. --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...

2015-06-29 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/57#discussion_r33498946 --- Diff: src/windows/MediaProxy.js --- @@ -35,6 +46,8 @@ module.exports = { var src = args[1]; var thisM = Media.get(id

[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...

2015-06-29 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/57#discussion_r33481593 --- Diff: src/windows/MediaProxy.js --- @@ -35,6 +46,8 @@ module.exports = { var src = args[1]; var thisM = Media.get(i

[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...

2015-06-29 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-media/pull/57 CB-9237 Add cdvfile:// support to media plugin on windows platform Mentioned cdvfile support in the documentation [JIRA issue](https://issues.apache.org/jira/browse/CB-9237) Yo