Github user sarangan12 closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/89
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-204059792
Merged to apache git repo (by @rakatyal) Closing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-203159625
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-203137750
Is there any reason to specify the upper bound?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-203122183
Locally always...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-202714763
How often does the test pass now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/89#discussion_r57616771
--- Diff: tests/tests.js ---
@@ -373,7 +373,7 @@ exports.defineAutoTests = function () {
setTimeout(function () {
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/89#discussion_r57616106
--- Diff: tests/tests.js ---
@@ -373,7 +373,7 @@ exports.defineAutoTests = function () {
setTimeout(function () {
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/89
CB-10783: Media Plugin - Modify expected position to be in a proper range
Fix for the flaky tests in Media Plugin.
[Link](https://cloud.githubusercontent.com/assets/602456/14087006/d
