[GitHub] cordova-plugin-media pull request: By default always first check D...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/16#issuecomment-219900367 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/16/commits/84e600382a268

[GitHub] cordova-plugin-media pull request: By default always first check D...

2016-03-22 Thread ghenry22
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/16#issuecomment-200148555 At this point it might be more sensible to drop the steps that auto search in a few folders and instead have a simple explicity behaviour. This would cut

[GitHub] cordova-plugin-media pull request: By default always first check D...

2014-08-13 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/16#issuecomment-52055461 This needs to be documented in a README or other document. I shouldn't have to read the source of the plugin to discover this. Also, please have an is

[GitHub] cordova-plugin-media pull request: By default always first check D...

2014-08-13 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/16#discussion_r16177949 --- Diff: src/ios/CDVSound.m --- @@ -36,25 +36,32 @@ - (NSURL*)urlForResource:(NSString*)resourcePath { NSURL* resourceURL = nil;

[GitHub] cordova-plugin-media pull request: By default always first check D...

2014-04-22 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/16#issuecomment-41097714 So to clarify, if you have a file in your Documents folder called "foo.mp3": Currently this won't work: new Media("foo.mp3", mediaSuccess, mediaEr

[GitHub] cordova-plugin-media pull request: By default always first check D...

2014-04-22 Thread emarashliev
GitHub user emarashliev opened a pull request: https://github.com/apache/cordova-plugin-media/pull/16 By default always first check Documents directory. The main idea is, when we have a developer app such as "PhoneGap Developer" or "Telerik AppBuilder™", the user to be able to tes