[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...

2014-03-24 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/31#issuecomment-38511972 no. github should auto-close this soon, I already merged --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...

2014-03-24 Thread rocco
Github user rocco commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/31#issuecomment-38511085 want me to open another pr on dev? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...

2014-03-24 Thread rocco
Github user rocco commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/31#issuecomment-38510907 sorry, overlooked that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...

2014-03-24 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/31#issuecomment-38510496 Pulling this in to dev branch - but take note it should be a pull request to the dev branch always for next time. --- If your project is set up for

[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...

2014-03-22 Thread rocco
GitHub user rocco opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/31 event name and example param update Some example code failed due to missing arguments, so I added them, also there is no "load" event, must be "loadstop" You can merge this pull r