Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75#issuecomment-213620416
lgtm, merged!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75#issuecomment-210671046
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75#discussion_r59950490
--- Diff: README.md ---
@@ -296,3 +311,436 @@ callback function when an error occurs with
navigator.geolocation.
- Returned when t
Github user normesta commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75#discussion_r59793647
--- Diff: README.md ---
@@ -296,3 +311,436 @@ callback function when an error occurs with
navigator.geolocation.
- Returned when t
Github user normesta commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75#discussion_r59793230
--- Diff: README.md ---
@@ -296,3 +311,436 @@ callback function when an error occurs with
navigator.geolocation.
- Returned when t
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75#discussion_r58266872
--- Diff: README.md ---
@@ -296,3 +311,436 @@ callback function when an error occurs with
navigator.geolocation.
- Returned when t
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75#issuecomment-204563680
Also I know this is not completely on you, but would you mind adding a list
(index) at the starting of the README with links to the major headings? T
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75#discussion_r58266173
--- Diff: README.md ---
@@ -296,3 +311,436 @@ callback function when an error occurs with
navigator.geolocation.
- Returned when t
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75#issuecomment-204179610
I've gone ahead and created a JIRA to track this effort
([CB-11003](https://issues.apache.org/jira/browse/CB-11003))
---
If your project is set up
GitHub user normesta opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75
New PR for sample content - sample link removed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/normesta/cordova-plugin-geol
11 matches
Mail list logo
