Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-209689870
@silhouettes I don't think @stevengill will reply on this thread but maybe
now that he's been @ messaged. I'm sure there will be a plugins release for
Cor
Github user silhouettes commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-208582527
@Macdonst, should I follow up with this person to get a rough guess on the
timeline (in which case I might need his details), or will he respond in this
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-208579024
@rakatyal no one really responded with a date and I'm going to hand it over
to Steve to get the release out.
---
If your project is set up for it, you ca
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-208566190
@macdonst: Hey Simon! I know you were planning to do a plugin release. Any
update on when it's scheduled?
---
If your project is set up for it, you can r
Github user silhouettes commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-208564502
@rakatyal, do you happen to know when this will be released, or who I could
ask? Just to see if we should wait for it on our own plugin:
https://github
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56579423
--- Diff: src/android/FileUtils.java ---
@@ -73,8 +73,13 @@ Licensed to the Apache Software Foundation (ASF) under
one
* Permission ca
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56578493
--- Diff: src/android/FileUtils.java ---
@@ -1113,7 +1160,8 @@ public void onRequestPermissionResult(int
requestCode, String[] permissions,
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56601156
--- Diff: src/android/FileUtils.java ---
@@ -1124,7 +1171,18 @@ public void run(JSONArray args) throws
FileExistsException, IOException, TypeMis
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56600287
--- Diff: src/android/FileUtils.java ---
@@ -433,28 +434,41 @@ public void run(JSONArray args) throws JSONException,
IOException {
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56579806
--- Diff: src/android/FileUtils.java ---
@@ -1124,6 +1172,18 @@ public void run(JSONArray args) throws
FileExistsException, IOException, TypeMis
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56606932
--- Diff: src/android/FileUtils.java ---
@@ -73,8 +73,11 @@ Licensed to the Apache Software Foundation (ASF) under
one
* Permission ca
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56607030
--- Diff: src/android/FileUtils.java ---
@@ -1124,7 +1171,18 @@ public void run(JSONArray args) throws
FileExistsException, IOException, TypeMis
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56599180
--- Diff: src/android/FileUtils.java ---
@@ -73,8 +73,11 @@ Licensed to the Apache Software Foundation (ASF) under
one
* Permission ca
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56595658
--- Diff: src/android/FileUtils.java ---
@@ -1113,7 +1160,8 @@ public void onRequestPermissionResult(int
requestCode, String[] permissions,
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56578082
--- Diff: src/android/FileUtils.java ---
@@ -1113,7 +1160,8 @@ public void onRequestPermissionResult(int
requestCode, String[] permissions,
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56562785
--- Diff: src/android/FileUtils.java ---
@@ -347,18 +348,25 @@ else if (action.equals("write")) {
threadhelper( new FileOp( ){
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56579558
--- Diff: src/android/FileUtils.java ---
@@ -444,17 +458,19 @@ else if (action.equals("getFile")) {
threadhelper( new FileOp( ){
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56701738
--- Diff: src/android/FileUtils.java ---
@@ -433,28 +434,41 @@ public void run(JSONArray args) throws JSONException,
IOException {
e
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-198148373
You can also refactor `needPermission` into `needWritePermission` and
`needReadPermission`, and similarly you can add `getPermissionWriteFile`,
`getPermis
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56579672
--- Diff: src/android/FileUtils.java ---
@@ -550,6 +577,26 @@ private boolean hasWritePermission() {
return PermissionHelper.hasPerm
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-198047033
@riknoll , @dblotsky , @jasongin : Addressed feedback and added case for
{create: true} flag.
---
If your project is set up for it, you can reply to this
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56722724
--- Diff: src/android/FileUtils.java ---
@@ -433,28 +434,41 @@ public void run(JSONArray args) throws JSONException,
IOException {
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55908300
--- Diff: src/android/FileUtils.java ---
@@ -347,18 +348,25 @@ else if (action.equals("write")) {
threadhelper( new FileOp( ){
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55904524
--- Diff: src/android/FileUtils.java ---
@@ -347,18 +348,25 @@ else if (action.equals("write")) {
threadhelper( new FileOp( ){
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55904424
--- Diff: src/android/FileUtils.java ---
@@ -75,6 +75,7 @@ Licensed to the Apache Software Foundation (ASF) under one
public stati
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55904187
--- Diff: src/android/FileUtils.java ---
@@ -75,6 +75,7 @@ Licensed to the Apache Software Foundation (ASF) under one
public stati
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55900124
--- Diff: src/android/FileUtils.java ---
@@ -435,8 +443,23 @@ else if (action.equals("getDirectory")) {
public void run(JSON
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55899953
--- Diff: src/android/FileUtils.java ---
@@ -347,18 +348,25 @@ else if (action.equals("write")) {
threadhelper( new FileOp( ){
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55899536
--- Diff: src/android/FileUtils.java ---
@@ -75,6 +75,7 @@ Licensed to the Apache Software Foundation (ASF) under one
public stati
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/170
CB-10798, CB-10384: Fixing permissions for Marshmallow
The present code used to ask for permissions on Marshmallow while even
trying to read/write from the application's own locations.
31 matches
Mail list logo
