[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...

2014-12-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/46 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...

2014-12-12 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66841786 Cool, I see you on the list now http://people.apache.org/committer-index.html I'll get back to this over the weekend or early next week. --- If your p

[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...

2014-12-12 Thread BigstickCarpet
Github user BigstickCarpet commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66826408 @kamrik I just got an email confirming that my iCLA is now on file. --- If your project is set up for it, you can reply to this email and have you

[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...

2014-12-11 Thread BigstickCarpet
Github user BigstickCarpet commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66696186 Ok. I'll fill out an iCLA and send it in later today. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...

2014-12-11 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66686970 Here is [the corresponding JIRA issue](https://issues.apache.org/jira/browse/CB-7955) --- If your project is set up for it, you can reply to this email a

[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...

2014-12-11 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66686534 James, did you sign the Apache CLA? I don't see you on the list yet. Apache requires this. http://people.apache.org/committer-index.html http://cord

[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...

2014-12-11 Thread BigstickCarpet
Github user BigstickCarpet commented on a diff in the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/46#discussion_r21704134 --- Diff: www/browser/notification.js --- @@ -0,0 +1,94 @@ +// Platform: browser +window.navigator.notification = window.navigat

[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...

2014-12-11 Thread kamrik
Github user kamrik commented on a diff in the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/46#discussion_r21702976 --- Diff: www/browser/notification.js --- @@ -0,0 +1,94 @@ +// Platform: browser +window.navigator.notification = window.navigator.notif

[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...

2014-12-11 Thread BigstickCarpet
GitHub user BigstickCarpet opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/46 Added support for the new "browser" platform in Cordova 4 The new browser platform in Cordova 4 is awesome. And now this plugin is awesome because it supports it. :) You c