[GitHub] cordova-plugin-contacts pull request: custom label for phoneNumber

2015-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request: custom label for phoneNumber

2015-09-29 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/67#issuecomment-144191524 I am closing this pr as it has conflicts, and un-does other commits. The discussion thread can be found here: https://github.com/cordova/cordo

[GitHub] cordova-plugin-contacts pull request: custom label for phoneNumber

2015-07-14 Thread typevitor
Github user typevitor commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/67#issuecomment-121346507 Sorry, my mistake the removed hasPhoneNumber. I'll start a discussion then. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-contacts pull request: custom label for phoneNumber

2015-07-14 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/67#issuecomment-121323697 Um, no. You just removed the hasPhoneNumber functionality which was just added a couple weeks ago? You need to consider more than just Andr

[GitHub] cordova-plugin-contacts pull request: custom label for phoneNumber

2015-07-14 Thread typevitor
GitHub user typevitor opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/67 custom label for phoneNumber writing the possibility for adding custom label for phoneNumbers. You can merge this pull request into a Git repository by running: $ git pull htt