[GitHub] cordova-plugin-contacts pull request: CB-3950 Do not replace custo...

2015-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request: CB-3950 Do not replace custo...

2015-11-26 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/90#issuecomment-159933019 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-contacts pull request: CB-3950 Do not replace custo...

2015-11-26 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/90#discussion_r45985736 --- Diff: src/ios/CDVContact.m --- @@ -750,7 +750,9 @@ + (CFStringRef)convertContactTypeToPropertyLabel:(NSString*)label } else if (

[GitHub] cordova-plugin-contacts pull request: CB-3950 Do not replace custo...

2015-11-26 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/90#discussion_r45985746 --- Diff: src/ios/CDVContact.m --- @@ -787,7 +789,9 @@ + (NSString*)convertPropertyLabelToContactType:(NSString*)label } else if

[GitHub] cordova-plugin-contacts pull request: CB-3950 Do not replace custo...

2015-11-26 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/90 CB-3950 Do not replace custom labels with "Other" on contact save https://issues.apache.org/jira/browse/CB-3950 You can merge this pull request into a Git repository by runn