Github user alsorokin closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/209
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-219966472
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-camera/pull/209/commits/278b527
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63490344
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63394732
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts)
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63394154
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts);
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63387806
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts);
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63327575
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63323857
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, o
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63320919
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-219189308
Cordova CI Build has completed successfully.
**Dashboard** -
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera/3/
**Resu
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-219182375
Awesome! LGTM other than the one comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63256712
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts);
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-219080266
@riknoll I've updated the PR.
* De-duplicated specs code
* Implemented image type verification
* Added a couple of specs with quality 100 (ad
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-218538540
It would be nice to refactor the specs a bit, because they seem to be 90%
shared code. This looks pretty good! Reading the file and checking the
dimensio
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-218023433
@riknoll to help review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/209
CB-11183 Appium tests: Added image verification
https://issues.apache.org/jira/browse/CB-11183
You can merge this pull request into a Git repository by running:
$ git pull http
16 matches
Mail list logo
