[GitHub] cordova-plugin-camera pull request: CB-11034: Camera.getPicture -H...

2016-04-09 Thread elsewhat
Github user elsewhat commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/201#issuecomment-207814319 @riknoll @nikhilkh as an app developer I have to disagree with you. I would **expect a framework such as cordova to never crash an app under no circu

[GitHub] cordova-plugin-camera pull request: CB-11034: Camera.getPicture -H...

2016-04-08 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/201#issuecomment-207661306 There are definitely cases where native exceptions should be surfaced to the javascript, but memory issues are the responsibility of the native developer

[GitHub] cordova-plugin-camera pull request: CB-11034: Camera.getPicture -H...

2016-04-08 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/201#issuecomment-207659474 Ah, I think I misunderstood your JIRA and I agree with @nikhilkh that optimizing our memory use is the right approach. Looking through the code, it seems

[GitHub] cordova-plugin-camera pull request: CB-11034: Camera.getPicture -H...

2016-04-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/201#issuecomment-207648380 Silently handling OutOfMemoryError is not a good idea - we should look to optimize the code so that it uses less memory instead. --- If your project is

[GitHub] cordova-plugin-camera pull request: CB-11034: Camera.getPicture -H...

2016-04-07 Thread elsewhat
GitHub user elsewhat opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/201 CB-11034: Camera.getPicture -Handle of OutOfMemoryError gracefull Catch OutOfMemoryError for memory intensive operations and handle them gracefully. Tested on a Samsung S