[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

2016-12-14 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92491112 --- Diff: lib/appium/AppiumRunner.js --- @@ -102,6 +102,24 @@ function getConfigPath(appPath) { return path.join(appPath, 'config.xml');

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

2016-12-14 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92469947 --- Diff: lib/appium/AppiumRunner.js --- @@ -102,6 +102,24 @@ function getConfigPath(appPath) { return path.join(appPath, 'config.xml'

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

2016-12-14 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92348958 --- Diff: lib/appium/AppiumRunner.js --- @@ -102,6 +102,24 @@ function getConfigPath(appPath) { return path.join(appPath, 'config.xml');

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

2016-12-13 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92190252 --- Diff: package.json --- @@ -51,7 +51,7 @@ "wd": "^0.4.0" }, "devDependencies": { -"jasmine-node": "~1", -

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

2016-12-13 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92180262 --- Diff: package.json --- @@ -51,7 +51,7 @@ "wd": "^0.4.0" }, "devDependencies": { -"jasmine-node": "~1", -"js

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

2016-12-13 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92122133 --- Diff: lib/paramedic.js --- @@ -271,9 +271,13 @@ ParamedicRunner.prototype.runLocalTests = function () { }) .then(function(com

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

2016-12-12 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92111761 --- Diff: package.json --- @@ -51,7 +51,7 @@ "wd": "^0.4.0" }, "devDependencies": { -"jasmine-node": "~1", -

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

2016-12-12 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92113708 --- Diff: lib/appium/AppiumRunner.js --- @@ -419,8 +411,9 @@ AppiumRunner.prototype.prepareApp = function () { var deviceString = self.opt

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

2016-12-12 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92112118 --- Diff: lib/paramedic.js --- @@ -271,9 +271,13 @@ ParamedicRunner.prototype.runLocalTests = function () { }) .then(function(com