Github user omefire commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217527951
Haha, I just realized we should have updated the title to 'Fixing flaky XHR
Test' instead of 'Removing ...'.
Oh well, ...
---
If your project is set u
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user omefire commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217527093
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217516568
Thanks @purplecabbage for the info. @omefire: Yes the flakiness is related
to the host. It becomes randomly unavailable. I will update the PR to make get
Github user omefire commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217509068
@rakatyal Is the flakiness related to the host we're XHR'ing to ? Would
switching from 'http://cordova-filetransfer.jitsu.com' to something else(e.g:
'http
Github user omefire commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217508257
Thanks @purplecabbage for confirming.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217338006
Yes it is needed. jQuery mobile broke because apps were not permitted to
xhr to their own resources.
It IS browser functionality, BUT we still ne
Github user omefire commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217334128
It seems like this whole test suite is only about checking browser/webview
functionality.
Do we still really need them ?
---
If your project is set up
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/140
CB-11050 Removing the flaky XHR Test
This test isn't really needed since it's just checking the browser's
functionality.
You can merge this pull request into a Git repository by runn
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217307363
@sarangan12 , @omefire: Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
10 matches
Mail list logo
