[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/581#discussion_r132758763 --- Diff: src/cordova/plugin/remove.js --- @@ -68,6 +68,7 @@ function remove (projectRoot, targets, hooksRunner, opts) {

[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/581#discussion_r132758854 --- Diff: spec/cordova/plugin/remove.spec.js --- @@ -32,18 +66,123 @@ describe('cordova/plugin/remove', function () { expect(e.me

[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

2017-07-21 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/581 CB-12361 : added plugin remove tests ### Platforms affected ### What does this PR do? Added plugin remove tests. ### What testing has been done on this